| Age | Commit message (Collapse) | Author |
|---|
|
If this happens the imsg may no longer be usable as there may be queued
messages, but this is a) already the case with the code now, and b)
would be the case if recvmsg() fails anyway, so we can document that -1
from imsg_read() invalidates the struct imsgbuf.
discussed with and ok eric
|
|
be done for rtmsgs (which have an rtm_errno) and not ifmsgs (which have
part of an if_data struct in that location). Fixes problems finding
interface addresses at startup. ok claudio@
|
|
OK dlg@
|
|
OK: henning@, claudio@
|
|
Sync description of the OSPF protocol between ospfd(8) and ospf6d(8).
Document current shortcomings -- in particular, document that ospf6d(8)
needs manual IPsec setup for security. Clean up various grammatical errors,
re-order and re-phrase things a bit to improve readability.
Update RFC references. Remove IPv4-specific stuff from ospf6d.conf(5).
OK jmc@ claudio@
|
|
in these cases, is useless anyway.
Found by and fixing the build with mandoc;
still fine with both old and new groff.
ok jmc@
|
|
in slightly different ways. this unifies these handlers and cuts
fetchtable over to using the generic handler.
help from claudio@ and sthen@
ok claudio@
|
|
dispatch_rtmsg, factor the message handling out. both fetchifs and
dispatch_rtmsg get a buffer full of messages and then run it through a
parser. now they get their buffers and pass it to rtmsg_process.
ok claudio@
|
|
refetchtable.
tested by me and sthen@
ok claudio@
|
|
From Christiano F. Haesbaert.
ok claudio@
|
|
|
|
this tells the daemon to resync the kernels list of interfaces and routes
with the daemons list. this is very useful if the routing socket overflows
and you want to sync things up again.
lots and lots of help from claudio@
ok claudio@
|
|
inform about the interface address change. If this is an active interface
it will be downed. A ospfctl reload is needed to fetch the new/changed IP
if one got set. OK dlg@, sthen@
|
|
the interface was removed or when the address changed leaving the multicast
groups will fail because that already happend. Fix if_leave_group() to
remove the refcount before doing the ioctl() so that the reference is
correctly removed. OK dlg@, sthen@
|
|
with reloads when running ospfd on multiple aliases on the same interface.
Is also needed to handle interface address changes in a much better way.
OK dlg@, sthen@
|
|
process more reliable after interface flaps. Especially when the router-id
changed at the same time.
OK dlg@, sthen@
|
|
neighbors from using the source IP on broadcast interfaces to using the
router-id all the time. The interface lookup will already check for
matching subnets so there is no conflict possible. This makes ospfd finally
grok router-id changes without freaking out. Additionally whinge when an
other router is using the same router-id instead of failing in a very
horrible way.
OK sthen@, dlg@
|
|
OK dlg@, sthen@
|
|
if route-dead-time is set to "minimal" (rather than a number of
seconds), the dead time is set to 1 second and hellos are sent at
the interval specified by fast-hello-interval in msecs. this is non
standard wrt to the ospf rfc, but it does interoperate with at least
one other router vendor.
this allows much better responsiveness to l3 topology changes than
the standard intervals allow. if i yank a cable to one of my
upstreams, the routes adjust in a second rather than the default
of 40 i was running with before. the users dont even notice something
changed.
developed while working with joshua atterbury.
ok claudio@ as part of a larger diff.
dedicated to zan rowe who thinks she is a bigger nerd than me.
|
|
pointed out by claudio@ before, somehow it snuck back in.
|
|
better respond to rapid topology changes.
developed while working with joshua atterbury
ok claudio@ as part of a larger diff.
|
|
state machine needed by the features that are coming along.
ok claudio@
|
|
|
|
`OK' claudio
|
|
|
|
ok claudio@
|
|
router link in a type-1 LSA.
|
|
NULL would be bad. So instead use a fatalx() in that impossible case.
After a discussion with deraadt@ because of a parfait warning.
|
|
|
|
It always annoyed me that in case of a problem I had to restart the ospf in
forground debug mode and by doing so losing all routes at least twice.
OK henning, sthen, michele
|
|
few remaining ".Tn UNIX" macros with ".Ux" ones.
pointed out by ratchov@, thanks!
ok jmc@
|
|
ok jmc@
|
|
Change this so that the real nexthop is announced if the following
conditions are met:
- the nexthop is reachable via an OSPF enabled interface
- the interface is a broadcast or NBMA interface
It does not make sense to announce the nexthop of a point-to-point link
since the traffic has to go through this box anyway. This is closer to
what other systems implement.
|
|
|
|
when fail-over happens, since removing the better route will not result
in a blackhole until the update from the new master is processed.
Tested, OK and input sthen@, phessler@
|
|
|
|
in an error path.
|
|
loop in the shutdown case. OK henning@
|
|
|
|
- remove some unnecessary \& escapes
ok claudio, jmc
|
|
function, which is additionally exported for use by others.
It will be needed by smtpd's SSL module when the SMTP client code
is changed to replace libevent's evbuffers with our msgbuf_* API.
ok gilles@ henning@ guenther@ eric@
|
|
bytes is not enough for larger networks causing send errors because of
too big packets. OK henning
|
|
freeing the msgbuf.
While here also remove an unnecessary while loop.
ok eric pyr
|
|
|
|
bytes that were filled, not the whole buffer.
ok pyr@ gilles@
|
|
|
|
|
|
Make the imsg protocol network-safe.
it might be network safe, but half the imsg based daemons on my firewalls
dont run anymore.
|
|
Currently the receiver fetches an imsg via imsg_get() and if he expects
an fd, he then calls imsg_get_fd() to fetch the next fd queued on the
imsgbuf from which the imsg came.
This changes hides the fd queueing mechanism to the API user. When closing
an imsg with an fd, the message is flagged so that the receiving end knows
it must dequeue the fd in imsg_get() and return it with the imsg structure.
This way there is no (less) possible screw up from imsg_get_fd() not being
called directly after imsg_get() by the user. The retreived imsg is
self-contained.
ok pyr@, "I like that" henning@
|
|
ok pyr@
|
