summaryrefslogtreecommitdiff
path: root/usr.sbin/ospfd
AgeCommit message (Collapse)Author
2016-06-21do not allow whitespace in macro names, i.e. "this is" = "a variable".Sebastian Benoit
change this in all config parsers in our tree that support macros. problem reported by sven falempin. feedback from henning@, stsp@, deraadt@ ok florian@ mikeb@
2016-06-06add format attributes to the proper functions and then fix theSebastian Benoit
warning in rde.c ok stsp@
2016-02-18Fix format string of a warning.Alexander Bluhm
from markus@; OK claudio@
2016-02-02Remove setproctitle() for the parent process. Because rc.d(8) uses processStuart Henderson
titles (including flags) to distinguish between daemons, this makes it possible to manage multiple copies of a daemon using the normal infrastructure by symlinking rc.d scripts to a new name. ok jung@ ajacoutot@, smtpd ok gilles@
2015-12-05Pledge ospfd SE ("stdio inet mcast") and RDE ("stdio") move some codeClaudio Jeker
around to make it possible. Parent can't be pledged at the moment because of carp ioctl (carp demote). Putting it in so that people can test. OK benno@
2015-12-03imsg_read will return EAGAIN in some cases so prep code for it.Claudio Jeker
This is in the way for ospfd pledge so in it goes. OK benno@
2015-11-22Improve ABR support especially for self-originated stub networks.Claudio Jeker
This seems to solve the last issues people reported when using ospfd in multiple areas. OK sthen@ prodding by deraadt@
2015-10-26Kernel got fixed we no longer need to check if rtm_pid is 0 to filter outClaudio Jeker
route messages that are not from us.
2015-10-24Filter our RTM_GET messages which are not from us.Claudio Jeker
2015-09-27As done for bgpd recently, rename if_mediatype to if_type in ospfd/ospf6d.Stefan Sperling
And some ifmedia64 fixes. "move forward" deraadt@
2015-07-27use file system path (.Pa) semantic markup macros where appropriate.Igor Sobrado
ok jmc@
2015-07-20Fix a segfault at startup when if_change() ist called beforeSebastian Benoit
imsg_init() exposed by the second part of this diff which makes carp(4) interfaces be recognized to be in "backup" mode on start-up. Problem analyzed and fix provided by Johan Ymerson, thanks! ok claudio@, mpi@
2015-07-19revert previousSebastian Benoit
Properly handle carp(4) interfaces in "backup" mode on start-up. Problem analyzed and fix provided by Johan Ymerson, thanks! ok claudio@, benno@ it breaks on systems without carp because iev_ospfe is not initiallized at the time kif_init() is called in main.
2015-07-18Properly handle carp(4) interfaces in "backup" mode on start-up.Martin Pieuchot
Problem analyzed and fix provided by Johan Ymerson, thanks! ok claudio@, benno@
2015-07-17Do similar handling of connected routes and filtering of llinfo and broadcast.Claudio Jeker
With this the ospfd fib and the kernel routing table are better in sync.
2015-05-05use the sizeof the struct not the sizeof a pointer to the structJonathan Gray
ok claudio@
2015-03-14When removing interfaces in the RDE we also need to remove all the RDEClaudio Jeker
neighbors that are part of that interface or we open us up to use after free situations like the one found by sthen@. Diff makes sense sthen@
2015-03-13Make sure that the debug messages include the neighbor ID so we hava a chanceClaudio Jeker
to know which neighbor caused the problems. While there make sure that all messages log roughly in the same way.
2015-03-11tweak wording; "a value different to 1" -> "...other than 1", from Sevan JaniyanStuart Henderson
2015-02-11Use sizeof(u_short) in the first check since there are RT messages thatClaudio Jeker
are less then sizeof(*rtm) bytes long (e.g. interface announcements). Found the hard way by phessler@
2015-02-10Forgot the EAGAIN or EINTR check on read.Claudio Jeker
2015-02-10Convert ospfd over to SOCK_CLOEXEC | SOCK_NONBLOCK and make the routeClaudio Jeker
socket non-blocking. Introduce the same trigger for partial rt msgs.
2015-01-28When comparing the LSA with the Ack, also check the age field. ThisAlexander Bluhm
ensures that a LSA withdrawal is not acked by a previous update. From Florian Riehm; OK claudio@
2015-01-22remove a stupid -Wstrict-prototype warning by making the hash functionTed Unangst
static. noticed by florian riehm
2015-01-16Replace <sys/param.h> with <limits.h> and other less dirty headers whereTheo de Raadt
possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)
2014-12-18simple to use siphash here. ok deraadtTed Unangst
2014-11-20Don't allow embedded nul characters in strings.Jonathan Gray
Fixes a pfctl crash with an anchor name containing an embedded nul found with the afl fuzzer. pfctl parse.y patch from and ok deraadt@
2014-11-18Nuke more obvious #include duplications.Kenneth R Westerback
ok deraadt@ millert@ tedu@
2014-11-03Convert the logic in yyerror(). Instead of creating a temporaryAlexander Bluhm
format string, create a temporary message. OK deraadt@ claudio@
2014-11-02Add gcc format attributes to parse.y for ospf{6,}d.Doug Hogan
Fix a few yyerror() lines that are missing arguments. ok claudio@ sthen@
2014-10-25Remove unnecessary netinet/in_systm.h include.Lawrence Teo
ok millert@
2014-07-20Fixed typo in error message.Tobias Stoeckmann
okay deraadt@
2014-07-12Close connections when msgbuf_write() returns 0.Kenneth R Westerback
ok claudio@
2014-07-11Close the control fd when it has reported EOF.Kenneth R Westerback
ok henning@
2014-06-23The second level of the CTL_NET sysctl is a PF_*, not an AF_*Philip Guenther
inconsistent usage in route(8) noted by Gregor Best (gbe (at) ring0.de)
2014-01-22relax the cfg file secrecy check slightly to allow group readabilityHenning Brauer
default permissions and mtree NOT changed. prodded by benno, ok phessler benno jmatthew theo pelikan florian
2013-11-25use u_char for buffers in yylex, for ctype callsSebastian Benoit
found by millert@, ok deraadt@
2013-11-13from claudioSebastian Benoit
"Let msgbuf_write return -1 with errno EAGAIN. The users then must check if this was the case and readd the event or poll again. The current handling in the imsg code is wrong for sure." ok gilles, benno
2013-10-30another simple %i to %d conversion for obviousnessTheo de Raadt
2013-08-14Enforce that the ls_id and the adv_rtr field in a type 1 router LSA areClaudio Jeker
the same. This will drop updates trying to attack the OSPF LSDB. For ospfd such bad router LSA were never a problem since the LSA lookup always includes the ls_id and adv_rtr -- so the bad packets would have never been picked up by the SPF calculation. OK bluhm@ benno@
2013-08-14no longer any need to quote macro lines with >9 args;Jason McIntyre
From: Jan Stary
2013-06-01Minor cleanup, do not set values to 0 twice.Claudio Jeker
2013-03-22whitespace tweak; gratuitous difference with ospf6dStuart Henderson
2013-03-22reinstate code to announce routes to backup carp interfaces. this was removedStuart Henderson
in a cleanup in r1.83, but we do still want to announce these (with a high metric), so that a specific route to the relevant network is maintained during failover. ok florian@ claudio@
2013-03-11handle ECONNABORTED errors from accept(). In many code blocks they can beTheo de Raadt
ignored silently and without aborting, much like EINTR and EWOULDBLOCK are. ok's from various maintainers of these directories...
2013-03-06sync yyerror() with version in bgpd so that it logs to syslog when daemonized.Stuart Henderson
ok florian@
2013-03-06When dumping config, just print "passive" for passive interfaces ratherStuart Henderson
than showing hello timers/keys. ok florian@
2013-01-17improve snapshot handling:Markus Friedl
- don't start a new snapshot if we are already in NBR_STA_SNAP - ignore IMSG_DB_SNAPSHOT and IMSG_DB_END unless we are in NBR_STA_SNAP - add new IMSG_LS_SNAP message so we can distinguish it from IMSG_LS_UPD. this way we can ignore them if we are not in NBR_STA_SNAP ok claudio@
2013-01-17do not send IMSG_LS_UPD if we have no links; ok claudioMarkus Friedl
2013-01-17ignore the nbr_adj_timer if we are not forming adjacencies; ok claudioMarkus Friedl