Age | Commit message (Collapse) | Author | |
---|---|---|---|
2022-03-31 | man pages: add missing commas between subordinate and main clauses | Christian Weisgerber | |
jmc@ dislikes a comma before "then" in a conditional, so leave those untouched. ok jmc@ | |||
2021-10-24 | For open/openat, if the flags parameter does not contain O_CREAT, the | Theo de Raadt | |
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past have passed mode_t (0, 044, 0644, or such), which might lead future people to copy this broken idiom, and perhaps even believe this parameter has some meaning or implication or application. Delete them all. This comes out of a conversation where tb@ noticed that a strange (but intentional) pledge behaviour is to always knock-out high-bits from mode_t on a number of system calls as a safety factor, and his bewilderment that this appeared to be happening against valid modes (at least visually), but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef. ok millert | |||
2021-09-03 | sigh -- review one one pointless sys/param.h, and discover all the includes | Theo de Raadt | |
are a mess. | |||
2020-12-29 | getifaddrs() can return entries where ifa_addr is NULL. Check for this | Sebastian Benoit | |
before accessing anything in ifa_addr. ok claudio@ | |||
2020-12-03 | grammar fixes from Varik "The Genuine Article!!!" Valefor; | Jason McIntyre | |
2019-06-28 | When system calls indicate an error they return -1, not some arbitrary | Theo de Raadt | |
value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future. | |||
2019-05-12 | remove .PATH. this was used in previous eras to build bpf compiler stuff, | Ted Unangst | |
that's all used via libpcap now. found by deraadt ok tb | |||
2019-01-22 | PF_ROUTE -> AF_ROUTE in the scattered sock()/setsockopt() calls | Kenneth R Westerback | |
where the "wrong" #define was used. ok dlg@ | |||
2018-07-28 | k&r -> ansi function headers in this file, 'cause clang complained about one. | Theo de Raadt | |
2017-11-17 | Use explicit_bzero to erase secrets | Jeremie Courreges-Anglas | |
from Scott Cheloa, ok tb@ | |||
2016-06-24 | use crypt_checkpass to simplify password checking logic. | Ted Unangst | |
2016-05-17 | remove pam and shadow code that's not used. ok deraadt jca | Ted Unangst | |
2016-05-09 | need to use shadow passwd function here, reminded by sthen | Ted Unangst | |
2016-04-05 | Move more fcntl(,F_GETFL,0) -> fcntl(,F_GETFL). | Kenneth R Westerback | |
No functional change. ok guenther@ | |||
2016-03-17 | Last parameter to execl[e]() functions *must* be cast to a pointer. | Kenneth R Westerback | |
Just NULL is not good practise as NULL is theoretically allowed to be an integer rather than a pointer. Use (char *)NULL consistently instead of scattering a few (char *)0 and (void *)NULL into the mix. Prompted by and probably ok deraadt@ millert@ kettenis@ Definitely ok mestre@ ratchov@ | |||
2016-03-16 | More "(<blah> *)0" -> NULL, avoiding any stdarg functions. | Kenneth R Westerback | |
Feedback millert@ kettenis@ | |||
2016-01-25 | (hidden) is more readable than (??????) and avoid trigraph | Gleydson Soares | |
suggested by & OK claudio@ OK daniel@ jsg@ initial review millert@ and tb@ thanks. | |||
2015-12-26 | Use pread/pwrite instead separate lseek+read/write for lastlog. | Philip Guenther | |
Cast to off_t before multiplication to avoid truncation on ILP32 ok kettenis@ mmcc@ | |||
2015-12-14 | s/begining/beginning/g | mmcc | |
2015-12-06 | Use __progname instead of manually handling argv[0]. | Tobias Stoeckmann | |
ok deraadt, mmcc, tedu | |||
2015-10-28 | pid removal; from jan stary | Jason McIntyre | |
2015-10-26 | stop saving a pidfile; ok jung zhuk | Theo de Raadt | |
2015-09-14 | Avoid .Ns right after .Pf, it's pointless. | Ingo Schwarze | |
In some cases, do additional cleanup in the immediate vicinity. | |||
2015-09-12 | Remove dead get_host_seed() function; Martin Natano | Miod Vallat | |
2015-08-20 | stdlib.h is in scope; do not cast malloc/calloc/realloc* | Theo de Raadt | |
2015-07-27 | use file system path (.Pa) semantic markup macros where appropriate. | Igor Sobrado | |
ok jmc@ | |||
2015-06-12 | Perform a copy with a memmove for potentially overlapping regions. | Mike Belopuhov | |
Reported and fixed by Sergey Ryazanov <ryazanov ! s ! a at gmail ! com>, thanks! | |||
2015-02-09 | clean up flags++ instances around getopt() | Theo de Raadt | |
ok florian | |||
2015-01-16 | Replace <sys/param.h> with <limits.h> and other less dirty headers where | Theo de Raadt | |
possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol) | |||
2015-01-15 | fully remove disabled mschap support, which does weird DES things. | Ted Unangst | |
(already won't build for some time since the removal of md4) ok naddy | |||
2014-12-10 | Fix a potential integer overflow in pppd options file parsing. | Jonathan Gray | |
From Paul Mackerras in 7658e8257183f062dc01f87969c140707c7e52cb This issue is CVE-2014-3158. | |||
2014-11-13 | remove networks(5) support; it wasn't even documented to exist; | Ingo Schwarze | |
"just go ahead" deraadt@ | |||
2014-10-08 | easy obvious use of reallocarray(); ok doug | Theo de Raadt | |
2014-05-17 | remove unused variable | Charles Longeau | |
ok tedu@ | |||
2014-03-21 | Disable MS-CHAPv1 (RFC 2433) support. Undocumented; Microsoft dropped | Christian Weisgerber | |
support in 2007 (Windows Vista); requires MD4, which will be removed. ok sthen@ | |||
2014-03-17 | the userland ppp(9) code goes awa. Having too much ppp choice in the | Theo de Raadt | |
tree results in one-true-ppp not coming into existance. This code is essentially un-audited and quite dangerous. ok claudio sthen | |||
2014-01-21 | use arc4random for chap generation; ok tedu | Theo de Raadt | |
2014-01-21 | include stdlib.h for drand48() | Jonathan Gray | |
2014-01-21 | obvious .Pa fixes; found with mandocdb(8) | Ingo Schwarze | |
2013-10-27 | If a constant string needs a name, use a static const array instead of a | Philip Guenther | |
pointer or non-const array, as that minimizes the symbols, maximizes the placement into read-only memory, and avoids warnings from gcc -Wformat=2 when they're used as format strings. ok deraadt@ | |||
2013-09-29 | purge compat junk related to drand48; ok guenther | Theo de Raadt | |
2013-07-16 | use .Mt for email addresses; from Jan Stary <hans at stare dot cz>; ok jmc@ | Ingo Schwarze | |
2013-04-21 | delete (uncompiled) hacked usleep function. | Ted Unangst | |
young minds should not be exposed to such code. | |||
2013-04-20 | casts of (time_t *) lead to bugs | Theo de Raadt | |
2013-04-15 | scripts should be run as root, but are not; add a BUGS entry to that | Jason McIntyre | |
effect, and comment out the text that says they are run as root isue pointed out by creamy | |||
2013-01-17 | some simple macro fixes; | Jason McIntyre | |
2012-08-29 | - document rfc 1994 | Jason McIntyre | |
- sections in conventional order - some minor tweaking | |||
2011-10-02 | Delete unused variables, from Michael W Bombardieri. | Nicholas Marriott | |
2011-07-25 | document syslog facility/level; from Stefan Unterweger | Jason McIntyre | |
ok dcoppa | |||
2011-04-30 | Remove some unused code, from Michael W Bombardieri. ok yasuoka | Nicholas Marriott | |