summaryrefslogtreecommitdiff
path: root/usr.sbin/rpki-client
AgeCommit message (Collapse)Author
2020-06-30Remove -f (force) option.job
The -f option existed for some initial debugging work. Thanks Weerd for review OK claudio@
2020-06-24Stop using rsync --delete when syncing up with the CA repos. InsteadClaudio Jeker
use the files referenced in the manifests to build up a list of files to keep and remove anything that is not in the list after doing the full computation. OK job@ benno@
2020-05-18Properly wait for exiting rsync processes. Since SIGCHILD is blockedClaudio Jeker
outside of ppoll() it is possible that multiple processes exited before waitpid is called. Because of this all childs need to be picked up and not only one. Fixes a hang seen more often now since there is a lot more repositories to sync. OK deraadt@ who came up with a very similar fix also OK job@ benno@
2020-05-14be little bit more verbose what went wrong in mkostempjob
2020-05-14rpki-client no longer passes -l to rsync since it does not make sense toClaudio Jeker
preserve symbolic links in the repositories. From Robert Scheck < robert at fedoraproject.org >
2020-05-06rpki-client is only interested in real files. Don't tell rsync toClaudio Jeker
preserve symbolic links. Instead just ignore them. OK benno@ deraadt@
2020-05-03Use strftime() rather than ctime() to generate timestamps nicer.Theo de Raadt
ok job, input claudio benno
2020-05-03Make it clear the date is in UTC.Theo de Raadt
ok job
2020-04-30Reword verbose log messages to clarify what's happeningjob
OK deraadt@
2020-04-30Place elapsed, user, and system time for processing in the comment headers.Theo de Raadt
ok job benno claudio
2020-04-29json should have headers in same orderTheo de Raadt
2020-04-28re-organize statistics printing code, to make it less verbose andTheo de Raadt
more readable.
2020-04-28a blank line in the header is prettierTheo de Raadt
2020-04-28Print statistics as comments at the top of the files which can takeTheo de Raadt
comments. ok claudio job
2020-04-23Always initialize cachedir and outputdir.Sebastian Benoit
ok job@
2020-04-21tweak previous;Jason McIntyre
2020-04-20Document the suggested interval in man pagejob
2020-04-20Strip the 'in bgpd' in the title of the rpki-client man page.Claudio Jeker
rpki-client is not only for bgpd (especially in the portable version). From Robert Scheck. OK job@ benno@
2020-04-18use correct path for the default cache dir in rpki-client(8). ok claudio@Stuart Henderson
2020-04-18improve whitespaces in usageTheo de Raadt
2020-04-16remove the libcrypto cleanup before exit. Most of the functions areClaudio Jeker
officially deprecated and even if not exit(3) will take care of freeing all that memory anyway. Non of the functions do any cleanup beyond simple memory deallocation. OK benno@ deraadt@
2020-04-16It is unclear why data is memcpy-ed into a char buf[2] that is used asClaudio Jeker
argument to ntohs(). Just memcpy to a uint16_t value and ntohs this value. Fixes possible alignment issues as reported by newer gcc compilers. OK beck@
2020-04-16Revert last commit, this file slipped in.Claudio Jeker
2020-04-16Replace deprecated ERR_remove_state(0) with ERR_remove_thread_state(NULL);Claudio Jeker
OK tb@
2020-04-11Avoid using libc SHA256File(), just perform the operation inline toTheo de Raadt
make things easier for -portable ok claudio
2020-04-11To help -portable, use a strrchr instead of basename, since we know whatTheo de Raadt
kinds of paths are coming in here. ok benno claudio
2020-04-11remove a __unused attribute, it's obvious and complicates things.Sebastian Benoit
ok claudio@
2020-04-02Use fopen() and BIO_new_fd() instead of BIO_new_file so that a possibleClaudio Jeker
open error can be better logged to the operator. The cryptowarnx function logs warnings is a less optimal way (mainly because of OpenSSL error stacks). OK benno@ deraadt@
2020-04-01Split the mft file and hash check from the mft parsing. This makes it easierClaudio Jeker
to check all files in a mft before failing and also the check is now done after the embedded cert was checked. This refactor was triggered because of a bug in mft_parse_econtent(). check_validity() altered rc but later failure code assumed that goto out is good enough to return an error (rc == -1) but since rc was 1 success was returned. This bug is now also fixed. Bug report and OK job@
2020-04-01Better warning message. Show the filename of the CRL instead of the constantClaudio Jeker
function name. Also AKI (authority key identifier) should be capitalized and use duplicated instead of dup. There was a case where this error got hit so better make it pretty.
2020-03-30Delay failure in mft parsing until all elements of FileAndHash have beenClaudio Jeker
checked. This way all corrupted or missing files should show up in a single run. This should help operators to get a better idea what and how much is broken. OK benno@
2020-03-30Check the hash and with it the presence of a file referenced in a MFT earlyClaudio Jeker
on. In case the file hash does not match or the file does not exist the full MFT is considered invalid and dropped. With this partial ROA updates based on a corrupt data set will produce less likely inconsistencies in the VRP output. With and OK job@
2020-03-27Use the correct math to calculate how many bytes are needed for b64_pton().Claudio Jeker
The size is first rounded up in case where the input string length is not a multiple of 4. Reported by kristaps@
2020-03-10Narrow the visibility of some functions and variables local to output.cJeremie Courreges-Anglas
Also make the outputs table const. Based on a suggestion from claudio@, ok deraadt@ claudio@
2020-03-09Ensure that we properly flush, close and rename temporary output filesJeremie Courreges-Anglas
Makes sure we don't feed an incomplete/garbage file to consumers. Input and ok claudio@ deraadt@
2020-03-09logx->warn, we want to know why operations on output files failedJeremie Courreges-Anglas
ok claudio@ deraadt@
2020-03-06Sync manpage to new default valuejob
Thanks jca@
2020-03-06Change default table name for BIRD to something that is more easily ↵job
identifable as user provided
2020-03-06generate 3 different outputs for BIRD:Sebastian Benoit
- bird v1 with IPv4 routes - bird v1 with IPv6 routes - bird v2 when using command line option -B. BIRD v2 output from Robert Scheck, robert AT fedoraproject DOT org time_t cast hint from jca@, and tested by job@ ok deraadt@ claudio@
2020-02-26ugly spaces offended meTheo de Raadt
2020-02-24Fix typojob
Thanks Robert Scheck & Kristaps Dzonsons
2020-02-11Simplify and unify wording for the -I sourceaddr option in various places.Theo de Raadt
This is somewhat related to the "-b bind_addr" option some programs have, which should get some cleanup also... input florian claudio jmc
2019-12-19wider list width to adjust for previous;Jason McIntyre
2019-12-19Fix output loop to not stop when the first unused output format isClaudio Jeker
encountered. Fixes rpki-client -j which did not produce any output before. Found by and OK job@
2019-12-19Align man file with realityjob
2019-12-16When rsync exits non zero because of network issues or because theClaudio Jeker
provided URI is bogous, rpki-client should try to work with the cache it has and not exit with an error. This should help when URI to localhost are published which happened at least 2 times already. Agreed by deraadt@ and benno@
2019-12-12correct output option list, from Alarig Le LayTheo de Raadt
2019-12-06add -d to usage();Jason McIntyre
2019-12-06Don't hardcode the cache directory for rpki-client. If started as rootClaudio Jeker
rpki-client will use the defaults for cache and output directory. If not started as root users need to provide both directories as arguments. While there switch from absolute path names to relative ones. For this the parser and rsync process do a chdir(2) to the cache directory on startup. OK benno@
2019-12-05No need to unveil(NULL, NULL) right before pledge "stdio rpath".Theo Buehler
From George Brown. ok benno