Age | Commit message (Collapse) | Author | |
---|---|---|---|
2015-01-22 | Clean up includes, while here fix a white space which lead to a false | Florian Obser | |
positive during grep'ing. OK reyk | |||
2015-01-19 | The kernel doesn't actually care what a sockaddr's sa_len is on input, | Philip Guenther | |
so don't waste code setting it improvment and ok florian@ | |||
2015-01-16 | Replace <sys/param.h> with <limits.h> and other less dirty headers where | Theo de Raadt | |
possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol) | |||
2014-12-08 | read(2) returns ssize_t, not size_t | Bret Lambert | |
ok florian@ | |||
2014-12-05 | enable warnings | Florian Obser | |
2014-12-05 | Bail out if the buffer is too small to contain the length of a | Florian Obser | |
parameter value. Found while investigating a dead store pointed out by llvm scan-build. | |||
2014-12-05 | dead stores; pointed out by llvm scan-build; no binary change | Florian Obser | |
2014-12-05 | pause shadows global; pointed out by gcc; no binary change | Florian Obser | |
2014-12-05 | mode is unused; pointed out by gcc; no binary change | Florian Obser | |
2014-12-05 | declare lerr and lerrx __dead; unconfuses llvm scan-build | Florian Obser | |
2014-09-19 | Instead of doing the fcntl(2) and ioctl(2) song and dance just tell | Florian Obser | |
socket(2) and accept4(2) that we want non-blocking-close-on-exec sockets. OK benno@ | |||
2014-08-28 | fix previous, and add a SEE ALSO section for httpd; | Jason McIntyre | |
2014-08-26 | remove nginx references | Robert Nagy | |
2014-07-13 | Use lerrx instead of errx since the logging subsystem is already initialized. | Claudio Jeker | |
OK florian@ | |||
2014-06-10 | Implement -u (user to drop privs to) and -p flag (path to chroot to). | Florian Obser | |
This allows to run slowcgi non-chrooted with -p /, requested by at least ratchov@ and henning@. Input by many, OK ratchov@ on a previous diff, "looks good" millert@, man page bits tweak and OK schwarze@ (all some time ago); OK henning@ | |||
2014-06-10 | Cleanup socket creation. | Florian Obser | |
Input ajacoutot some time ago; OK henning@ | |||
2014-04-16 | My previous attempt to chdir(2) to the directory containing the cgi | Florian Obser | |
script was not quite right. slowcgi would try to chdir("") with a SCRIPT_NAME of /foo.cgi; chdir("/") in that case. I'm not sure how one would configure nginx/slowcgi to get to that point though. OK benno@ | |||
2014-04-14 | Calculate the length of name and value for parameters the right way | Florian Obser | |
around for the 4 byte encoding. With this QUERY_STRING can be longer than 127 bytes. Found the hard way while playing with smokeping. OK benno@ | |||
2014-04-13 | httpd(8) did a chdir(2) to the directory containing the cgi script. As | Florian Obser | |
there might be scripts depending on this do the same in slowcgi(8). pointed out and OK ratchov@ | |||
2014-03-17 | jturner pointed out that if one wants to run cgi scripts outside | Florian Obser | |
/cgi-bin SCRIPT_NAME doesn't cut it. The spec says: "The SCRIPT_NAME variable MUST be set to a URL path". Use SCRIPT_FILENAME which can be an absolute filesystem path for these cases and fall back to using SCRIPT_NAME if SCRIPT_FILENAME is not present. Details how to handle this worked out by jturner and sthen. Based on an erlier diff by jturner. Tested by jturner OK jturner, sthen | |||
2014-01-20 | Better explanation what slowcgi(8) is for. | Florian Obser | |
Room for improvements pointed out by deraadt@ Tweaks/OK jmc@ OK deraadt@ | |||
2014-01-19 | Wording improvements from Patrik Lundin | Theo de Raadt | |
2014-01-19 | fix reaper loop that could run indefinitely | Damien Miller | |
log execve() failures to syslog (very useful for debugging SCRIPT_NAME problems) ok florian@ | |||
2013-12-12 | Make it clear that slowcgi(8) drops privileges to user www. | Florian Obser | |
Pointed out some time ago by blambert. OK jmc, blambert | |||
2013-10-31 | Initialize sun_len, pointed out by deraadt@. | Florian Obser | |
While there also check length of socket path, more relevant now since an alternative socket can be specified. OK benno@ | |||
2013-10-29 | Fix a potential file descriptor overlap in exec_cgi() by making sure | Florian Obser | |
that file descriptors zero to two are always open when starting slowcgi. pointed out, with and looks good to deraadt@ | |||
2013-10-23 | We need to loop around waitpid to catch all exited children as we are | Florian Obser | |
not guaranteed to get one signal per child. pointed out by deraadt OK benno, blambert | |||
2013-10-21 | Do not leak fds in fork(2) error path. | Florian Obser | |
pointed out by deraadt@ | |||
2013-10-21 | Check for EINTR, too. | Florian Obser | |
pointed out by deraadt@ | |||
2013-10-21 | No need for volatile here. | Florian Obser | |
pointed out by deraadt@ | |||
2013-10-20 | spelling, spacing, etc | Theo de Raadt | |
2013-10-20 | reserve file descriptors for incoming connections so we | Sebastian Benoit | |
will be able to actually run the cgi for them later on. mirrored on relayd. ok florian@ blambert@ | |||
2013-10-19 | Keep track of which fds were closed before and only close those still | Florian Obser | |
open. Otherwise if there are parallel requests and the timing is just right we were closing random fds from other connections. OK blambert | |||
2013-10-18 | Do not fiddle with the response queue directly but go through | Florian Obser | |
a new slowcgi_add_response() function. This ensures that we always do an event_add. OK blambert | |||
2013-10-18 | Logging to syslog works better with openlog(3). | Florian Obser | |
OK blambert | |||
2013-10-18 | Use a dedicated socketpair for stdin, makes the code more symetric and | Florian Obser | |
gets rid of shutdown(2) which might cause problems. OK blambert | |||
2013-10-18 | Calculate correct pointer for fcgi_{begin,end}_request_body. | Florian Obser | |
input / OK blambert | |||
2013-10-18 | Calculate correct pointer for end_request; while there initialize | Florian Obser | |
reserved to zero. OK blambert | |||
2013-10-18 | set FD_CLOEXEC | Florian Obser | |
OK blambert | |||
2013-09-19 | adjust the names to more accurately reflect the names of structs | Bret Lambert | |
and functions as they relate to the FastCGI protocol style(9)ize some function declarations while here ok florian@ | |||
2013-09-11 | Sprinkle some comments which clarify the protocol/process flow. | Bret Lambert | |
ok florian@ | |||
2013-09-06 | When dumping FastCGI protocol headers during debug, dump the | Bret Lambert | |
"request begin" and "request end" protocol entries in addition While here, make the "FastCGI request body" struct's name more precise (fcgi_end_request -> fcgi_end_request_body). okay florian@ | |||
2013-09-06 | Use the correct buffer size for memory allocation and reads. | Bret Lambert | |
okay florian@ | |||
2013-08-30 | If the CGI script died due to receipt of signal, pass that back | Bret Lambert | |
to the HTTP frontend as the "application return status". While here, add a pair of informative debugging statements. ok florian@ | |||
2013-08-26 | slowcgi grows an option to specify an alternate FastCGI socket | Bret Lambert | |
on which to listen. okay dcoppa@, henning@, florian@ manpage okay from jmc@ | |||
2013-08-23 | Give slowcgi a style(9) scrubbing. No functional change. | Bret Lambert | |
ok florian@ | |||
2013-06-02 | move bgplg and slowcgi sockets to /var/www/run | Florian Obser | |
input reyk@, guenther@ "move fast" deraadt@ OK naddy@ | |||
2013-05-23 | tweaks; ok florian | Jason McIntyre | |
2013-05-23 | off by one, from Henri Kemppainen <duclare-at-guu.fi>, thanks! | Florian Obser | |
2013-05-23 | Fix pasto where 'c' instead of 'clients' is checked for NULL and add missing | Jasper Lievisse Adriaanse | |
free for the fcgi_response. ok florian@ |