summaryrefslogtreecommitdiff
path: root/usr.sbin/snmpd
AgeCommit message (Collapse)Author
2016-01-25avoid a potential double freeJonathan Gray
ok blambert@
2015-12-24more e-mail -> emailmmcc
2015-12-07Add imsg "peerid" to debug messages (only within -DDEBUG).Reyk Floeter
2015-12-07Sync proc.c, use proc_composev()Reyk Floeter
2015-12-07sync with vmdReyk Floeter
2015-12-05EAGAIN handling for imsg_read. OK henning@ benno@Claudio Jeker
2015-12-05strings.h -> string.h to prevent an implicit declaration warning. Alsommcc
remove a handful of NULL-checks before free().
2015-11-23Use SOCK_NONBLOCK to replace socket_set_blockmode() and fcntl(..O_NONBLOCK).Reyk Floeter
(SOCK_CLOEXEC should also be added where it is appropriate, but this is OBnot done in this commit yet.) OK claudio@
2015-11-23Sync proc.c with ikedReyk Floeter
2015-11-22Update log.c: change fatal() and fatalx() into variadic functions,Reyk Floeter
include the process name, and replace all calls of fatal*(NULL) with fatal(__func__) for better debugging. OK benno@
2015-11-21Once again, fix the license text. After many years, we just cannotReyk Floeter
get rid of the "LOSS OF MIND" joke. Haha. We keep on removing it and it shows up again because it accidentally gets synced from somewhere else. bgpd and ospfd don't have it anymore, but their offsprings still carry it. If you see it, remove it, and, in the OpenBSD ISC case, use the original text from /usr/share/misc/license.template. All authors agree.
2015-11-21While here, fix two size format string warnings.Reyk Floeter
2015-11-21Move local logging functions to util.c and copy log.c from iked. NowReyk Floeter
a copy of the same log.c file is shared by relayd, httpd, iked, and snmpd. No functional changes.
2015-11-17Sensors marked as invalid should be excluded by snmpd(8) from the sensorsGerhard Roth
MIB just as sysctl(8) excludes them from the 'hw.sensors' tree. OK mikeb@, stehn@
2015-11-03When updating an interface, do not delete the kif_node but letGerhard Roth
fetchifs() update the existing node. Thus we don't lose the ARP entries. And while here, also handle RTM_DESYNC messages. ok mikeb@
2015-10-19Fix control_imsg_forward() by changing imsg_compose() toReyk Floeter
imsg_compose_event(). This was done by pyr@'s in relayd/control.c -r1.32 (2009/06/05, ok eric@) but somehow didn't slip into other daemons that imported control.c.
2015-10-19Print control socket client fd in debug message to differentiate betweenReyk Floeter
control connections. Helps to debug problems.
2015-10-17Tighten up snmpd's control socket: do not allow users to terminate theReyk Floeter
daemon by sending corrupted imsgs to snmpd. This is especially important for the optional world-writeable restricted socket that is used for AgentX. In particular, don't fatal() in the daemon when imsg size checks on control messages fail, do stricter validation of expected messages (even assert zero-length imsgs), don't continue and close the control socket on suspicious input, print a debug log message on error. OK gilles@ "the rationale behind it is quite clear"
2015-10-14sync with httpd - no functional change, just C99 typesReyk Floeter
2015-10-08add comment, suggested by reykStuart Henderson
2015-10-08Link the result of each mps_getbulkreq() to the end of the previous listStuart Henderson
and not the start of it. Fixes getbulk requests for multiple OIDs. From Gerhard Roth, ok blambert@
2015-10-08use correct return value for IP-MIB::ipForwarding, tweak/ok uebayasi@Stuart Henderson
2015-10-05Teach snmpd(8) about if_oqdrops.Masao Uebayashi
OK mpi@ dlg@
2015-10-02Adopt smtpd's imsg_read_nofd() to mitigate the risk of user-injectedReyk Floeter
file descriptor leakage from the optional world-writable _restricted_ control socket. OK gilles@ blambert@
2015-08-21Use reallocarray() instead of malloc() before strvisx().Reyk Floeter
Found by deraadt@ OK blambert@
2015-07-20properly encode IpAddress, Gauge32, and Counter32Bret Lambert
varbinds received from subagents ok reyk@
2015-07-19don't return failure for agentx messages with 0-length payloadsBret Lambert
allows snmpd to properly handle ping messages from agentx subagents ok reyk@
2015-07-18Fix malformed packets when returning 'no such object/entry' errorsBret Lambert
for snmp requests ok reyk@
2015-07-18Use better names as examples for snmpv3 users. As explained to blambert@Reyk Floeter
2015-07-18Better track connected routes similar to bgpd/ospfd.Claudio Jeker
According to sthen@ this makes snmpd report routes more correct
2015-06-11Use "compliant" header guards by avoiding the reserved '_' namespace.Reyk Floeter
Pointed out by Markus Elfring OK mikeb@ millert@
2015-06-10Export new pf "no-route" error counterMike Belopuhov
OK sthen, blambert for the SNMP part
2015-06-03Do not assume that asprintf() clears the pointer on failure, whichTodd C. Miller
is non-portable. Also add missing asprintf() return value checks. OK deraadt@ guenther@ doug@
2015-05-28Do not try to unlink the control socket in an unprivileged childFlorian Obser
process on shutdown. Found while working on tame(2). OK benno@
2015-02-12ber_printf_elements should return NULL if any of its parts fail.Martin Pelikan
Leave the error handling up to its callers. ok reyk
2015-02-10Remove a lie that "snmpd does not fully work yet". It works like a charm.Reyk Floeter
2015-02-08revert debug changes. reyk would like debug to remain a counter.Ted Unangst
2015-02-08flags should be flags, not counters. from martijn van durenTed Unangst
2015-02-08Use AI_ADDRCONFIG when resolv hosts on startup.Reyk Floeter
OK henning@
2015-02-06SIZE_MAX is standard, we should be using it in preference to theTodd C. Miller
obsolete SIZE_T_MAX. OK miod@ beck@
2015-01-22Replace some obvious '$OpenBSD' and '$OpenBSD:' typos with '$OpenBSD$'.Kenneth R Westerback
Pointed out by dickman@. ok sthen@ phessler@
2015-01-21Include <netinet/in.h> before <net/pfvar.h>. In a future change whenTheo de Raadt
ports is ready, <net/pfvar.h> will stop including a pile of balony.
2015-01-16first batch of cleanup to programs based upon the namespace cleanupsTheo de Raadt
in net/pfvar.h sys/proc.h sys/ucred.h arpa/nameser.h change to PATH_MAX, reduce use of MIN() and MAX(), HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc etc ok millert guenther, some review by doug
2014-12-16Replace setpgrp(0, getpid()) with setpgid(0, 0). OK deraadt@ tedu@Todd C. Miller
2014-11-20Don't allow embedded nul characters in strings.Jonathan Gray
Fixes a pfctl crash with an anchor name containing an embedded nul found with the afl fuzzer. pfctl parse.y patch from and ok deraadt@
2014-11-19file overlooked in previous snmpd commitBret Lambert
2014-11-19Support exporting relayd statistics via AgentX/snmpdBret Lambert
This should be equivalent to the statistics available via the various relaydctl show commands okay benno@ reyk@
2014-11-19add support for AgentX subagents in snmpdBret Lambert
snmp requests are now packaged into pseudo-continuations to allow for being dispatched to seperate processes; lightly tested for interoperability with NetSNMP, but doesn't implement the complete set of AgentX messages while here, clean up return types of mps_get* functions, and make smi_insert refuse to insert duplicate OIDs okay benno@ reyk@
2014-11-18Nuke more obvious #include duplications.Kenneth R Westerback
ok deraadt@ millert@ tedu@
2014-11-16Convert the logic in yyerror(). Instead of creating a temporaryAlexander Bluhm
format string, create a temporary message. OK doug@