summaryrefslogtreecommitdiff
path: root/usr.sbin/switchd
AgeCommit message (Collapse)Author
2019-07-23delete a stray blank from the usage() message; reported by Jesper WallinIngo Schwarze
2019-07-22switchd(8)'s main proc needs to open the following paths, and which can beRicardo Mestre
unveiled: / -> read, it will open config files from anywhere in the system /dev -> read/write, in order to open /dev/tap* and /dev/switch* hint and OK akoshibe@
2019-07-11to avoid confusion, use the IANA-registered port rather than the old made-upStuart Henderson
port in the manpage example. been sitting in my tree for ages and suggested by someone on one of the mailing lists but I forget the details.
2019-06-28When system calls indicate an error they return -1, not some arbitraryTheo de Raadt
value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
2019-05-05switchd(8) will sometimes not save a copy of a packet needing forwardingakoshibe
even when a switch(4) instance requires it to supply it. Cases where this can happen are: if the copy of the packet recieved from the switch is too short (source/destination pairs can't be recovered), is non-unicast, or when switchd has to fall back to flooding traffic. Factor out the check for short packets, stopping before forwarding decisions are made if the full packet is needed by the switch. Set the packet buffer early for cases where it is needed otherwise. Also replace a few bzero's with memset's. Diff based on one by guenther@ OK phessler@
2019-02-13(unsigned) means (unsigned int) which on ptrdiff_t or size_t or otherTheo de Raadt
larger types really is a range reduction... Almost any cast to (unsigned) is a bug. ok millert tb benno
2018-11-11Mention the default address (0.0.0.0) and port (6653) that switchd(8)akoshibe
uses. OK nayden@ kn@
2018-11-08Set sc_server.srv_tls value for "LISTEN ON STRING opttls".akoshibe
OK phessler@
2018-11-08Currently, switchd(8) defaults to listening on port 6633, which was theakoshibe
defacto port value used by OpenFlow. A decent chunk of OpenFlow controllers have switched over to the IANA standardized OpenFlow port, 6653. switchd(8) also randomizes its listen ports when one is not specified in switchd.conf(5).conf. Consolidate the #defines for port values, and set a default listen port. OK phessler@ claudio@, kn@ with separate switchd.conf(5) update
2018-11-01- odd condition/test in PF lexerAlexandr Nedvedicky
(and other lexers too) This commit rectifies earlier change: in the lex... even inside quotes, a \ followed by space or tab should expand to space or tab, and a \ followed by newline should be ignored (as a line continuation). compatible with the needs of hoststated (which has the most strict quoted string requirements), and ifstated (where one commonly does line continuations in strings). OK deraadt@, OK millert@
2018-10-30typo; from bryan stensonJason McIntyre
2018-09-10Mirror bluhm's fixes for proc.c daemons to dup /dev/null for child processesakoshibe
in switchd(8). OK henning@ bluhm@
2018-09-09Make switchd(8) ignore PACKET_INs generated from looped traffic. Currently,akoshibe
it responds to these messages with an invalid PACKET_OUT onto OFP*_PORT_ANY, resulting in the switch responding with an error, causing switchd to disconnect the switch. OK phessler@ claudio@
2018-09-07replace malloc()+strlcpy() with strndup() in cmdline_symset().miko
"looks good" gilles@ halex@
2018-08-05Remove cpath pledge(2) promise. We decided that not deleting the unix controlRicardo Mestre
sockets cause no harm and this way we close another attack surface by not allowing the daemon to create/delete any more files. OK akoshibe@ florian@
2018-07-11Do for most running out of memory err() what was done for most runningKenneth R Westerback
out of memory log_warn(). i.e. ("%s", __func__) instead of manual function names and redundant verbiage about which wrapper detected the out of memory condition. ok henning@
2018-07-09No need to mention which memory allocation entry point failed (malloc,Kenneth R Westerback
calloc or strdup), we just need to log that we ran out of memory in a particular function. Recommended by florian@ and deraadt@ ok benno@ henning@ tb@
2018-07-08Be consistent in warn() and log_warn() usage whenKenneth R Westerback
running out of memory. Next step, be correct *and* consistent. ok dennis@ tb@ benno@ schwarze@
2018-06-18remove the SECTIONS header, since a one line DESCRIPTION is a bit silly;Jason McIntyre
use a more general text for the sections, and avoid the catchup issue that was trying to document how many there were; ok benno rob
2018-06-11Fix an off-by-one line count when using include statements.denis
Thanks to otto@ for the initial diff. OK benno@
2017-08-2865535 is a valid port to listen on.Florian Obser
Off-by-one pointed out by and diff from Kris Katterjohn katterjohn AT gmail, thanks! chris@ pointed out that more than httpd(8) is effected. OK gilles@
2017-08-06packet.c and parse.y no longer require err.h. ok jca@ florian@rob
2017-07-06/tmp/cvsa9y4jmMarc Espie
2017-07-03no need to generate y.tab.h if nothing uses it, set YFLAGS to nothingMarc Espie
instead of CLEANFILES += y.tab.h okay millert@
2017-05-29sync proc.c changes from relayd/httpdSebastian Benoit
2017-03-21From a syslog perspective it does not make sense to log fatal andAlexander Bluhm
warn with the same severity. Switch log_warn() to LOG_ERR and keep fatal() at LOG_CRIT. OK reyk@ florian@
2017-03-08argument to the document description (Nd) macro should be lowercase.Igor Sobrado
ok jmc@
2017-01-17Nuke some whitespace that keeps poking me in the eye as I try toKenneth R Westerback
steal code.
2017-01-17Fix OXM parser for set-field messages. Found it the hardway whileRafael Zalamena
testing set-field configuration.
2017-01-16pasto; snmpd->switchd in sample "include" line. ok reyk@Stuart Henderson
2017-01-09Stop accessing verbose and debug variables from log.c directly.Reyk Floeter
This replaces log_verbose() and "extern int verbose" with the two functions log_setverbose() and log_getverbose(). Pointed out by benno@ OK krw@ eric@ gilles@ (OK gilles@ for the snmpd bits as well)
2017-01-09Replace hand-rolled for(;;) traversal of ctl_conns TAILQ withKenneth R Westerback
TAILQ_FOREACH(). No intentional functional change. ok reyk@
2017-01-08Sync log.c with the latest version from vmd/log.c that preserves errnoReyk Floeter
so it is safe calling log_* after an error without loosing the it.
2017-01-05Replace symset()'s hand-rolled for(;;) traversal of 'symhead' TAILQKenneth R Westerback
with more modern TAILQ_FOREACH(). This what symget() was already doing. Add paranoia '{}' around body of symget()'s TAILQ_FOREACH(). No intentional functional change. ok bluhm@ otto@
2016-12-22Learn remote switch flow tables properties to find out where to installRafael Zalamena
the default table-miss flow for OpenFlow 1.3.5. This is enough to make switchd(8) to work with switch(4) and HP 3800 switch out-of-the-box. ok reyk@
2016-12-02Implement the connection state machine for OpenFlow 1.0 and 1.3 to detectRafael Zalamena
invalid state transitions and invalid protocol version switching after the hello messages exchange. ok reyk@
2016-11-29article fix; from rob pierceJason McIntyre
2016-11-22Add "features request" support and reply validation.Rafael Zalamena
ok reyk@
2016-11-22Implement support for version negotiation using hello messages. ThisRafael Zalamena
also prevents connections from switching the version in the middle of the operation. tweak from and ok reyk@
2016-11-21Do more strict checks of OXM by looking at mask restrictions and addRafael Zalamena
missing OXM type (IP_PROTO). ok reyk@
2016-11-21Add truncation validation for packet-out and reuse the action validationRafael Zalamena
function instead of manually rolling the code again. ok reyk@
2016-11-21Fix jumbo regress test for ofp10.c and use htonl() with OFP_PKTOUT_NO_BUFFERRafael Zalamena
for consistency. ok reyk@
2016-11-21Implement better table features validation. With this we get free switchctlRafael Zalamena
display of table features. ok reyk@
2016-11-21Parse flow-status instructions in multipart replies, so we can see whatRafael Zalamena
instructions are used by the flow.
2016-11-18The special LOCAL and CONTROLLER ports are valid source ports thatReyk Floeter
should be learned by the cache. Fixes "addlocal" ports on switch(4). OK rzalamena@
2016-11-18Make switchd(8) use more strings just like tcpdump(8). While here removeRafael Zalamena
action field display from features request.
2016-11-18Define a group_id map and rename the defines accordingly.Reyk Floeter
Requested by rzalamena@
2016-11-18Define constmap in ofp_map.h to be shared along with ofp_map.cReyk Floeter
2016-11-18Remove leading _ from include guards as this violates the reserved space.Reyk Floeter
2016-11-18Add more maps to print. As discussed with rzalamena@Reyk Floeter
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-03 02:13:21 +0000