Age | Commit message (Collapse) | Author |
|
Access 8-byte nonce as unaligned data to avoid a crash on strict
alignment architectures. With IP and UDP, payload alignment is
guaranteed to 4-byte boundary only.
Reported and tested by Peter J. Philipp
OK deraadt@
|
|
OK deraadt@
|
|
reads ok to jmc@
good enough start for deraadt@
|
|
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.
Work done and verified by Ashton Fagg <ashton@fagg.id.au>
ok deraadt@ semarie@ claudio@
|
|
and fragment number components instead of printing the whole field in decimal.
ok sthen@ kn@ jca@
|
|
seems OK claudio@
|
|
EXTRACT_LE_32BITS() converts the type from little endian to host
endian. So we need the constants in host endianess. This fixes
regress/sys/net/wg.
OK deraadt@ sthen@
|
|
ok sthen@ millert@
|
|
rdr-to, nat-to, af-to rules. The kernel uses the information from
the packet description and fills it into the fields in the pflog
header. While doing this, it is trival to figure out whether the
packet has been rewritten.
OK sashan@
|
|
From Martin Vahlensieck.
|
|
instead of printf(3) to output printable characters.
Pointed by Martin Vahlensieck.
ok gnezdo@
|
|
This was unhooked from the build in a code sync in 1996 and didn't make
it into the upstream revision history.
Prompted by a diff from Neeraj Pal that showed that this file wasn't
compiled.
ok jca kn
|
|
In GTP a zero extended header length is invalid, deal with this instead
of looping forever.
Report and fix by Peter J. Philipp, tweaked by me, ok kn@
|
|
mostly modelled on the nsh md2 printing.
|
|
|
|
it's like vxlan, but different. the most interesting difference to
vxlan is that the protocol adds support for adding optional metadata
to packets (like nsh). this diff currently just skips that stuff
and just handles the payload. for now.
|
|
For DLT_NULL and DLT_LOOP interfaces, print-null.c passes
`caplen - NULL_HDRLEN' as length to default_print() which takes an unsigned
integer, hence if caplen is smaller than the header itself (four octets),
this difference wraps around.
Exit early in such cases and print the expected truncation marker "[|null]"
instead.
Feedback OK dlg
|
|
No object change.
|
|
|
|
from Matt Dunwoodie and Jason A. Donenfeld
|
|
|
|
|
|
from Matt Dunwoodie and Jason A. Donenfeld
|
|
from miod
|
|
ok dlg@
|
|
ok jasper@ mpi@
|
|
- print the stage name
- print additional information about the request for Setup packets
- GET_DESCRIPTOR requests are further decoded
tweaks and ok mpi@
|
|
length was smaller than the sizeof the usbpcap header. we'd end up passing a
negative value as the length to default_print().
found with afl-fuzz
ok mpi@
|
|
- add missing rcs id
- use 'goto trunc' as is common with other printers
ok mpi@
|
|
- fprintf(stdout, ...) -> printf()
- fputs(x, stdout) -> printf(); for consistency.
fputs is twice as fast on atom x5-Z8300@1.44GHz but Amdahl sees a pure printf
tcpdump only 2% slower than a pure fputs (for constant strings) tcpdump
to /dev/null across a 20MB/~170k packet pcap file.
ok dlg@ for fputs and ok tedu@ krw@ deraadt@ a2k19 for the rest
|
|
ok deraadt@
|
|
it's nicely backwards compatible, so we can use the same code for
both vxlan and vxlan-gpe.
|
|
they were based on draft-ietf-dhc-dhcpv6-14, which was not what
ended up in the dhcpv6 rfc(s). the current printing code is a lot
smaller and self contained.
ok deraadt@
|
|
it looks like this code was using draft-ietf-dhc-dhcpv6-14 from
1999. there were 27 drafts, and by the time it got to draft 23 and
the rfc it was significantly different. this code for draft 14
cannot handle actual dhcpv6 messages. im kind of surprised
(disappointed?) that noone noticed before. i only noticed cos the
code was segfaulting on sparc64, and when i tried to fix it the
resulting messages looked nothing like what stock tcpdump produced.
the main difference between the early drafts and what ended up in
the rfc is that the base dhcpv6 messages in early drafts were large
structure with a lot of fixed fields, while the rfc settled on a 4
byte header that contains a 1 byte message type and a 3 byte
transaction id. the rest of the messages are built from dhcp options
fields.
this cuts all the old handling out, and fixes the fault in the
options handling by using EXTRACT_16BITS to get at the code and
length fields instead of using ntohs. dhcpv6 explicitly states that
it does not align options, so this is necessary to avoid faults on
strict alignment archs anyway. no options are pretty printed at the
moment, you just get a numeric type, a length, and a hexdump of the
value. this is still better than the garbage that the draft parsing
produced.
if someone is interested in making this easier to read, it would
be a straightforward and well contained project to better handle
option printing.
ok deraadt@
|
|
that represent various header fields. One place where OXMs are used is in
the sef_field action, which contains one OXM representing the header field
to set, followed by padding to align the action in the OpenFlow message to
64 bits. Currently, we assume that a set_field action can contain multiple
OXMs and that they do not need to be padded.
This matches the way we handle OpenFlow messages that contain set_field
actions so that we follow the specs.
OK ori claudio
|
|
or a USB device. ok mpi
|
|
agreed by deraadt
|
|
|
|
this was lost when tcpdump learnt to look inside udpencap.
found by, and ok markus@
|
|
While here add a link to the documentation.
OK sthen@
|
|
|
|
|
|
|
|
help/ok deraadt
|
|
|
|
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.
|
|
this lets me configure a custom gre protocol on a dell s4810 or
s5048 and see what's inside it when it lands on an openbsd box.
ok lteo@
|
|
type I and II share their GRE protocol, but you tell them apart by
checking if a sequence number is used. type I does not use a sequence
number and contains a bare ethernet frame. type II contains a
sequence number and a shim header that is already handled by the
code.
tested with a Dell S5048F-ON and an encapsulated remote port mirror setup.
|
|
OK sthen@ deraadt@
|
|
print at least the key-id, and seq when -v is set, and the offset
and len when -vv is set.
ok sthen@ bluhm@
|