Age | Commit message (Collapse) | Author |
|
|
|
Reported by Peter J. Philipp
ok claudio
|
|
OK mpi@ mbuhl@
|
|
OK bluhm@
|
|
|
|
Kill default_print_unaligned() and adjust default_print() to also work
with unaligned buffers. There is no need for two functions doing the
same thing.
Pass the right length in nsh_print to default_print(). Fixes on place
that makes tcpdump crash.
Reported by Peter J. Philipp (pjp at delphinusdns dot org)
OK mbuhl@
|
|
any parts of his diff not taken are noted on tech
|
|
|
|
PMKIDs are present. Same error as found by Mikhail for ciphers and AKMs.
|
|
Also, pretty-print SAE (used by WPA3) if found in AKMs.
Errors introduced by me in CVS commit hgtOdzeJfB27Yyq0 / r1.40.
Patch by Mikhail
|
|
Technically a nop since the value of the initial constant is 0 anyway
but we should not rely on that.
|
|
Found by Stefan Butz.
ok dlg@
|
|
While there clean up some draft comments with their RFC number.
The detection for 4-byte ASPATH attributes is a bit sloppy but since
all resonable BGP versions use 4-byte ASnumbers now we default to them
unless we know it is a 2-byte encoding.
Kill it with fire. deraadt@ & job@ OK sthen@
|
|
With and OK claudio@
|
|
ok sthen@
|
|
from sys/param.h include lines, or remove the include lines entirely if
it this was the least requirement.
ok millert
|
|
All "infile" handling was moved into priv_exec() when tcpdump was
privilege separated. The options are scanned both in priv_exec()
and in main(), so the empty case needs to remain in the latter.
ok deraadt@
|
|
EAPOL turns out to be a little container for a bunch of other types
of packets, including EAP for use with vanilla 802.1X, a kind of
capability announcement thing, and MACsec Key Agreement.
it's not worth adding a separately file for such a small chunk of
functionality, and it seems specific to ethernet. parsers/printers
for the sub protocols can come later if needed.
ok deraadt@ visa@
|
|
|
|
|
|
|
|
|
|
|
|
this file had it's own verison of TCHECK, but also not. not the best.
|
|
|
|
|
|
|
|
variant that made a header file mistake.
ok jsg
|
|
Fix and add some error checking while there.
ok deraadt
|
|
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert
|
|
OK benno@
|
|
There's no such thing as a default community.
OK benno@
|
|
but was removed in RFC1902 (1996), where it was made equal to Gauge32.
There's no real harm in keeping it, since nothing else uses
[APPLICATION 7], but add a comment to help out any future lost soul that
might wander into this.
OK benno@
|
|
Access 8-byte nonce as unaligned data to avoid a crash on strict
alignment architectures. With IP and UDP, payload alignment is
guaranteed to 4-byte boundary only.
Reported and tested by Peter J. Philipp
OK deraadt@
|
|
OK deraadt@
|
|
reads ok to jmc@
good enough start for deraadt@
|
|
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.
Work done and verified by Ashton Fagg <ashton@fagg.id.au>
ok deraadt@ semarie@ claudio@
|
|
and fragment number components instead of printing the whole field in decimal.
ok sthen@ kn@ jca@
|
|
seems OK claudio@
|
|
EXTRACT_LE_32BITS() converts the type from little endian to host
endian. So we need the constants in host endianess. This fixes
regress/sys/net/wg.
OK deraadt@ sthen@
|
|
ok sthen@ millert@
|
|
rdr-to, nat-to, af-to rules. The kernel uses the information from
the packet description and fills it into the fields in the pflog
header. While doing this, it is trival to figure out whether the
packet has been rewritten.
OK sashan@
|
|
From Martin Vahlensieck.
|
|
instead of printf(3) to output printable characters.
Pointed by Martin Vahlensieck.
ok gnezdo@
|
|
This was unhooked from the build in a code sync in 1996 and didn't make
it into the upstream revision history.
Prompted by a diff from Neeraj Pal that showed that this file wasn't
compiled.
ok jca kn
|
|
In GTP a zero extended header length is invalid, deal with this instead
of looping forever.
Report and fix by Peter J. Philipp, tweaked by me, ok kn@
|
|
mostly modelled on the nsh md2 printing.
|
|
|
|
it's like vxlan, but different. the most interesting difference to
vxlan is that the protocol adds support for adding optional metadata
to packets (like nsh). this diff currently just skips that stuff
and just handles the payload. for now.
|
|
For DLT_NULL and DLT_LOOP interfaces, print-null.c passes
`caplen - NULL_HDRLEN' as length to default_print() which takes an unsigned
integer, hence if caplen is smaller than the header itself (four octets),
this difference wraps around.
Exit early in such cases and print the expected truncation marker "[|null]"
instead.
Feedback OK dlg
|