summaryrefslogtreecommitdiff
path: root/usr.sbin/tftpd
AgeCommit message (Collapse)Author
2022-10-09Drop fattr promise unless file creation is allowedKlemens Nanni
This is only required for the single fchmod(2) ensuring default permissions which only happens in the -c code path. OK millert
2022-10-05sort options list;Jason McIntyre
2022-10-04Switch default to read-only, add -w for write access (previous default)Klemens Nanni
Write access seems less often required these days and other ways to ensure effective read-only access are mere workarounds; worst case malicious users can fill up the server's disk by writing to existing files. diskless(8) only ever needs to read and running with "stdio rpath dns inet" by default is much safer for a network daemon without any authentication. Initially proposed as a new -R flag for read-only mode new default suggestion dlg deraadt "looks great" millert OK sthen dlg
2022-10-04Drop cpath promise unless file creation is allowedKlemens Nanni
OK millert
2021-10-24For open/openat, if the flags parameter does not contain O_CREAT, theTheo de Raadt
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past have passed mode_t (0, 044, 0644, or such), which might lead future people to copy this broken idiom, and perhaps even believe this parameter has some meaning or implication or application. Delete them all. This comes out of a conversation where tb@ noticed that a strange (but intentional) pledge behaviour is to always knock-out high-bits from mode_t on a number of system calls as a safety factor, and his bewilderment that this appeared to be happening against valid modes (at least visually), but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef. ok millert
2021-01-17Remove a __KAME__ block for extracting the scope_id from IPV6_PKTINFO.Claudio Jeker
struct in6_pktinfo includes the interface index in ipi6_ifindex but no struct sockaddr_in6. OK jca@
2020-12-17Log reason a request is NAK'ed, as well as any problems sending theKenneth R Westerback
NAK. Suggestion & ok dlg@
2020-01-09resend the current block if the other end acks the previous block again.David Gwynne
without this we just bump the timeout, which delays resending the block, which means the client gives up before they get the data. this seems to fix "timeouts" ive had a lot recently with uefi pxe stacks, and fetching firmware images on certain switches, all over busy networks.
2019-07-03snprintf/vsnprintf return < 0 on error, rather than -1.Theo de Raadt
2019-06-28When system calls indicate an error they return -1, not some arbitraryTheo de Raadt
value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
2019-03-04add the STANDARDS sectionDavid Gwynne
this lists the current RFCs, the obsoleted or updated RFCs are left commented out.
2019-03-03This has nothing to do with DARPA.Theo de Raadt
2018-01-26Handle the transfer size option when faking up /etc/random.seed.Christian Weisgerber
Without this, clients that queried the size would receive 0 as response. ok jca@
2017-11-07Add support for client-specific directories (named after the client address)Jeremie Courreges-Anglas
tftpd -i will look up the requested path the directory named after the client's IP address. For read requests, if the file is not found, there's a fall back to its root directory. From Jan Klemkow with input and tweaks from at least jmc@, bluhm@, deraadt@, sthen@, semarie@ and myself. ok bluhm@
2017-05-26Sync the severity of the syslog_* functions shared between identd, slowcgi,Florian Obser
tftp-proxy and tftpd to the severity used in log.c style loggers. This also fixes an issue where syslog_err and syslog_errx logged with different severities. Sure deraadt@
2017-04-16Different compilers and versions of compilers have different warnings.Jonathan Gray
Remove -Werror to give code a greater chance of building. ok deraadt@ florian@
2016-09-26Exit early from rdaemon() is the passed fd is invalid.Jeremie Courreges-Anglas
fd == -1 check suggested by deraadt@, ok florian@
2016-09-04Add format attribute to logger functions.Florian Obser
Add syslog_debug to keep in sync with others. Input & OK benno@
2016-03-31For consistency, omit the variable name in rdaemon() prototype.Jeremie Courreges-Anglas
2016-03-31Go in the background much later, to reduce possible silent failures.Jeremie Courreges-Anglas
rev. 1.34 moved the call to daemon() before the chroot, thus hiding errors if the target directory or _tftpd user don't exist. To go in the background later we need to preopen /dev/null. The code is put in a daemon(3) like function that could be used in other daemons. Lack of error reporting spotted by ajacoutot@, initial diff from dlg@. rdaemon() "concept" discussed with semarie@. ok ajacoutot@ dlg@
2015-12-14move daemon(3) call before chroot(2) in tftpd.Sebastien Marie
so daemon(3) will be able to redirect standard input, standard output and standard error to /dev/null. ok jca@
2015-12-11Remove NULL-checks before free().mmcc
2015-10-18Add "dns" to the pledges. Previously these worked because of "inet",Theo de Raadt
alas "dns" is now a mandatory statement if you want to do dns!
2015-10-10pledge "stdio rpath wpath cpath fattr inet" after chroot and suchTheo de Raadt
appears to be good enough for the main loop processing.
2015-10-06do not need ioctl.hTheo de Raadt
2015-08-20use SOCK_NONBLOCK when making a socket instead of ioctl FIONBIO.David Gwynne
for guenther@
2015-07-20tweak the /etc/random.seed interception so it provides a FILE* viaDavid Gwynne
fmemopen for the rest of the code to chew on, rather than having special casing for seed generation in the sending code. this also means our fake random.seed files will get proper netascii encoding by being read via the fgetc api instead of directly from a buffer. ok deraadt@ mcbride@
2015-07-18Have tftpd provide a block of random data when clients request the fileRyan Thomas McBride
/etc/random.seed. This allows netbooted systems to inject entropy early in the kernel start. pxeboot requests it already, so no configuration or change is needed on the client side. ok deraadt@ beck@
2015-01-16Replace <sys/param.h> with <limits.h> and other less dirty headers whereTheo de Raadt
possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)
2014-12-17the easier way to put a buffer on the stack is to put it on the stack,Ted Unangst
not with alloca(). found by dickman; ok kettenis
2014-11-25evbuffer_read and evbuffer_write are wrappers around read and write,David Gwynne
so you have to check their return values in the same way and handle errors the same way. returning 0 from evbuffer_read means the other end of the socket has gone away. we should try again on both evbuffer_read and evbuffer_write if we get EAGAIN or EINTR. ok millert@ bluhm@
2014-11-19move to stravis so doug@ will stop laughing at my misuse of strnvis.David Gwynne
ok doug@ millert@
2014-08-13Always call freeaddrinfo after getaddrinfo.Tobias Stoeckmann
ok dlg@
2014-08-13use errc instead of juggling errno values in tftpd_listen.David Gwynne
2014-08-13setsockopt sets errno on failure, so we can use err instead of errx whenDavid Gwynne
handling the error.
2014-04-21th_code is in network byte orderDavid Gwynne
2013-11-26unsigned char for ctypeTheo de Raadt
2013-11-12ensure there are prototypesTheo de Raadt
2013-08-13when handling puts from a client (ie, tftpd is writing a file toDavid Gwynne
disk), we maintain the client state after we've finished writing the file in case the client loses our ack of the last write. unfortunately we didnt close the file we'd just written when we knew it was finished, but only after we clean up the client state after that wait. because we use FILE stuff to write the file out, its likely some io flushed to disk until we finish that wait and close the file as part of cleaning up the client state. if something is coordinating a bunch of uploads and expects the file to be there after the client is happy its there, this can be "not good". this closes the file after we know its finished before proceeding to hang to handle lost acks to the client. found by and ok henning@
2013-06-01use the standardized names instead of S_IREAD and S_IWRITETheo de Raadt
ok guenther dtucker
2013-05-07getpwnam doesnt set errno on failure, so use errx, not err, to say itDavid Gwynne
failed.
2013-03-17i missed the bit of maxime villards diff that took the client_free out ofDavid Gwynne
oack on error. his fix is better, so this marges all of it in.
2013-03-15let oack use the full buffer space to build its packet, not just the sizeDavid Gwynne
negotiated for data tranfsers. this lets people negotiate 2 byte transfers with other options too if they want. im looking at you Maxime Villard.
2013-03-15"correct" the order of calloc arguments.David Gwynne
2013-03-15fix up some lwarn()s that should be lwarnx()sDavid Gwynne
2013-03-15fix a huge bug in tftpd.David Gwynne
there was a double free if an option ack failed. if oack fails, the client gets freed, then the oack caller tries to free the options which were just freed. found by Maxime Villard who provided a fix. unfortunately his fix still had a double free but it was pretty close. ok MALLOC_OPTIONS=S
2012-09-12Define empty CDIAGFLAGS for programs that use Werror.Christiano F. Haesbaert
Makes "make build" build with WARNINGS=Yes on amd64. ok espie
2012-07-13zap trailing whitespace; no binary changeGleydson Soares
ok dlg
2012-07-10fix the last outstanding functionality difference i could find betweenDavid Gwynne
libexec and usr.sbin tftpd. libexec waitied around after finishing a wrq in case our ack for the last write from a client got lost. this does the same dance, or an arguably better version of it compared to libexec tftpd.
2012-07-10libexec/tftpd handled the case where we'd get an ack for the previousDavid Gwynne
block by flushing the data on the socket and waiting for a retransmit by timeout to occur. my stuff (usr.sbin/tftpd) had XXXs and failure in those places. this diff fixes that. this should address the problems that sthen and jcs have been having (and which i was finally able to reproduce here). it also avoids reusing the clients buffer to both send and recv frames. we recv onto the stack now so retry always sends what we originally built for the peer. tested by and ok jcs@ sthen@
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-03 13:52:37 +0000