summaryrefslogtreecommitdiff
path: root/usr.sbin
AgeCommit message (Collapse)Author
2009-11-11patch a whole bunch of memory leaks, parfait only spotted one of themTheo de Raadt
ok miod jsg
2009-11-11Check if the receive buffer has any unused space before reading from socket inJacek Masiulaniec
buf_read (and in ssl_buf_read).
2009-11-11Plug two memory leaks in error pathes. Found by parfait. OK henning, jsgClaudio Jeker
2009-11-11Don't leak memory in error case.Jonathan Gray
Found by parfait.
2009-11-11don't leak memory in an error case.Jonathan Gray
found by parfait.
2009-11-11vsystem, system, unlink can mostly go through state, and do the ->clear partMarc Espie
as well.
2009-11-11remove extra warningsMarc Espie
2009-11-11remove redirector: if we want to run system AND log, just say soMarc Espie
2009-11-11fix setup_header in -vx !-r case: show we are adding a package, and don'tMarc Espie
show it twice.
2009-11-11don't use Warn if we've got a $state, get through errprint/errsay.Marc Espie
Also: reset lastdisplay on clear, and don't clear twice.
2009-11-11also get most STDERR messages through the same wayMarc Espie
2009-11-11progressmeter puts STDOUT in autoflush if -t, so that it can display to it ↵Marc Espie
instead of piping a lot of stuff to STDERR. Go through state->print for most messages, so they will NOT do weird things with the progressmeter. Use a ->say shortcut which does the same thing that perl 5.10 say does...
2009-11-11Fix crlf issue in buf_getln, similar to that in smtp_session.c r1.123.Jacek Masiulaniec
ok gilles@
2009-11-11improve buf_getln readability, no fuctional change.Jacek Masiulaniec
2009-11-11state->progress->print => $state->printMarc Espie
2009-11-11make things so that $state->print always work, with or without progressmeter,Marc Espie
even before we set it up.
2009-11-11remove forwarders, and provide a sensible API that says what's going onMarc Espie
(e.g., we're logging information for later).
2009-11-11bad idea to inherit from Error, compose object insteadMarc Espie
2009-11-11Ensure all replies are at least 4 chars long. If only 3 chars wereJacek Masiulaniec
received, append a space character. This enables other parts of the daemon to safely index into 4th character of the reply buffer without the risk of accessing one byte beyond NUL. ok gilles@
2009-11-11add missing headers needed by time()Charles Longeau
ok jacekm@
2009-11-11Fix an obvious use after free. Found by parfait. Reported and OK jsg@Claudio Jeker
2009-11-10Eliminate space after colon in "RCPT TO:" as required by RFC.Jacek Masiulaniec
2009-11-10In absence of the ehlo parameter, generate one based on locallyJacek Masiulaniec
bound IP address ("EHLO [1.2.3.4]") as dictated by RFC. ok gilles@
2009-11-10In relay case, avoid freeing garbage pointer by copying the required structJacek Masiulaniec
from the temporary imsg buffer. ok gilles@
2009-11-10zap old APIMarc Espie
2009-11-10kill more unused codeMarc Espie
2009-11-10remove dead code: as far as possible, we use onlyMarc Espie
match_locations/filter_locations since we deal with location. external API only uses spec->filter(), so we keep that one. We still need the generic match/filter adapters for Stem searches.
2009-11-10bad espie: use strict/warnings consistently, and fix two nits and twoMarc Espie
actual errors !
2009-11-10proposing details when we remove one single package is ridiculousMarc Espie
2009-11-10switch to match_locations, and so we can use choose_location, yippee!Marc Espie
2009-11-10tweak doc to only reference location objectsMarc Espie
2009-11-10zap matchMarc Espie
2009-11-10zap matchMarc Espie
2009-11-10kill one use of old-style matchMarc Espie
2009-11-10zap handle method, we finally no longer use it.Marc Espie
2009-11-10document what's going on...Marc Espie
2009-11-10move format expansion to the right place, from gilles@Jacek Masiulaniec
2009-11-10sync code with comment, from gilles@Jacek Masiulaniec
2009-11-10lint prompted cleanupTheo de Raadt
2009-11-10- add comments to explain the logic in the aliases expansion loopGilles Chehade
- more cosmethic changes to help readability - fix memory leaks - if deliverylist is empty, it means something went bad during expansion, reject recipient
2009-11-10pfff remove a comment i pasted to help me refactor code ;-)Gilles Chehade
2009-11-10more cleanup, let lka_resolve_path() request forward files and populateGilles Chehade
expandtree, this makes a lot of code clearer and removes quite a bit of complexity from various places.
2009-11-10Check for extension keywords on final multiline reply. Skip theJacek Masiulaniec
check for states other than CLIENT_EHLO. Verify response is not shorter than 3 chars. From Nils Frohberg ok gilles@
2009-11-10cosmethic changes, code reordering, no functionnal changeGilles Chehade
2009-11-10introduce lka_session_fail() which factors a small piece of code used inGilles Chehade
three places: set code to 530, send imsg to notify rejection, kill lkasession
2009-11-09now that we don't keep an expand_node in memory for each expansion result,Gilles Chehade
we don't need to calloc them as they won't be saved in the tree.
2009-11-09- add a reference count and flags to struct expand_nodeGilles Chehade
- during expansion, no longer create a new node for each result but try to lookup for an existing equivalent node and increment its reference count so that: a) we save on memory, b) we don't need to expand the same users again and again just because they keep appearing in expansion results. - while expanding, flag nodes as F_EXPAND_DONE so that we know which nodes we already processed - be smarter when expanding, if we have a clue that an iteration has not brought any new result (because no new nodes were added and all existing nodes have F_EXPAND_DONE), end expansion and proceed to delivery. - various small cleanups discussed with jacekm@ yesterday, rebuild aliases db, make clean
2009-11-09support the userpart+foobar@domainpart syntax which got wiped when i wroteGilles Chehade
the virtual domains support as it was in my way. this time, make it work as it should: userpart+foobar@domainpart becomes: path->user = userpart+foobar path->domain = domainpart path->pw_name = userpart discussed quickly with jacekm@
2009-11-09fix, need to keep =version for "no need to update" to occur...Marc Espie
2009-11-09document -F downgrades (note: for now, it's just the package name, we shouldMarc Espie
look further at the signature if we can actually compare things)