summaryrefslogtreecommitdiff
path: root/usr.sbin
AgeCommit message (Collapse)Author
2003-12-30correctly free after buf_add/_close errs.Henning Brauer
From: Patrick Latifi <pat@eyeo.org>
2003-12-30small logic error in session_open/_keepalive/_notification (yes, the same inHenning Brauer
all three) after buf_open failure. as this does not happen normally (except for in out of memory cases) it wasn't noticed.
2003-12-30missing free()s in error cases that (now) lead to program terminationHenning Brauer
From: Patrick Latifi <pat@eyeo.org>
2003-12-30we should not access ressources in a peer strcut 2 lines after weHenning Brauer
detected a closed connection which caused an fsm call which causes a deallocation of said ressources (that was long for "missing return")
2003-12-30missing free()s; From: Patrick Latifi <pat@eyeo.org>Henning Brauer
2003-12-30no empty default: cases in switch, gcc3 complaints via espie@Henning Brauer
2003-12-30typos from davidHenning Brauer
2003-12-29delintTheo de Raadt
2003-12-29spacingTheo de Raadt
2003-12-29convert from select() to poll() for main event loop; tested millert@, deraadt@Damien Miller
ok deraadt@
2003-12-29updates for openssl gen{d,r}sa:Jason McIntyre
- sort options - document "-out filename" for gendsa - typos and grammar
2003-12-29similar to pr 3614, but simplified diff. reduce 500-byte limit on identifiers;Theo de Raadt
originally from Alexander.Farber@t-online.de
2003-12-28Unbreak tree by using correct PFSYNC_ACT_UREQ #define.Ryan Thomas McBride
Also remove unused hlen variable.
2003-12-28Add a new PFSYNC_ACT_UREQ message type.Ryan Thomas McBride
A pfsync system which recieves a partial update for a state it cannot find can now request a full version of the update, and insert it. pfsync'd firewalls now converge more gracefully if one is missing some states (due to reset, lost insert packets, etc).
2003-12-28typo in commentHenning Brauer
From: Dries Schellekens <gwyllion@ace.ulyssis.org>
2003-12-28redo the imsg readers to use bigger buffers and less read(2)s. should increaseHenning Brauer
performance even further. gets rif od struct imsg_readbuf; rename peer_read_buf to read_buf as that is more appropriate now.
2003-12-27bgpid -> router-idHenning Brauer
local-addr -> local-address
2003-12-27Zero out the pf_state struct before filling it with data from theRyan Thomas McBride
pfsync_state struct.
2003-12-27styleHenning Brauer
2003-12-27consider the defualt route in kroute_match as well. it is a special case.Henning Brauer
2003-12-27fix thinkoHenning Brauer
2003-12-27move the fib couple/decouple to the config merge where it belongsHenning Brauer
2003-12-27"no fib-update" -> "fib-update [yes|no]"Henning Brauer
makes more sense this way
2003-12-27few fatal()s should really be fatalx()Henning Brauer
From: Dries Schellekens <gwyllion@ace.ulyssis.org>
2003-12-27keep a copy of the fd locally instead of passing it around all timeHenning Brauer
2003-12-27on reconfigure, check wether the "no fib-update" statement presence/absenceHenning Brauer
changed. if it is absent but was present before, call kroute_fib_couple if it is present but was absent before, call kroute_fib_decouple
2003-12-27provide kroute_fib_couple and _decouple, pumping all bgp routes from theHenning Brauer
internal view to the kernel routing table respectively removing them all from the kernel routing table kroute_shutdown is now a simple wrapper to kroute_fib_decouple
2003-12-27implement "no fib-update" much coolerHenning Brauer
2003-12-27do not print NULL nexthop (e.g. from a withdrawn route)Jakob Schlyter
2003-12-27when a static route is deleted on that a nexthop depends, we re-checkHenning Brauer
wether there's another (bigger-prefix) non-bgp route suitable to reach the prefix, and if that is the case change the references over to the new route. if not, we need to invalidate the nexthop. unfortunately, we cannot just call kroute_nexthop_insert (whoch does these checks) again, as it does too much. factor out the matching and reference adding code from kroute_nexthop_insert to a new kroute_nexthop_checkmatch(), and make the surrpounding stuff cope. the kroute parts of "static route addition/deletion affects nexthop-valifity" work now.
2003-12-26print nexthop when logging. ok henning@Jakob Schlyter
2003-12-26detect when a newly added kernel route (non-bgp of course) matches a nexthopHenning Brauer
that is flagged invalid yet and make it valid, notify RDE etc
2003-12-26factor out common codeHenning Brauer
2003-12-26"when you try to be very smart, something breaks horribly"Henning Brauer
zap aspath->state, which was a copy of aspath->nexthop->state, for a tiny little bit faster access. tho, it happened what had to happen, they ran out of sync. it's just not worth it. also add a missinf LIST_INIT.
2003-12-26set true_nexthop = exit_nexthop for directly connected nexthopsHenning Brauer
(in other words, make sure true_nexthop always has the right ip address for nexthops in state reachable)
2003-12-26erm, oups, well, put back rde_pid and io_pid assignments that got lostHenning Brauer
somehow...
2003-12-26when asking the kernel to add a route, send him the true nexthop and notHenning Brauer
the exit nexthop as the latter will only work if the two happen to be equal
2003-12-26move struct nexthop definition to rde.hHenning Brauer
2003-12-26fix logging in send_nexthop_updateHenning Brauer
2003-12-26add option 'log updates' to log updates. ok henning@Jakob Schlyter
2003-12-26yes, i have to admit that Wouter Clarie <rimshot@pandora.be> is right,Henning Brauer
The bgpd.conf program didn't first appear in OpenBSD 3.5, because, well, a config file is not a program.
2003-12-26FILES before SEE ALSO;Jason McIntyre
2003-12-26constify; ok henning@Jakob Schlyter
2003-12-26o the aspath->state checks should be != NEXTHOP_REACH, not == NEXTHOP_UNREACHHenning Brauer
o do not send a kroute_add request when the only aspath for the given | prefix has an nexthop whihc is not reachable (can be unreachable or | unchecked - that's why the check for == unreachable is not enough)
2003-12-2620 minutes debugging for a missinf return (0) at the end of a function,Henning Brauer
and gcc should have had complained... well.
2003-12-26let imsg_get and imsg_compose not fatal() but return errors upstream.Henning Brauer
make the callers cope.
2003-12-26when this project started and i added the fatal() function, I made it takeHenning Brauer
the error number as parameter instead of accessing errno, because in one place the error number was not in errno but fetched from a socket. now, of course it makes much more sense to just set errno to the error number just fecthed in this one place instead of having hundreds of fatal() calls all transfer the errno round and round and round... fix this, and also provide a fatalx, which does not care for errno and doesn't invoke strerror. oh, btw, in the place where we fetch the err # from the socket, we don't call fatal anymore anyway...
2003-12-26by making kroute_dispatch_msg() and kroute_nexthop_add() return int insteadHenning Brauer
of void they can now report errors upstream and do not need to panic any more. so do that and handle the errors in bgpd.c in the vein that we at least can clean up before exit. there are no direct fatal() call in kroute.c now any more, nor any in bgpd.c after forking.
2003-12-26report as many errors upstream as possible instead of fatal() so theyHenning Brauer
can be handled better
2003-12-26overhaul error handlingHenning Brauer
try to handle as much as possbile in a graceful way so taht we don't leave the kernel routing table full of our routes, for example.