summaryrefslogtreecommitdiff
path: root/usr.sbin
AgeCommit message (Collapse)Author
2009-11-14remove duplicate header includeCharles Longeau
ok gilles@
2009-11-14remove stupid extraneous return...Marc Espie
2009-11-14pull the eval {} code into an anonymous sub, so that we can choose to execMarc Espie
it without the eval (useful for backtraces when I want bug-reports, since eval {} will show you the backtrace of the eval, not of the function call)
2009-11-14fix. noticed by sthen@Marc Espie
2009-11-13add missing headers needed by time()Charles Longeau
ok jacekm@
2009-11-13Don't use [] in function arguments when dealing with arraysJonathan Gray
we don't know the size of, otherwise gcc >= 4 will error. ok markus@ deraadt@
2009-11-13Add logging of failed local deliveries.Jacek Masiulaniec
2009-11-13Log all 4yz and 5yz replies that we send to our clients.Jacek Masiulaniec
2009-11-13Include recipient address in "Recipient rejected" reply.Jacek Masiulaniec
2009-11-13Log FQDN and IP of the server we handed mail to. As a bonus, don't delayJacek Masiulaniec
logging of successful deliveries until all MXs were tried, plus add logging of 5yz replies. tested by todd@, "reads ok" gilles@
2009-11-12Add more paranoia in lsa_router_check(). There needs to be at least oneClaudio Jeker
router link in a type-1 LSA.
2009-11-12get_rtr_link and get_net_link are not supposed to fail and returningClaudio Jeker
NULL would be bad. So instead use a fatalx() in that impossible case. After a discussion with deraadt@ because of a parfait warning.
2009-11-12Make life easier for parfait. I corporation with deraadt. -mojMats O Jansson
2009-11-12for packets with unknown payloads (outside the range of our knowledge) simplyTheo de Raadt
treat them the same as truncated packets ok sthen
2009-11-12accessses 1 entry too far, found by parfait, ok jsg claudioTheo de Raadt
2009-11-12simpler: the whole set failsMarc Espie
2009-11-12Fix a memleak in parse_config(). Correct return code in few error paths.Jacek Masiulaniec
Fix two memleaks in purge_config(). First problem spotted by parfait, the other ones - by myself. "looks good" gilles@
2009-11-12Don't reuse a loop counter specifying the size of an array outsideJonathan Gray
of the loop to then access an offset in the array as this can lead to an off by one. found by parfait ok miod@
2009-11-12a sprinkle of knfTheo de Raadt
2009-11-12fix read-one-beyond-of-array errors; ok sthen jsgTheo de Raadt
2009-11-11memory leak found by parfaitTheo de Raadt
2009-11-11spacingTheo de Raadt
2009-11-11fix a few memory leaks, found by parfait; ok jsgTheo de Raadt
2009-11-11correctly order the range check and use the right limits, pointed out by parfaitTheo de Raadt
ok claudio millert
2009-11-11Fix previous. When configured to relay via IP address, MX lookup would failJacek Masiulaniec
(NXDOMAIN), leading to a bounce. Precede the MX lookup with an attempt to parse the relay as numeric string. "reads ok" gilles@
2009-11-11patch a whole bunch of memory leaks, parfait only spotted one of themTheo de Raadt
ok miod jsg
2009-11-11Check if the receive buffer has any unused space before reading from socket inJacek Masiulaniec
buf_read (and in ssl_buf_read).
2009-11-11Plug two memory leaks in error pathes. Found by parfait. OK henning, jsgClaudio Jeker
2009-11-11Don't leak memory in error case.Jonathan Gray
Found by parfait.
2009-11-11don't leak memory in an error case.Jonathan Gray
found by parfait.
2009-11-11vsystem, system, unlink can mostly go through state, and do the ->clear partMarc Espie
as well.
2009-11-11remove extra warningsMarc Espie
2009-11-11remove redirector: if we want to run system AND log, just say soMarc Espie
2009-11-11fix setup_header in -vx !-r case: show we are adding a package, and don'tMarc Espie
show it twice.
2009-11-11don't use Warn if we've got a $state, get through errprint/errsay.Marc Espie
Also: reset lastdisplay on clear, and don't clear twice.
2009-11-11also get most STDERR messages through the same wayMarc Espie
2009-11-11progressmeter puts STDOUT in autoflush if -t, so that it can display to it ↵Marc Espie
instead of piping a lot of stuff to STDERR. Go through state->print for most messages, so they will NOT do weird things with the progressmeter. Use a ->say shortcut which does the same thing that perl 5.10 say does...
2009-11-11Fix crlf issue in buf_getln, similar to that in smtp_session.c r1.123.Jacek Masiulaniec
ok gilles@
2009-11-11improve buf_getln readability, no fuctional change.Jacek Masiulaniec
2009-11-11state->progress->print => $state->printMarc Espie
2009-11-11make things so that $state->print always work, with or without progressmeter,Marc Espie
even before we set it up.
2009-11-11remove forwarders, and provide a sensible API that says what's going onMarc Espie
(e.g., we're logging information for later).
2009-11-11bad idea to inherit from Error, compose object insteadMarc Espie
2009-11-11Ensure all replies are at least 4 chars long. If only 3 chars wereJacek Masiulaniec
received, append a space character. This enables other parts of the daemon to safely index into 4th character of the reply buffer without the risk of accessing one byte beyond NUL. ok gilles@
2009-11-11add missing headers needed by time()Charles Longeau
ok jacekm@
2009-11-11Fix an obvious use after free. Found by parfait. Reported and OK jsg@Claudio Jeker
2009-11-10Eliminate space after colon in "RCPT TO:" as required by RFC.Jacek Masiulaniec
2009-11-10In absence of the ehlo parameter, generate one based on locallyJacek Masiulaniec
bound IP address ("EHLO [1.2.3.4]") as dictated by RFC. ok gilles@
2009-11-10In relay case, avoid freeing garbage pointer by copying the required structJacek Masiulaniec
from the temporary imsg buffer. ok gilles@
2009-11-10zap old APIMarc Espie