| Age | Commit message (Collapse) | Author |
|---|
|
(I completely mis-read the rfc last time 'round!)
This means:
o Better CCP/WARN Reset diagnostics.
o After we've sent a REQ and before we've received an ACK, we drop
incoming compressed data and send another REQ.
o Before sending an ACK, re-sequence all pending PRI_NORMAL data in
the modem queue so that pending packets won't get to the peer
*after* the ResetAck.
o Send ACKs with the `identifier' from the REQ frame.
o After we've received a correct ACK, duplicate ACKs are ok (and will
reset our history).
o Incorrect ACKs (not matching the last REQ) are moaned about and dropped.
Also,
o Calculate the correct FCS after compressing a packet. DEFLATE
*may* produce an mbuf with more than a single link in the chain,
but HdlcOutput didn't know how to calculate the FCS :-(
o Make `struct fsm'::reqid a u_char, not an int.
This fix will prevent us from sending id `255' 2,000,000,000 times
before wrapping to `0' for another 2,000,000,000 sends :-/
o Bump the version number a little (it should already have been at 1.6).
The end result: DEFLATE now works over an unreliable link layer.
I can txfr a 1.5Mb kernel over a (rather bad) null-modem
cable at an average of 21679 bytes per second using rcp.
Repeat after me: Don't test compression using a loopback ppp/tcp setup as
we never lose packets and therefore never have to reset!
|
|
as we've successfully opened the /dev side.
|
|
Eric Rungi <rungus@openface.org> -moj
|
|
Submitted by: Dave Bodenstab <imdave@mcs.net>
|
|
o Allow a forth argument in ppp.secret, specifying a new
label. This gives control over which section of
ppp.link{up,down} is used based on the authenticated user.
o Support random address ranges in ppp.secret (not just in ppp.conf).
o Add a AUTHENTICATING INCOMING CONNECTIONS section to the man page.
o Add a bit more about DEFLATE in the man page.
o Fix the incorrect "you must specify a password in interactive
mode" bit of the manual.
o Space things in the man page consistently.
o Be more precice about where you can use MYADDR, HISADDR and INTERFACE
in the "add" command documentation.
|
|
not in -auto mode isn't a good idea, and that the
add should be done in ppp.linkup instead.
Change "add 0 0 HISADDR" to "add default HISADDR". It's
more intuitive.
|
|
bigger than our MRU. Moan and drop the packet
instead.
|
|
Don't Call Term() for an algorithm that hasn't been Init()d.
|
|
|
|
interactive mode.
Use `netfd' in fcntl() and tc[gs]etattr() calls rather than
the hard coded descriptor 0.
Use _FILENO constants from unistd.h
This un-breaks things after my recent `close(0)' in interactive
mode.
Close STDIN_FILENO, and open _PATH_TTY O_RDONLY as `netfd'. This
has the effect of allowing `show route' to output more than about
a page of data (on FreeBSD, not OpenBSD....). I have no idea why,
except that it was a direct consequence of the tcsetattr() in
TtyCommandMode(). My previous fix (closing descriptor 0) `fixed'
this because all calls to tcsetattr() failed :-(
|
|
|
|
Suggested by: Christian Sandberg <christian@yes.no>
Eivind Eklund <perhaps@yes.no>
|
|
RTM_CHANGE if the RTM_ADD fails with an EEXIST.
Allow "delete! dst" (note the ``!'') to silently
fail if the RTM_DELETE fails with an ESRCH.
Also, make the ESRCH and EEXIST error conditions
more understandable to the casual observer.
|
|
after a select() interrupt is more than 1 second past what
should have been the end time.
We may just be running on an over-burdened machine.
|
|
`show timeout' output.
Remove ipIdleSecs variable - it's not used.
|
|
|
|
interrupted with a SIGALRM. In fact, select() sets the
passed time to zero, making the previous implementation
terminate always after 1/10th of a second !
Also, deal with someone changing the clock while we're
sleeping (and restart the whole sleep).
Dangers pointed out by: Theo de Raadt <deraadt@cvs.openbsd.org>
|
|
Complain to LogERROR if we have internal inconsistency (not LogDEBUG).
|
|
blocked in the output filter. If so, proceed with the
dial despite dropping the packet.
|
|
When CCP is originally negotiated, the only thing we can be
sure about is that we've started adding data to the inflate
dictionary either before or at the same time as the peer. This
is ok, 'cos DEFLATE is a `sliding window' compressor.
|
|
to just open it as uid 0 under OpenBSD.
|
|
Show the IP range (if specified) in "show ipcp".
Close unused descriptors 0 and 2 in interactive mode.
Pass (size_t *) rather than (int *) to sysctl().
|
|
Don't read(fd, buffer, 0) and think ppp has closed the
connection when `buffer' is full, instead, flush most of
buffer to the terminal and read() for a reasonable length.
This fixes "show route" when there's more than 2k of
routing output.
|
|
our chat script.
You can now even run chat(8) - see ppp.conf.sample.
|
|
Requested by: Eivind Eklund <perhaps@yes.no>
|
|
sizeof(var) -> sizeof var
sizeof type -> sizeof(type)
Suggested by: J Wunsch <j@uriah.heep.sax.de>
|
|
Lucky that sizeof cftypes < sizeof cftypes128
|
|
|
|
Suggested by: Philippe Charnier <charnier@lirmm.fr>
Theo de Raadt <deraadt@cvs.openbsd.org>
|
|
jumps, attempt as best as possible to gaurantee that jobs DO run, but only
run ONCE; patch by thompson@.tgsoft.com
|
|
|
|
|
|
Pointed out by: Theo de Raadt <deraadt@cvs.openbsd.org>
|
|
Submitted by: Derek Inksetter <derek@saidev.com>
|
|
|
|
Suggested by: Theo de Raadt <deraadt@cvs.openbsd.org>
|
|
===================================================================
RCS file: /home/ncvs/src/usr.sbin/ppp/systems.c,v
retrieving revision 1.31
diff -u -r1.31 systems.c
--- systems.c 1997/12/17 21:22:01 1.31
+++ systems.c 1997/12/21 01:35:58
@@ -288,6 +288,8 @@
if (issep(*cp)) {
n = strspn(cp, " \t");
cp += n;
+ if (*cp == '#')
+ continue;
len = strlen(cp);
if (!len)
continue;
|
|
|
|
|
|
|
|
|
|
-auto mode. This makes ppp correctly exit if you kick it
off twice in auto mode with the same label (read: interface).
|
|
without looking for it in our IP list (and if found, trying
to ifconfig it!).
|
|
strcpy(a, b); /* a and b are the same size */
with
strncpy(a, b, sizeof(a));
a[sizeof(a)-1] = '\0';
Making the code `correct at a glance'.
Suggested by: Theo de Raadt <deraadt@cvs.openbsd.org>
|
|
"No reply" sounds like the message didn't get through (for
example when you `pppctl xxxx quit all'.
|
|
"passwd xxxx".
|
|
Pointed out by: Theo de Raadt <deraadt@cvs.openbsd.org>
|
|
Pointed out by: Theo de Raadt <deraadt@cvs.openbsd.org>
|
|
Disallow connections from port numbers <1024 as low port numbers
can only really mean trouble (ftp bounces etc.).
Discussed at length with: Theo de Raadt <deraadt@cvs.openbsd.org>
|
|
|
