Age | Commit message (Collapse) | Author |
|
appropriately. Otherwise imsg construction can silently fail, resulting in
non-obvious problems.
Found the hard way by Theodore Wynnychenko.
ok doug@ florian@
|
|
I fscked up the testing, sorry!
Found the hard way by jsg@
|
|
an AP in beacons in the run-up to a channel switch, either for radar avoidance,
or for frequency management). ok stsp@
We don't support these in net80211 yet (as pointed out by stsp a few days ago)
but it's useful to at least have a way to debug why your connection is getting
knocked down!
|
|
Pointed out by Regis Leroy (regis.leroy AT makina-corpus DOT com),
thanks!
Tweak and OK reyk@
|
|
|
|
|
|
|
|
the info is signed and checked.
after remarks from tedu@...
|
|
on them.
|
|
|
|
reference.
ok sthen@ jca@ deraadt@
|
|
ok millert@
|
|
in the FIB.
ok claudio@
|
|
There's no need to protect the 127/8 network on ldpd since this network
is filtered before being sent to lde.
If we receive a label mapping for this network, it won't be installed
because lde has no nexthop for it, and thus the code will always fall
into the LMp.13 case of the RFC "Receive Label Mapping" algorithm:
the mapping will be recorded but not used.
ok claudio@
|
|
The LIB is a table where the router keeps all known MPLS labels. So,
we should loop over all the received label mappings from all neighbors
to show the full LIB.
The lde_nbr_is_nexthop() function was introduced to verify if a lib
entry is supposed to be installed in the fib (according to the fib entry's
nexthop and the addresses advertised by the lib entry's nexthop). This is
better than keeping track of lib<->fib entries with pointers and back
pointers because it keeps the lib/fib structures independent of each
other, which in turn makes the code less prone to bugs.
OK claudio@
|
|
The adjacency holdtime is set in recv_hello().
OK claudio@
|
|
|
|
configuration for multiple listen statements in a server block.
Otherwise httpd will crash when a listen statement with tls is followed
by a listen statement without tls.
Problem reported by Kent Fritz on misc.
ok jsing@ looks good deraadt@
|
|
Found by naddy@
|
|
configuration file. Also make sure that we fully parsed it.
If not, avoid to start a half-baked syslogd.
with input by and ok bluhm@
|
|
was an extra line without benefit. Remove the new-line in printf
to make parsing easier.
OK lteo@ mikeb@
|
|
extractible/tied files.
Could have been mentioned earlier, the fix is obvious.
|
|
|
|
Add some explicit error messages while here.
Prefer cat over cp/mv to edit rc.conf.local; this prevents creating
rc.conf.local with mode 0600.
|
|
Original fix from Romuald Delavergne. ok henning@
|
|
to readd the write event if there's still items on the list.
this lets things that do a lot of requests in parallel (like npm)
work betterer through a squid proxy using ident for auth.
ok jmatthew@
|
|
too much problems with the recent changes to net/libnet (in combination
with security/dsniff); the PKGSPEC changes. Some more suspicious
pudate problems mentioned by landry@.
ok sthen@
|
|
|
|
|
|
7230 and RFC 3875.
sthen@ suggested to add a comment to explain where the list of
characters is coming from.
Found the hard way and initial diff from Tim van der Molen (tbvdm at
xs4all), thanks! Some more allowed characters added by me.
OK sthen@
|
|
ignore it directly. no functional change. Rafael Neves rafaelneves at gmail
|
|
ok benno@
|
|
|
|
In the name of simplicity, remove the interface FSM that was inherited
from ospfd. In ldpd interfaces are just up or down, so keeping a
FSM for that is an overkill. Now instead of calling if_fsm(), just
call if_update() whenever a relevant event occurs (status change,
address addition/removal).
Additional notes:
1 - s/if_act_/if_/
2 - Remove the IMSG_IFUP and IMSG_IFDOWN events. Now whenever an
interface changes its state a IMSG_IFSTATUS event will be generated
with the new status.
kroute.c ldpd.h ldpe.c ldpe.h CVS:
----------------------------------------------------------------------
|
|
after an address removal in the system.
|
|
for whatever reason.
If one interface is disabled, the holdtimer of the attached adjacencies
will eventually timeout after a few seconds. But there's no need
to wait when we know that the interface is disabled. In these cases,
remove the attached adjacencies to speedup the convergence process.
|
|
Although RFC 5036 is not explicit about this, LDP should not assign
labels for BGP routes. Doing that would be very resource consuming
in some scenarios and unnecessary. The goal is generally only to
establish LSPs among all PEs in the AS since LDP is not used as an
end in itself but as a means to implement advanced solutions like
MPLS L2/L3 VPNs. Some implementations (e.g. JunOS) go further and
only assign labels for /32 loopback routes advertised in the IGP.
If Inter-AS LSPs are necessary, BGP itself should be used for
distributing IPv4 labeled routes (e.g. option C. of section 10 in
RFC 4364).
|
|
|
|
|
|
Missing initialization, as hinted by lwres_conf_clear(). Not present
in recent bind versions (the code has changed since).
This fixes an erratic behaviour when no (valid) nameserver is configured
in resolv.conf (dig / nslookup send requests to 127.0.0.1:48830).
Problem reported by Pawel S. Veselov who also provided an alternative diff.
ok crickets@
|
|
While here unconditionally free clt and move declaration of
server_inflight_dec() into server.c
Found while investigating if (foo != NULL) free(foo) patterns pointed
out by Markus Elfring.
OK reyk
|
|
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time. This makes the
tree safe for /usr/include/tzfile.h removal. The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree. Actual removal of tzfile.h is pending
a ports build. Based on a diff from deraadt@
|
|
|
|
ok deraadt@
|
|
|
|
of the RDE to free the filterlists. Also refactor common code to merge
filterlists into its own function. Makes the code look nicer.
|
|
into a own flag field since these can't be modified via a config reload.
OK henning@ benno@ before lock
|
|
from the parsing function to the merge_config function where it belongs.
OK henning@ benno@ before lock
|
|
neighbors that are part of that interface or we open us up to use after
free situations like the one found by sthen@.
Diff makes sense sthen@
|
|
|