summaryrefslogtreecommitdiff
path: root/usr.sbin
AgeCommit message (Collapse)Author
2018-08-06replace the current log optionsSebastian Benoit
log updates|all with log state changes log host checks log connection [errors] The first two control the logging of host check results: either changes in host state only or all checks. The third option controls logging of connections in relay mode: Either log all connections, or only errors. Additionaly, errors will be logged with LOG_WARN and good connections will be logged with LOG_INFO, so they can be differentiated in syslog. ok and feedback from claudio@
2018-08-06Change manpage example for reserved words since the macro used is to replaceRicardo Mestre
a password and that way it would log it when the daemon is ran in verbose mode. Hint and OK claudio@
2018-08-06Validate the prefix sent in a network delete call before trying to deleteClaudio Jeker
it. We should not trust this input too much as found by Pierre Emeriaud. OK benno@
2018-08-06Pass the stale timestamp to path_remove_stale() removes a asp->peer dereferenceClaudio Jeker
2018-08-06Replace two asp->peer with prefix_peer(p) which is the same.Claudio Jeker
2018-08-06Assign peer1 and peer2 early on and use them everywhere instead of aspX->peer.Claudio Jeker
2018-08-05Since -s argument is no longer checked, during reexec, the argv size then mustRicardo Mestre
be shortened by 1. OK florian@
2018-08-05Remove cpath pledge(2) promise. We decided that not deleting the unix controlRicardo Mestre
sockets cause no harm and this way we close another attack surface by not allowing the daemon to create/delete any more files. While here also scramble pledge promises to their canonical form. OK florian@
2018-08-05Remove now unused header which I forgot to commit on previous.Ricardo Mestre
2018-08-05Remove cpath pledge(2) promise. We decided that not deleting the unix controlRicardo Mestre
sockets cause no harm and this way we close another attack surface by not allowing the daemon to create/delete any more files. OK florian@
2018-08-05Remove cpath pledge(2) promise. We decided that not deleting the unix controlRicardo Mestre
sockets cause no harm and this way we close another attack surface by not allowing the daemon to create/delete any more files. OK akoshibe@ florian@
2018-08-05Revert back previous and remove cpath pledge(2) promise entirely. We decidedRicardo Mestre
that not deleting the unix control sockets cause no harm and this way we close another attack surface by not allowing the daemon to create/delete any more files. tweak and OK florian@
2018-08-04Revert back previous commit, we have decided that socket files don't cause anyRicardo Mestre
harm if not deleted after the daemon is shutdown and at the same time we also tackle another attack surface by not allowing the program to create/delete any more files (by removing "cpath" promise from pledge(2)). Discussion initiated by a question from deraadt@ OK florian@
2018-08-04Leave the control socket behind on shutdown. It doesn't hurt anyone.Florian Obser
On the other hand it is much more powerful to get rid of cpath; rad is no longer allowed to change anything on the filesystem. Triggered by mestre@'s work to fix unlinking in other daemons and a question from deraadt@ OK mestre
2018-08-04I can find no reason why portmap needs rpath after initialization.Theo de Raadt
2018-08-03advertise slaacd.8;Jason McIntyre
2018-08-03sort; ok florianJason McIntyre
2018-08-03return is not a function and if (x) -> if (x != NULL)Sebastian Benoit
From Ross L Richardson, thanks ok millert@
2018-08-03fix error messages from earlier syntax changeSebastian Benoit
From Ross L Richardson ok millert@
2018-08-03correct an error message, from Ross L RichardsonSebastian Benoit
ok millert@
2018-08-03document the default in the abscence of a certificate authority.Sebastian Benoit
From Ross L Richardson
2018-08-03Document that domain certificate is optional.Sebastian Benoit
From Ross L Richardson
2018-08-03Move nexthop and nexthop flags from the rde_aspath to struct prefix.Claudio Jeker
struct prefix will be slowly becomming the hub of the rib. OK phessler@ job@
2018-08-03We can only unveil if the prefix is a directory (the input paths, and theTheo de Raadt
output directory). If prefix isn't a directory, that would require enumerating all prefix<sig>.<id> filenames and unveiling all of them which isn't reasonable... for the file case can we identify whether it starts start with '/' or not, and unveil '/' or '.' for "w"?
2018-08-03unveil _PATH_DEVDB for devname(). All other filenames are openedTheo de Raadt
before unveil/pledge.
2018-08-03Reshuffle the way bgpd does the softreload after filter changes.Claudio Jeker
Walk each rib at most once and push it from there to all RIBs or peers that need the update. Makes the logic more streight and so easier to run in background. Tested by and OK phessler@
2018-08-03Move dns settings to global options so that they don't need to beFlorian Obser
repeated in every interface block - they can still be overwritten on a per interface basis. Pointed out by, tweaks & OK sthen
2018-08-03actually heed localbase when looking for groffMarc Espie
2018-08-03reorg groff runner so that failures are handled betterMarc Espie
do the logic for manpage formatting better, so that we can't miss things simplify filenames, fullname always has a slash
2018-08-03- exit in case of exec error. Prevents code from continuing badlyMarc Espie
- display error message on STDERR... better - don't extract the code twice
2018-08-03Place a limit on the number of elements in a ber sequence/set. This preventsrob
possible stack overflow due to recursion in ber_free_elements(). ok claudio@
2018-08-02Split out the rule skipping logic into own function and by doing so ensureClaudio Jeker
that both filter lists are treated the same way. This fixes an inconsistency with ibgp and ebgp filters as used in the example config. OK benno@ sthen@
2018-08-02According to code (and testing), each is optional but at leastSebastian Benoit
one must be present. From Ross L Richardson, thanks ok sthen@
2018-08-02It's an "X.509 certificate" rather than a "TLS certificate".Sebastian Benoit
As pointed out by sthen@, TLS isn't the only possible use. From Ross L Richardson ok shten@
2018-08-02its a X.509 certificate, consistency with acme-client.conf.5Sebastian Benoit
From Ross L Richardson ok sthen@
2018-08-02ntpd(8) has logic in place to delete its control socket on shutdown, but itRicardo Mestre
currently doesn't call the function control_cleanup to do so. The solution is to simply call that function just before the program quits. "sure" henning@
2018-08-02Make a few more rde specific functions static.Claudio Jeker
2018-08-02Make free_prefixsets() accept a NULL pointer. Makes it behave more likeClaudio Jeker
all other free functions bgpd has.
2018-08-02This brings the network code more in line with what regular updateClaudio Jeker
processing does. It adds the prefix to Adj-RIB-In and if "log update" is set it will also log the addition and removal of a prefix. OK benno@
2018-08-02Actually order the promises in their canonical form, missed that in myRicardo Mestre
previous commit. heads up and OK tb@
2018-08-02Currently when eigrpd(8) shuts down then its unix control socket is beingRicardo Mestre
unlink(2)ed from eigrpe engine process, the problem is that this proc is chrooted and therefore the socket will never be deleted. In order to solve it we need to bring control_cleanup() function, which calls unlink(2), into the main proc which is not chrooted. This is the way it's already done for several other daemons we have in our base. Additionally we also need to move the "cpath" pledge(2) promise from the child process to the main process in order for the latter to be allowed to delete the socket and while here shuffle the promises into their canonical form. OK florian@ and benno@
2018-08-01Fix segmentation fault on radiusd(8) when exiting.Ricardo Mestre
If one of the configured modules doesn't have a secret setup then module->secret == NULL which would call strlen(NULL), within freezero(3), and that shouldn't happen, but in this case since the call is done it segfaults and the daemon is not properly shutdown. cluebat stick provided by semarie@, OK tb@ and deraadt@
2018-08-01Clarify that we chroot to the users home directory if -u is provided.Florian Obser
Pointed out by Andrew Daugherity (andrew.daugherity AT gmail), thanks! Tweaks and OK jmc
2018-07-31Relocate some public functions above the internal functions comment.rob
ok claudio@
2018-07-31Reshuffle order in struct rde_peer a bit. No functional change.Claudio Jeker
2018-07-31Fix some debugging output now that ber type and encoding are unsigned int.rob
ok claudio@
2018-07-31Make ber type and encoding a unsigned int instead of unsigned long.Claudio Jeker
This way the size is the same on all archs and 32bit should be good enough. OK rob@
2018-07-31There is no longer the need to be careful in rde_softreconfig_in() whenClaudio Jeker
traversing the prefix list. Since a while Adj-RIB-In is fully independent and so updating the local RIB does not modify that list. OK benno@
2018-07-30cleanup initialization of chngdir. inspired by Ross L Richardson.Sebastian Benoit
ok tb@
2018-07-30replace exit() with return(), from Ross L Richardson.Sebastian Benoit
ok tb@ (previous 3 commits to main.c as well)