summaryrefslogtreecommitdiff
path: root/usr.sbin
AgeCommit message (Collapse)Author
2010-02-22Correctly encode FEC prefixes. This makes my test setup much happyer.Claudio Jeker
OK michele
2010-02-22Treat multiple Router-LSAs originated by the same router as anStefan Sperling
aggregate, as mandated by RFC5340. OK claudio@
2010-02-21Kill double declaration of control_imsg_relay().Michele Marchetto
From Christiano F. Haesbaert. ok claudio@
2010-02-21Check bufferevent_new() return value. If it is NULL print an error messageMichele Marchetto
and return. From Martin Hedenfalk. ok claudio@
2010-02-20Make send_* functions return void (and not int) as they can just succeedMichele Marchetto
or fatal(). ok claudio@
2010-02-20Remove unneeded abstraction in neighbor fsm.Michele Marchetto
ok claudio@
2010-02-20Add line breaks to the source to render an .RS display that got skipped;Ingo Schwarze
found by and unbreaking the build with mandoc(1). I will also send this patch upstream. ok jmc@
2010-02-19Oups, unbreak build.Claudio Jeker
2010-02-19Cleanup a bit, remove unneeded dummy neighbor and initialize queue headsClaudio Jeker
in the correct place. Queue mappings ordered by inserting at tail. OK michele
2010-02-19If a neighbor goes down we need to cleanup the LIB from all FEC that pointClaudio Jeker
via that neighbor. Fixes a use after free and an additional NULL dereference in a log_debug is fixed as well. OK michele
2010-02-19Do not double free a knode when kroute_insert() fails. kroute_insert()Claudio Jeker
will free the node if something fails. OK michele
2010-02-19oops, remove dead code.David Gwynne
2010-02-19implement ospfctl fib reload.David Gwynne
this tells the daemon to resync the kernels list of interfaces and routes with the daemons list. this is very useful if the routing socket overflows and you want to sync things up again. lots and lots of help from claudio@ ok claudio@
2010-02-18Fix a leak that could happen with multiple requests on the oneJonathan Gray
connection and while here create a seperate function for handling cleaning up after a request; with suggestions from reyk and claudio. ok claudio@
2010-02-18Make the output of printconf() look like a real config file.Claudio Jeker
OK michele@
2010-02-18Set the correct defaults for label advertisement, retention and distribution.Michele Marchetto
ok claudio@
2010-02-18Do an event_del before event_set/event_add in case we double addJonathan Gray
something here as well. ok claudio@ phessler@
2010-02-18Our groff does not handle all cases of nested displays properly, soIngo Schwarze
resolve the contradiction in the manual whether it's allowed or not in favour of "not allowed" for now, shelving my diff to support nested displays in mandoc(1) for later consideration. Found by and unbreaking the build with mandoc(1). Feedback and OK jmc@
2010-02-18Each .Bk must be closed by .Ek.Ingo Schwarze
Found by and unbreaking the build with mandoc(1). OK jmc@
2010-02-18We need to set SO_REUSEADDR before doing the bind() of the tcp socket.Claudio Jeker
It does not help to set SO_REUSEPORT after doing the bind. Fixes failures to start ldpd because of TIME_WAIT sessions. OK michele
2010-02-18Remove some debug messages that are too verbose and no longer needed.Claudio Jeker
OK michele@
2010-02-18Close a fd leak when opening the tcp connection to the neighbor.Claudio Jeker
OK michele
2010-02-17in map_stdio_get() use strdup on the right buffer, not on a pointer thatGilles Chehade
will be NULL 99% of the times... fixes segv in path that's not enabled yet
2010-02-17erf, previous fix to lka crash was still using the wrong define ...Gilles Chehade
2010-02-17Always call the shutdown code after returning from event_dispatch().Jonathan Gray
As the child processes now call event_loopexit() and signal handling is done through libevent if a child process died we wouldn't always cleanup properly and wouldn't do carp demote to failover either. This matches the way ospfd does things which is where the event_loopexit() in child processes change came from originally. ok claudio@ pyr@
2010-02-17the map api becomes backend-agnostic with initial support for db(3) andGilles Chehade
stdio(3) backends, though for now we only enable db(3). this is the first commit of a serie to improve maps and everything related. idea discussed with and diff okay jacekm@
2010-02-17localpart of a struct path may legally exceed MAXLOGNAME, causing lka toGilles Chehade
fatalx() on a lowercase() call in some cases. make sure lka uses a buffer capable of holding a localpart, and do not attempt getpwnam() if we know it's going to fail anyway... issue reported by Ben Lindstrom <mouring@eviladmin.org>
2010-02-16Make ldpd less verbose.Michele Marchetto
ok claudio@
2010-02-16Pick up RTM_DELADDR and issue an internal IFADDRDEL message to the ospfe toClaudio Jeker
inform about the interface address change. If this is an active interface it will be downed. A ospfctl reload is needed to fetch the new/changed IP if one got set. OK dlg@, sthen@
2010-02-16When taking an interface down just try to do the cleanup. In cases whereClaudio Jeker
the interface was removed or when the address changed leaving the multicast groups will fail because that already happend. Fix if_leave_group() to remove the refcount before doing the ioctl() so that the reference is correctly removed. OK dlg@, sthen@
2010-02-16Only merge interfaces that have the same address and netmask. Fixes a bugClaudio Jeker
with reloads when running ospfd on multiple aliases on the same interface. Is also needed to handle interface address changes in a much better way. OK dlg@, sthen@
2010-02-16Clear the DR and BDR addresses in nbr_act_delete(), makes the electionClaudio Jeker
process more reliable after interface flaps. Especially when the router-id changed at the same time. OK dlg@, sthen@
2010-02-16Lets violate the RFC once more. Change the way we map hello packets toClaudio Jeker
neighbors from using the source IP on broadcast interfaces to using the router-id all the time. The interface lookup will already check for matching subnets so there is no conflict possible. This makes ospfd finally grok router-id changes without freaking out. Additionally whinge when an other router is using the same router-id instead of failing in a very horrible way. OK sthen@, dlg@
2010-02-16Don't log the same thing twice. From a much bigger diff.Claudio Jeker
OK dlg@, sthen@
2010-02-16implement support for fast hello packets.David Gwynne
if route-dead-time is set to "minimal" (rather than a number of seconds), the dead time is set to 1 second and hellos are sent at the interval specified by fast-hello-interval in msecs. this is non standard wrt to the ospf rfc, but it does interoperate with at least one other router vendor. this allows much better responsiveness to l3 topology changes than the standard intervals allow. if i yank a cable to one of my upstreams, the routes adjust in a second rather than the default of 40 i was running with before. the users dont even notice something changed. developed while working with joshua atterbury. ok claudio@ as part of a larger diff. dedicated to zan rowe who thinks she is a bigger nerd than me.
2010-02-16the minimal spf-holdtime and spf-delay is 10 msec, not 50.David Gwynne
pointed out by claudio@ before, somehow it snuck back in.
2010-02-16allow spf-delay and spf-holdtime to be specified in msec so ospfd canDavid Gwynne
better respond to rapid topology changes. developed while working with joshua atterbury ok claudio@ as part of a larger diff.
2010-02-16Plug a memory leak in pushfile().Michele Marchetto
ok claudio@
2010-02-11Not knowing a AFI/SAFI pair in the MP capability is no reason to failClaudio Jeker
a session. Just print a warning and move on since both side need to announce a pair to use it. Found and OK sthen@
2010-02-11We need to load the config before kr_init() is called or fib-update isClaudio Jeker
ignored. Found and fix tested by Elisa Jasinska.
2010-02-11While looking through this code I figured out that set nexthop self andClaudio Jeker
no-modify are not supported for MP protocols like IPv6. Add support for those and while testing find another bug in the same region. Inverse the check for the return value of memcmp() -- we're interested in equality. Until now IPv6 was running with an implicit set nexthop self on all iBGP sessions. Oups. set nexthop stuff is OK when tested henning@ and sthen@
2010-02-11Force a space between address and nexthop. IPv6 is overflowing all sizeClaudio Jeker
restrictions and 2001:4bf8:bad:beef::/64fe80::20a:e4ff:fe39:5583 is not acceptable.
2010-02-09Don't hardcode the AID to AID_INET6 when sending MP EoR updates.Claudio Jeker
This will allow AID_VPN_IPv4 to do EoRs as well.
2010-02-08Unbreak IPv6 local address lookups. Some idiot aka me optimised a loop andClaudio Jeker
because of that either the IPv4 or IPv6 local address was not set. Because of this prefixes were sent out with all zero nexthops.
2010-02-08It is enough that peer->capa.mp[i] is non zero. It does not need to be 1.Claudio Jeker
2010-02-08...and yet another typo copied from ospfd: the ev_sighup event handlerPhilip Guenthe
should handle SIGHUP and not SIGTERM. SIGTERM is already handled by ev_sigterm.
2010-02-08Use SIGCHLD for the sigchild handler not SIGINT twice.Philip Guenthe
(This was inherited from ospfd; claudio fixed it there some time ago) Spotted in ripd by haesbaert <at> haesbaert.org
2010-02-07A few visual cleanups, and clarify a comment.Bret Lambert
Also: for (i = 0; i >= 0 && foo; i++) is functionally equivalent to: for (i = 0; foo; i++) so use the clearer construct where appropriate. ok pyr@
2010-02-06Remove newly generated sum file(s) if it did not exist before and trapAntoine Jacoutot
is called. While here, change shebang to /bin/ksh to reflect reality and bump copyright year. "checkbashisms says yes. :-)" && ok sthen@
2010-02-06Simplify LDAP URL handling (currently unused):Bret Lambert
instead of strdup()'ing multiple values from an already strdup'ed buffer (none of which were checked for NULL upon return, which is also fixed in this), just use a buffer attached to the aldap_url struct. Add an aldap_search_url() function, which is a wrapper around aldap_parse_url and aldap_search. Finally, since the URL bits are unused, wrap them in #if 0 for now. ok pyr@, whose heart was a little broken by the #if 0 (temporary, I swear!)