From 35acad1fc4886a330c7ef85e984580c9b6de3708 Mon Sep 17 00:00:00 2001 From: Marc Espie Date: Sat, 28 Nov 2009 10:25:35 +0000 Subject: rework display of missing libs some more: first show the libraries, then the dependency tree. --- usr.sbin/pkg_add/OpenBSD/Dependencies.pm | 15 ++++++++------- usr.sbin/pkg_add/OpenBSD/SharedLibs.pm | 3 ++- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/usr.sbin/pkg_add/OpenBSD/Dependencies.pm b/usr.sbin/pkg_add/OpenBSD/Dependencies.pm index 5bb6e0a48e2..0e5757def45 100644 --- a/usr.sbin/pkg_add/OpenBSD/Dependencies.pm +++ b/usr.sbin/pkg_add/OpenBSD/Dependencies.pm @@ -1,5 +1,5 @@ # ex:ts=8 sw=4: -# $OpenBSD: Dependencies.pm,v 1.84 2009/11/11 12:32:03 espie Exp $ +# $OpenBSD: Dependencies.pm,v 1.85 2009/11/28 10:25:34 espie Exp $ # # Copyright (c) 2005-2007 Marc Espie # @@ -472,18 +472,19 @@ sub solve_wantlibs next if $lib_finder->lookup($solver, $solver->{to_register}->{$h}, $state, $lib->{name}); - $state->errsay("Can't install ", - $h->pkgname, ": lib not found ", - $lib->{name}); if ($okay) { - $solver->dump; - $lib_finder->dump; - $okay = 0; + $state->errsay("Can't install ", + $h->pkgname, ":"); } + $okay = 0; OpenBSD::SharedLibs::report_problem( $state->{localbase}, $lib->{name}); } } + if (!$okay) { + $solver->dump; + $lib_finder->dump; + } return $okay; } diff --git a/usr.sbin/pkg_add/OpenBSD/SharedLibs.pm b/usr.sbin/pkg_add/OpenBSD/SharedLibs.pm index 2157c965743..837767b257c 100644 --- a/usr.sbin/pkg_add/OpenBSD/SharedLibs.pm +++ b/usr.sbin/pkg_add/OpenBSD/SharedLibs.pm @@ -1,5 +1,5 @@ # ex:ts=8 sw=4: -# $OpenBSD: SharedLibs.pm,v 1.37 2009/11/28 08:21:05 espie Exp $ +# $OpenBSD: SharedLibs.pm,v 1.38 2009/11/28 10:25:34 espie Exp $ # # Copyright (c) 2003-2005 Marc Espie # @@ -226,6 +226,7 @@ sub report_problem } if (!defined $printed->{$name} || $printed->{$name} ne $r) { $printed->{$name} = $r; + print "library $name not found\n"; print $r; } } -- cgit v1.2.3