From 7119931719c16b3e14f3ca5213b351e777080528 Mon Sep 17 00:00:00 2001
From: Scott Soule Cheloha <cheloha@cvs.openbsd.org>
Date: Sun, 4 Dec 2022 23:50:52 +0000
Subject: userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument.  We can
handle this case with the "default" failure case with no loss of
legibility.  Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@.  With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@
---
 sbin/dumpfs/dumpfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'sbin/dumpfs')

diff --git a/sbin/dumpfs/dumpfs.c b/sbin/dumpfs/dumpfs.c
index 0f09598a232..ec6da9dd3d1 100644
--- a/sbin/dumpfs/dumpfs.c
+++ b/sbin/dumpfs/dumpfs.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: dumpfs.c,v 1.36 2020/06/20 07:49:04 otto Exp $	*/
+/*	$OpenBSD: dumpfs.c,v 1.37 2022/12/04 23:50:46 cheloha Exp $	*/
 
 /*
  * Copyright (c) 2002 Networks Associates Technology, Inc.
@@ -89,7 +89,6 @@ main(int argc, char *argv[])
 		case 'm':
 			domarshal = 1;
 			break;
-		case '?':
 		default:
 			usage();
 		}
-- 
cgit v1.2.3