From 0a4a9df88e4339b22efeef2192b29449d870ee36 Mon Sep 17 00:00:00 2001 From: Mark Kettenis Date: Mon, 10 Jan 2011 16:18:04 +0000 Subject: Some nfe(4)/rlphy(4) combos don't work, because the PHY responds to all addresses on the mii bus. As a countereasure, only attach the first PHY we encounter. It is very unlikely we're going to ever see nfe(4) with multiple PHYs. The same is probably true for any modern NIC. ok mikeb@, deraadt@ --- sys/dev/pci/if_nfe.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'sys/dev/pci/if_nfe.c') diff --git a/sys/dev/pci/if_nfe.c b/sys/dev/pci/if_nfe.c index 02f6da6a142..515ee66e990 100644 --- a/sys/dev/pci/if_nfe.c +++ b/sys/dev/pci/if_nfe.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_nfe.c,v 1.96 2010/09/07 16:21:45 deraadt Exp $ */ +/* $OpenBSD: if_nfe.c,v 1.97 2011/01/10 16:18:03 kettenis Exp $ */ /*- * Copyright (c) 2006, 2007 Damien Bergamini @@ -368,8 +368,7 @@ nfe_attach(struct device *parent, struct device *self, void *aux) ifmedia_init(&sc->sc_mii.mii_media, 0, nfe_ifmedia_upd, nfe_ifmedia_sts); - mii_attach(self, &sc->sc_mii, 0xffffffff, MII_PHY_ANY, - MII_OFFSET_ANY, 0); + mii_attach(self, &sc->sc_mii, 0xffffffff, MII_PHY_ANY, 0, 0); if (LIST_FIRST(&sc->sc_mii.mii_phys) == NULL) { printf("%s: no PHY found!\n", sc->sc_dev.dv_xname); ifmedia_add(&sc->sc_mii.mii_media, IFM_ETHER | IFM_MANUAL, -- cgit v1.2.3