From 8fe25da9d7762dba747313181158c50980ec44e0 Mon Sep 17 00:00:00 2001 From: Miod Vallat Date: Fri, 23 Jun 2006 06:27:13 +0000 Subject: In a drivers activate() entry point, if on DVACT_DEACTIVATE it does something, then it MUST return zero on DVACT_ACTIVATE, not EOPNOTSUPP; this very popular bug has been cut and pasted a lot of times... ok deraadt@ mickey@ --- sys/dev/usb/ohci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'sys/dev/usb/ohci.c') diff --git a/sys/dev/usb/ohci.c b/sys/dev/usb/ohci.c index fbcc074bf6a..e5f1f55e477 100644 --- a/sys/dev/usb/ohci.c +++ b/sys/dev/usb/ohci.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ohci.c,v 1.72 2006/05/31 06:18:09 pascoe Exp $ */ +/* $OpenBSD: ohci.c,v 1.73 2006/06/23 06:27:11 miod Exp $ */ /* $NetBSD: ohci.c,v 1.139 2003/02/22 05:24:16 tsutsui Exp $ */ /* $FreeBSD: src/sys/dev/usb/ohci.c,v 1.22 1999/11/17 22:33:40 n_hibma Exp $ */ @@ -318,7 +318,7 @@ ohci_activate(device_ptr_t self, enum devact act) switch (act) { case DVACT_ACTIVATE: - return (EOPNOTSUPP); + break; case DVACT_DEACTIVATE: if (sc->sc_child != NULL) -- cgit v1.2.3