From b0780212916419166a6fdd8caec2457cbd712e99 Mon Sep 17 00:00:00 2001 From: Patrick Wildt Date: Wed, 29 Apr 2020 09:44:50 +0000 Subject: According to the SDIO Simplified Specification 3.0, a tuple length (aka link field) of 0 specifies an empty tuple body. This implies that a tuple length of 0 is actually allowed, so we don't need to error out if we encounter one. Seen on an SDIO-connected ath10k. ok kettenis@ --- sys/dev/sdmmc/sdmmc_cis.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'sys/dev') diff --git a/sys/dev/sdmmc/sdmmc_cis.c b/sys/dev/sdmmc/sdmmc_cis.c index 21cf530b24f..9c7bdf00863 100644 --- a/sys/dev/sdmmc/sdmmc_cis.c +++ b/sys/dev/sdmmc/sdmmc_cis.c @@ -1,4 +1,4 @@ -/* $OpenBSD: sdmmc_cis.c,v 1.7 2016/04/23 14:15:59 kettenis Exp $ */ +/* $OpenBSD: sdmmc_cis.c,v 1.8 2020/04/29 09:44:49 patrick Exp $ */ /* * Copyright (c) 2006 Uwe Stuehler @@ -76,12 +76,6 @@ sdmmc_read_cis(struct sdmmc_function *sf, struct sdmmc_cis *cis) continue; tpllen = sdmmc_io_read_1(sf0, reg++); - if (tpllen == 0) { - printf("%s: CIS parse error at %d, " - "tuple code %#x, length %d\n", - DEVNAME(sf->sc), reg, tplcode, tpllen); - break; - } switch (tplcode) { case SD_IO_CISTPL_FUNCID: -- cgit v1.2.3