From 2c88a4441fc7f8daffe457a6412871272f744fe2 Mon Sep 17 00:00:00 2001 From: Theo de Raadt Date: Fri, 1 Jun 2007 23:47:58 +0000 Subject: pedro ok'd this ~3500 line diff which removes the vop argument "ap = v" comments in under 8 seconds, so it must be ok. and it compiles too. --- sys/miscfs/procfs/procfs_vnops.c | 90 +++++++--------------------------------- 1 file changed, 15 insertions(+), 75 deletions(-) (limited to 'sys/miscfs/procfs') diff --git a/sys/miscfs/procfs/procfs_vnops.c b/sys/miscfs/procfs/procfs_vnops.c index 90f7f578b23..12813cf8b34 100644 --- a/sys/miscfs/procfs/procfs_vnops.c +++ b/sys/miscfs/procfs/procfs_vnops.c @@ -1,4 +1,4 @@ -/* $OpenBSD: procfs_vnops.c,v 1.38 2006/03/05 21:48:56 miod Exp $ */ +/* $OpenBSD: procfs_vnops.c,v 1.39 2007/06/01 23:47:57 deraadt Exp $ */ /* $NetBSD: procfs_vnops.c,v 1.40 1996/03/16 23:52:55 christos Exp $ */ /* @@ -207,12 +207,7 @@ int procfs_open(v) void *v; { - struct vop_open_args /* { - struct vnode *a_vp; - int a_mode; - struct ucred *a_cred; - struct proc *a_p; - } */ *ap = v; + struct vop_open_args *ap = v; struct pfsnode *pfs = VTOPFS(ap->a_vp); struct proc *p1 = ap->a_p; /* tracer */ struct proc *p2; /* traced */ @@ -253,12 +248,7 @@ int procfs_close(v) void *v; { - struct vop_close_args /* { - struct vnode *a_vp; - int a_fflag; - struct ucred *a_cred; - struct proc *a_p; - } */ *ap = v; + struct vop_close_args *ap = v; struct pfsnode *pfs = VTOPFS(ap->a_vp); switch (pfs->pfs_type) { @@ -313,12 +303,7 @@ int procfs_bmap(v) void *v; { - struct vop_bmap_args /* { - struct vnode *a_vp; - daddr_t a_bn; - struct vnode **a_vpp; - daddr_t *a_bnp; - } */ *ap = v; + struct vop_bmap_args *ap = v; if (ap->a_vpp != NULL) *ap->a_vpp = ap->a_vp; @@ -347,9 +332,7 @@ int procfs_inactive(v) void *v; { - struct vop_inactive_args /* { - struct vnode *a_vp; - } */ *ap = v; + struct vop_inactive_args *ap = v; struct vnode *vp = ap->a_vp; struct pfsnode *pfs = VTOPFS(vp); @@ -370,9 +353,7 @@ int procfs_reclaim(v) void *v; { - struct vop_reclaim_args /* { - struct vnode *a_vp; - } */ *ap = v; + struct vop_reclaim_args *ap = v; return (procfs_freevp(ap->a_vp)); } @@ -384,11 +365,7 @@ int procfs_pathconf(v) void *v; { - struct vop_pathconf_args /* { - struct vnode *a_vp; - int a_name; - register_t *a_retval; - } */ *ap = v; + struct vop_pathconf_args *ap = v; switch (ap->a_name) { case _PC_LINK_MAX: @@ -424,9 +401,7 @@ int procfs_print(v) void *v; { - struct vop_print_args /* { - struct vnode *a_vp; - } */ *ap = v; + struct vop_print_args *ap = v; struct pfsnode *pfs = VTOPFS(ap->a_vp); printf("tag VT_PROCFS, type %d, pid %d, mode %x, flags %lx\n", @@ -438,11 +413,7 @@ int procfs_link(v) void *v; { - struct vop_link_args /* { - struct vnode *a_dvp; - struct vnode *a_vp; - struct componentname *a_cnp; - } */ *ap = v; + struct vop_link_args *ap = v; VOP_ABORTOP(ap->a_dvp, ap->a_cnp); vput(ap->a_dvp); @@ -453,13 +424,7 @@ int procfs_symlink(v) void *v; { - struct vop_symlink_args /* { - struct vnode *a_dvp; - struct vnode **a_vpp; - struct componentname *a_cnp; - struct vattr *a_vap; - char *a_target; - } */ *ap = v; + struct vop_symlink_args *ap = v; VOP_ABORTOP(ap->a_dvp, ap->a_cnp); vput(ap->a_dvp); @@ -492,12 +457,7 @@ int procfs_getattr(v) void *v; { - struct vop_getattr_args /* { - struct vnode *a_vp; - struct vattr *a_vap; - struct ucred *a_cred; - struct proc *a_p; - } */ *ap = v; + struct vop_getattr_args *ap = v; struct pfsnode *pfs = VTOPFS(ap->a_vp); struct vattr *vap = ap->a_vap; struct proc *procp; @@ -704,12 +664,7 @@ int procfs_access(v) void *v; { - struct vop_access_args /* { - struct vnode *a_vp; - int a_mode; - struct ucred *a_cred; - struct proc *a_p; - } */ *ap = v; + struct vop_access_args *ap = v; struct vattr va; int error; @@ -733,11 +688,7 @@ int procfs_lookup(v) void *v; { - struct vop_lookup_args /* { - struct vnode * a_dvp; - struct vnode ** a_vpp; - struct componentname * a_cnp; - } */ *ap = v; + struct vop_lookup_args *ap = v; struct componentname *cnp = ap->a_cnp; struct vnode **vpp = ap->a_vpp; struct vnode *dvp = ap->a_dvp; @@ -912,14 +863,7 @@ int procfs_readdir(v) void *v; { - struct vop_readdir_args /* { - struct vnode *a_vp; - struct uio *a_uio; - struct ucred *a_cred; - int *a_eofflag; - u_long *a_cookies; - int a_ncookies; - } */ *ap = v; + struct vop_readdir_args *ap = v; struct uio *uio = ap->a_uio; struct dirent d; struct pfsnode *pfs; @@ -1129,11 +1073,7 @@ int procfs_poll(v) void *v; { - struct vop_poll_args /* { - struct vnode *a_vp; - int a_events; - struct proc *a_p; - } */ *ap = v; + struct vop_poll_args *ap = v; return (ap->a_events & (POLLIN | POLLOUT | POLLRDNORM | POLLWRNORM)); } -- cgit v1.2.3