From 4a325f8481a83c10598abc934b5bd7884e8c2061 Mon Sep 17 00:00:00 2001
From: Theo de Raadt <deraadt@cvs.openbsd.org>
Date: Mon, 8 Jul 1996 20:49:12 +0000
Subject: 8lgm#26, buffer overflow

---
 usr.bin/oldrdist/lookup.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

(limited to 'usr.bin/oldrdist')

diff --git a/usr.bin/oldrdist/lookup.c b/usr.bin/oldrdist/lookup.c
index 1fbc1b2b0e6..0048426a9b7 100644
--- a/usr.bin/oldrdist/lookup.c
+++ b/usr.bin/oldrdist/lookup.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: lookup.c,v 1.2 1996/06/26 05:37:39 deraadt Exp $	*/
+/*	$OpenBSD: lookup.c,v 1.3 1996/07/08 20:49:11 deraadt Exp $	*/
 
 /*
  * Copyright (c) 1983, 1993
@@ -35,7 +35,7 @@
 
 #ifndef lint
 /* from: static char sccsid[] = "@(#)lookup.c	8.1 (Berkeley) 6/9/93"; */
-static char *rcsid = "$OpenBSD: lookup.c,v 1.2 1996/06/26 05:37:39 deraadt Exp $";
+static char *rcsid = "$OpenBSD: lookup.c,v 1.3 1996/07/08 20:49:11 deraadt Exp $";
 #endif /* not lint */
 
 #include "defs.h"
@@ -129,7 +129,7 @@ lookup(name, action, value)
 	register unsigned n;
 	register char *cp;
 	register struct syment *s;
-	char buf[256];
+	char buf[1024];
 
 	if (debug)
 		printf("lookup(%s, %d, %x)\n", name, action, value);
@@ -144,7 +144,8 @@ lookup(name, action, value)
 			continue;
 		if (action != LOOKUP) {
 			if (action != INSERT || s->s_type != CONST) {
-				(void)sprintf(buf, "%s redefined", name);
+				(void)snprintf(buf, sizeof buf,
+				    "%s redefined", name);
 				yyerror(buf);
 			}
 		}
@@ -152,7 +153,7 @@ lookup(name, action, value)
 	}
 
 	if (action == LOOKUP) {
-		(void)sprintf(buf, "%s undefined", name);
+		(void)snprintf(buf, sizeof buf, "%s undefined", name);
 		yyerror(buf);
 		return(NULL);
 	}
-- 
cgit v1.2.3