1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
|
#!./perl -w
#
# Copyright 2002, Larry Wall.
#
# You may redistribute only under the same terms as Perl 5, as specified
# in the README file that comes with the distribution.
#
# I'm trying to keep this test easily backwards compatible to 5.004, so no
# qr//;
# This test tries to craft malicious data to test out as many different
# error traps in Storable as possible
# It also acts as a test for read_header
sub BEGIN {
# This lets us distribute Test::More in t/
unshift @INC, 't';
unshift @INC, 't/compat' if $] < 5.006002;
require Config; import Config;
if ($ENV{PERL_CORE} and $Config{'extensions'} !~ /\bStorable\b/) {
print "1..0 # Skip: Storable was not built\n";
exit 0;
}
}
use strict;
our $byteorder = $Config{byteorder};
our $file_magic_str = 'pst0';
our $other_magic = 7 + length $byteorder;
our $network_magic = 2;
our $major = 2;
our $minor = 11;
our $minor_write = $] >= 5.019 ? 11 : $] > 5.008 ? 9 : $] > 5.005_50 ? 8 : 4;
use Test::More;
# If it's 5.7.3 or later the hash will be stored with flags, which is
# 2 extra bytes. There are 2 * 2 * 2 tests per byte in the body and header
# common to normal and network order serialised objects (hence the 8)
# There are only 2 * 2 tests per byte in the parts of the header not present
# for network order, and 2 tests per byte on the 'pst0' "magic number" only
# present in files, but not in things store()ed to memory
our $fancy = ($] > 5.007 ? 2 : 0);
plan tests => 372 + length ($byteorder) * 4 + $fancy * 8;
use Storable qw (store retrieve freeze thaw nstore nfreeze);
require 'testlib.pl';
our $file;
# The chr 256 is a hack to force the hash to always have the utf8 keys flag
# set on 5.7.3 and later. Otherwise the test fails if run with -Mutf8 because
# only there does the hash has the flag on, and hence only there is it stored
# as a flagged hash, which is 2 bytes longer
my %hash = (perl => 'rules', chr 256, '');
delete $hash{chr 256};
sub test_hash {
my $clone = shift;
is (ref $clone, "HASH", "Get hash back");
is (scalar keys %$clone, 1, "with 1 key");
is ((keys %$clone)[0], "perl", "which is correct");
is ($clone->{perl}, "rules", "Got expected value when looking up key in clone");
}
sub test_header {
my ($header, $isfile, $isnetorder) = @_;
is (!!$header->{file}, !!$isfile, "is file");
is ($header->{major}, $major, "major number");
is ($header->{minor}, $minor_write, "minor number");
is (!!$header->{netorder}, !!$isnetorder, "is network order");
if ($isnetorder) {
# Network order header has no sizes
} else {
is ($header->{byteorder}, $byteorder, "byte order");
is ($header->{intsize}, $Config{intsize}, "int size");
is ($header->{longsize}, $Config{longsize}, "long size");
SKIP: {
skip ("No \$Config{prtsize} on this perl version ($])", 1)
unless defined $Config{ptrsize};
is ($header->{ptrsize}, $Config{ptrsize}, "long size");
}
is ($header->{nvsize}, $Config{nvsize} || $Config{doublesize} || 8,
"nv size"); # 5.00405 doesn't even have doublesize in config.
}
}
sub test_truncated {
my ($data, $sub, $magic_len, $what) = @_;
for my $i (0 .. length ($data) - 1) {
my $short = substr $data, 0, $i;
# local $Storable::DEBUGME = 1;
my $clone = &$sub($short);
is (defined ($clone), '', "truncated $what to $i should fail");
if ($i < $magic_len) {
like ($@, "/^Magic number checking on storable $what failed/",
"Should croak with magic number warning");
} else {
is ($@, "", "Should not set \$\@");
}
}
}
sub test_corrupt {
my ($data, $sub, $what, $name) = @_;
my $clone = &$sub($data);
local $Test::Builder::Level = $Test::Builder::Level + 1;
is (defined ($clone), '', "$name $what should fail");
like ($@, $what, $name);
}
sub test_things {
my ($contents, $sub, $what, $isnetwork) = @_;
my $isfile = $what eq 'file';
my $file_magic = $isfile ? length $file_magic_str : 0;
my $header = Storable::read_magic ($contents);
test_header ($header, $isfile, $isnetwork);
# Test that if we re-write it, everything still works:
my $clone = &$sub ($contents);
is ($@, "", "There should be no error");
test_hash ($clone);
# Now lets check the short version:
test_truncated ($contents, $sub, $file_magic
+ ($isnetwork ? $network_magic : $other_magic), $what);
my $copy;
if ($isfile) {
$copy = $contents;
substr ($copy, 0, 4) = 'iron';
test_corrupt ($copy, $sub, "/^File is not a perl storable/",
"magic number");
}
$copy = $contents;
# Needs to be more than 1, as we're already coding a spread of 1 minor version
# number on writes (2.5, 2.4). May increase to 2 if we figure we can do 2.3
# on 5.005_03 (No utf8).
# 4 allows for a small safety margin
# Which we've now exhausted given that Storable 2.25 is writing 2.8
# (Joke:
# Question: What is the value of pi?
# Mathematician answers "It's pi, isn't it"
# Physicist answers "3.1, within experimental error"
# Engineer answers "Well, allowing for a small safety margin, 18"
# )
my $minor6 = $header->{minor} + 6;
substr ($copy, $file_magic + 1, 1) = chr $minor6;
{
# Now by default newer minor version numbers are not a pain.
$clone = &$sub($copy);
is ($@, "", "by default no error on higher minor");
test_hash ($clone);
local $Storable::accept_future_minor = 0;
test_corrupt ($copy, $sub,
"/^Storable binary image v$header->{major}\.$minor6 more recent than I am \\(v$header->{major}\.$minor\\)/",
"higher minor");
}
$copy = $contents;
my $major1 = $header->{major} + 1;
substr ($copy, $file_magic, 1) = chr 2*$major1;
test_corrupt ($copy, $sub,
"/^Storable binary image v$major1\.$header->{minor} more recent than I am \\(v$header->{major}\.$minor\\)/",
"higher major");
# Continue messing with the previous copy
my $minor1 = $header->{minor} - 1;
substr ($copy, $file_magic + 1, 1) = chr $minor1;
test_corrupt ($copy, $sub,
"/^Storable binary image v$major1\.$minor1 more recent than I am \\(v$header->{major}\.$minor\\)/",
"higher major, lower minor");
my $where;
if (!$isnetwork) {
# All these are omitted from the network order header.
# I'm not sure if it's correct to omit the byte size stuff.
$copy = $contents;
substr ($copy, $file_magic + 3, length $header->{byteorder})
= reverse $header->{byteorder};
test_corrupt ($copy, $sub, "/^Byte order is not compatible/",
"byte order");
$where = $file_magic + 3 + length $header->{byteorder};
foreach (['intsize', "Integer"],
['longsize', "Long integer"],
['ptrsize', "Pointer"],
['nvsize', "Double"]) {
my ($key, $name) = @$_;
$copy = $contents;
substr ($copy, $where++, 1) = chr 0;
test_corrupt ($copy, $sub, "/^$name size is not compatible/",
"$name size");
}
} else {
$where = $file_magic + $network_magic;
}
# Just the header and a tag 255. As 33 is currently the highest tag, this
# is "unexpected"
$copy = substr ($contents, 0, $where) . chr 255;
test_corrupt ($copy, $sub,
"/^Corrupted storable $what \\(binary v$header->{major}.$header->{minor}\\)/",
"bogus tag");
# Now drop the minor version number
substr ($copy, $file_magic + 1, 1) = chr $minor1;
test_corrupt ($copy, $sub,
"/^Corrupted storable $what \\(binary v$header->{major}.$minor1\\)/",
"bogus tag, minor less 1");
# Now increase the minor version number
substr ($copy, $file_magic + 1, 1) = chr $minor6;
# local $Storable::DEBUGME = 1;
# This is the delayed croak
test_corrupt ($copy, $sub,
"/^Storable binary image v$header->{major}.$minor6 contains data of type 255. This Storable is v$header->{major}.$minor and can only handle data types up to 33/",
"bogus tag, minor plus 4");
# And check again that this croak is not delayed:
{
# local $Storable::DEBUGME = 1;
local $Storable::accept_future_minor = 0;
test_corrupt ($copy, $sub,
"/^Storable binary image v$header->{major}\.$minor6 more recent than I am \\(v$header->{major}\.$minor\\)/",
"higher minor");
}
}
ok (defined store(\%hash, $file), "store() returned defined value");
my $expected = 20 + length ($file_magic_str) + $other_magic + $fancy;
my $length = -s $file;
die "Don't seem to have written file '$file' as I can't get its length: $!"
unless defined $file;
die "Expected file to be $expected bytes (sizeof long is $Config{longsize}) but it is $length"
unless $length == $expected;
# Read the contents into memory:
my $contents = slurp ($file);
# Test the original direct from disk
my $clone = retrieve $file;
test_hash ($clone);
# Then test it.
test_things($contents, \&store_and_retrieve, 'file');
# And now try almost everything again with a Storable string
my $stored = freeze \%hash;
test_things($stored, \&freeze_and_thaw, 'string');
# Network order.
unlink $file or die "Can't unlink '$file': $!";
ok (defined nstore(\%hash, $file), "nstore() returned defined value");
$expected = 20 + length ($file_magic_str) + $network_magic + $fancy;
$length = -s $file;
die "Don't seem to have written file '$file' as I can't get its length: $!"
unless defined $file;
die "Expected file to be $expected bytes (sizeof long is $Config{longsize}) but it is $length"
unless $length == $expected;
# Read the contents into memory:
$contents = slurp ($file);
# Test the original direct from disk
$clone = retrieve $file;
test_hash ($clone);
# Then test it.
test_things($contents, \&store_and_retrieve, 'file', 1);
# And now try almost everything again with a Storable string
$stored = nfreeze \%hash;
test_things($stored, \&freeze_and_thaw, 'string', 1);
# Test that the bug fixed by #20587 doesn't affect us under some older
# Perl. AMS 20030901
{
chop(my $a = chr(0xDF).chr(256));
my %a = (chr(0xDF) => 1);
$a{$a}++;
freeze \%a;
# If we were built with -DDEBUGGING, the assert() should have killed
# us, which will probably alert the user that something went wrong.
ok(1);
}
# Unusual in that the empty string is stored with an SX_LSCALAR marker
my $hash = store_and_retrieve("pst0\5\6\3\0\0\0\1\1\0\0\0\0\0\0\0\5empty");
ok(!$@, "no exception");
is(ref($hash), "HASH", "got a hash");
is($hash->{empty}, "", "got empty element");
|