1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
|
/* $OpenBSD: mft.c,v 1.8 2019/10/23 07:36:29 claudio Exp $ */
/*
* Copyright (c) 2019 Kristaps Dzonsons <kristaps@bsd.lv>
*
* Permission to use, copy, modify, and distribute this software for any
* purpose with or without fee is hereby granted, provided that the above
* copyright notice and this permission notice appear in all copies.
*
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
#include <assert.h>
#include <err.h>
#include <stdarg.h>
#include <stdint.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include <openssl/ssl.h>
#include "extern.h"
/*
* Parse results and data of the manifest file.
*/
struct parse {
const char *fn; /* manifest file name */
struct mft *res; /* result object */
};
static const char *
gentime2str(const ASN1_GENERALIZEDTIME *time)
{
static char buf[64];
BIO *mem;
if ((mem = BIO_new(BIO_s_mem())) == NULL)
cryptoerrx("BIO_new");
if (!ASN1_GENERALIZEDTIME_print(mem, time))
cryptoerrx("ASN1_GENERALIZEDTIME_print");
if (BIO_gets(mem, buf, sizeof(buf)) < 0)
cryptoerrx("BIO_gets");
BIO_free(mem);
return buf;
}
/*
* Validate and verify the time validity of the mft.
* Returns 1 if all is good, 0 if mft is stale, any other case -1.
* XXX should use ASN1_time_tm_cmp() once libressl is used.
*/
static time_t
check_validity(const ASN1_GENERALIZEDTIME *from,
const ASN1_GENERALIZEDTIME *until, const char *fn, int force)
{
time_t now = time(NULL);
if (!ASN1_GENERALIZEDTIME_check(from) ||
!ASN1_GENERALIZEDTIME_check(until)) {
warnx("%s: embedded time format invalid", fn);
return -1;
}
/* check that until is not before from */
if (ASN1_STRING_cmp(until, from) < 0) {
warnx("%s: bad update interval", fn);
return -1;
}
/* check that now is not before from */
if (X509_cmp_time(from, &now) > 0) {
warnx("%s: mft not yet valid %s", fn, gentime2str(from));
return -1;
}
/* check that now is not after until */
if (X509_cmp_time(until, &now) < 0) {
warnx("%s: mft expired on %s%s", fn, gentime2str(until),
force ? " (ignoring)" : "");
if (!force)
return 0;
}
return 1;
}
/*
* Parse an individual "FileAndHash", RFC 6486, sec. 4.2.
* Return zero on failure, non-zero on success.
*/
static int
mft_parse_filehash(struct parse *p, const ASN1_OCTET_STRING *os)
{
const ASN1_SEQUENCE_ANY *seq;
const ASN1_TYPE *file, *hash;
char *fn = NULL;
const unsigned char *d = os->data;
size_t dsz = os->length, sz;
int rc = 0;
struct mftfile *fent;
if ((seq = d2i_ASN1_SEQUENCE_ANY(NULL, &d, dsz)) == NULL) {
cryptowarnx("%s: RFC 6486 section 4.2.1: FileAndHash: "
"failed ASN.1 sequence parse", p->fn);
goto out;
} else if (sk_ASN1_TYPE_num(seq) != 2) {
warnx("%s: RFC 6486 section 4.2.1: FileAndHash: "
"want 2 elements, have %d", p->fn,
sk_ASN1_TYPE_num(seq));
goto out;
}
/* First is the filename itself. */
file = sk_ASN1_TYPE_value(seq, 0);
if (file->type != V_ASN1_IA5STRING) {
warnx("%s: RFC 6486 section 4.2.1: FileAndHash: "
"want ASN.1 IA5 string, have %s (NID %d)",
p->fn, ASN1_tag2str(file->type), file->type);
goto out;
}
fn = strndup((const char *)file->value.ia5string->data,
file->value.ia5string->length);
if (fn == NULL)
err(EXIT_FAILURE, NULL);
/*
* Make sure we're just a pathname and either an ROA or CER.
* I don't think that the RFC specifically mentions this, but
* it's in practical use and would really screw things up
* (arbitrary filenames) otherwise.
*/
if (strchr(fn, '/') != NULL) {
warnx("%s: path components disallowed in filename: %s",
p->fn, fn);
goto out;
} else if ((sz = strlen(fn)) <= 4) {
warnx("%s: filename must be large enough for suffix part: %s",
p->fn, fn);
goto out;
}
if (strcasecmp(fn + sz - 4, ".roa") &&
strcasecmp(fn + sz - 4, ".crl") &&
strcasecmp(fn + sz - 4, ".cer")) {
free(fn);
fn = NULL;
rc = 1;
goto out;
}
/* Now hash value. */
hash = sk_ASN1_TYPE_value(seq, 1);
if (hash->type != V_ASN1_BIT_STRING) {
warnx("%s: RFC 6486 section 4.2.1: FileAndHash: "
"want ASN.1 bit string, have %s (NID %d)",
p->fn, ASN1_tag2str(hash->type), hash->type);
goto out;
}
if (hash->value.bit_string->length != SHA256_DIGEST_LENGTH) {
warnx("%s: RFC 6486 section 4.2.1: hash: "
"invalid SHA256 length, have %d",
p->fn, hash->value.bit_string->length);
goto out;
}
/* Insert the filename and hash value. */
p->res->files = reallocarray(p->res->files, p->res->filesz + 1,
sizeof(struct mftfile));
if (p->res->files == NULL)
err(EXIT_FAILURE, NULL);
fent = &p->res->files[p->res->filesz++];
memset(fent, 0, sizeof(struct mftfile));
fent->file = fn;
fn = NULL;
memcpy(fent->hash, hash->value.bit_string->data, SHA256_DIGEST_LENGTH);
rc = 1;
out:
free(fn);
sk_ASN1_TYPE_pop_free(seq, ASN1_TYPE_free);
return rc;
}
/*
* Parse the "FileAndHash" sequence, RFC 6486, sec. 4.2.
* Return zero on failure, non-zero on success.
*/
static int
mft_parse_flist(struct parse *p, const ASN1_OCTET_STRING *os)
{
ASN1_SEQUENCE_ANY *seq;
const ASN1_TYPE *t;
const unsigned char *d = os->data;
size_t dsz = os->length;
int i, rc = 0;
if ((seq = d2i_ASN1_SEQUENCE_ANY(NULL, &d, dsz)) == NULL) {
cryptowarnx("%s: RFC 6486 section 4.2: fileList: "
"failed ASN.1 sequence parse", p->fn);
goto out;
}
for (i = 0; i < sk_ASN1_TYPE_num(seq); i++) {
t = sk_ASN1_TYPE_value(seq, i);
if (t->type != V_ASN1_SEQUENCE) {
warnx("%s: RFC 6486 section 4.2: fileList: "
"want ASN.1 sequence, have %s (NID %d)",
p->fn, ASN1_tag2str(t->type), t->type);
goto out;
} else if (!mft_parse_filehash(p, t->value.octet_string))
goto out;
}
rc = 1;
out:
sk_ASN1_TYPE_pop_free(seq, ASN1_TYPE_free);
return rc;
}
/*
* Handle the eContent of the manifest object, RFC 6486 sec. 4.2.
* Returns <0 on failure, 0 on stale, >0 on success.
*/
static int
mft_parse_econtent(const unsigned char *d, size_t dsz, struct parse *p, int force)
{
ASN1_SEQUENCE_ANY *seq;
const ASN1_TYPE *t;
const ASN1_GENERALIZEDTIME *from, *until;
int i, rc = -1;
if ((seq = d2i_ASN1_SEQUENCE_ANY(NULL, &d, dsz)) == NULL) {
cryptowarnx("%s: RFC 6486 section 4.2: Manifest: "
"failed ASN.1 sequence parse", p->fn);
goto out;
}
/* The version is optional. */
if (sk_ASN1_TYPE_num(seq) != 5 &&
sk_ASN1_TYPE_num(seq) != 6) {
warnx("%s: RFC 6486 section 4.2: Manifest: "
"want 5 or 6 elements, have %d", p->fn,
sk_ASN1_TYPE_num(seq));
goto out;
}
/* Start with optional version. */
i = 0;
if (sk_ASN1_TYPE_num(seq) == 6) {
t = sk_ASN1_TYPE_value(seq, i++);
if (t->type != V_ASN1_INTEGER) {
warnx("%s: RFC 6486 section 4.2.1: version: "
"want ASN.1 integer, have %s (NID %d)",
p->fn, ASN1_tag2str(t->type), t->type);
goto out;
}
}
/* Now the manifest sequence number. */
t = sk_ASN1_TYPE_value(seq, i++);
if (t->type != V_ASN1_INTEGER) {
warnx("%s: RFC 6486 section 4.2.1: manifestNumber: "
"want ASN.1 integer, have %s (NID %d)",
p->fn, ASN1_tag2str(t->type), t->type);
goto out;
}
/*
* Timestamps: this and next update time.
* Validate that the current date falls into this interval.
* This is required by section 4.4, (3).
* If we're after the given date, then the MFT is stale.
* This is made super complicated because it usees OpenSSL's
* ASN1_GENERALIZEDTIME instead of ASN1_TIME, which we could
* compare against the current time trivially.
*/
t = sk_ASN1_TYPE_value(seq, i++);
if (t->type != V_ASN1_GENERALIZEDTIME) {
warnx("%s: RFC 6486 section 4.2.1: thisUpdate: "
"want ASN.1 generalised time, have %s (NID %d)",
p->fn, ASN1_tag2str(t->type), t->type);
goto out;
}
from = t->value.generalizedtime;
t = sk_ASN1_TYPE_value(seq, i++);
if (t->type != V_ASN1_GENERALIZEDTIME) {
warnx("%s: RFC 6486 section 4.2.1: nextUpdate: "
"want ASN.1 generalised time, have %s (NID %d)",
p->fn, ASN1_tag2str(t->type), t->type);
goto out;
}
until = t->value.generalizedtime;
rc = check_validity(from, until, p->fn, force);
if (rc != 1)
goto out;
/* File list algorithm. */
t = sk_ASN1_TYPE_value(seq, i++);
if (t->type != V_ASN1_OBJECT) {
warnx("%s: RFC 6486 section 4.2.1: fileHashAlg: "
"want ASN.1 object time, have %s (NID %d)",
p->fn, ASN1_tag2str(t->type), t->type);
goto out;
} else if (OBJ_obj2nid(t->value.object) != NID_sha256) {
warnx("%s: RFC 6486 section 4.2.1: fileHashAlg: "
"want SHA256 object, have %s (NID %d)", p->fn,
ASN1_tag2str(OBJ_obj2nid(t->value.object)),
OBJ_obj2nid(t->value.object));
goto out;
}
/* Now the sequence. */
t = sk_ASN1_TYPE_value(seq, i++);
if (t->type != V_ASN1_SEQUENCE) {
warnx("%s: RFC 6486 section 4.2.1: fileList: "
"want ASN.1 sequence, have %s (NID %d)",
p->fn, ASN1_tag2str(t->type), t->type);
goto out;
} else if (!mft_parse_flist(p, t->value.octet_string))
goto out;
rc = 1;
out:
sk_ASN1_TYPE_pop_free(seq, ASN1_TYPE_free);
return rc;
}
/*
* Parse the objects that have been published in the manifest.
* This conforms to RFC 6486.
* Note that if the MFT is stale, all referenced objects are stripped
* from the parsed content.
* The MFT content is otherwise returned.
*/
struct mft *
mft_parse(X509 **x509, const char *fn, int force)
{
struct parse p;
int c, rc = 0;
size_t i, cmsz;
unsigned char *cms;
memset(&p, 0, sizeof(struct parse));
p.fn = fn;
cms = cms_parse_validate(x509, fn, "1.2.840.113549.1.9.16.1.26",
NULL, &cmsz);
if (cms == NULL)
return NULL;
assert(*x509 != NULL);
if ((p.res = calloc(1, sizeof(struct mft))) == NULL)
err(EXIT_FAILURE, NULL);
if ((p.res->file = strdup(fn)) == NULL)
err(EXIT_FAILURE, NULL);
if (!x509_get_ski_aki(*x509, fn, &p.res->ski, &p.res->aki))
goto out;
/*
* If we're stale, then remove all of the files that the MFT
* references as well as marking it as stale.
*/
if ((c = mft_parse_econtent(cms, cmsz, &p, force)) == 0) {
/*
* FIXME: it should suffice to just mark this as stale
* and have the logic around mft_read() simply ignore
* the contents of stale entries, just like it does for
* invalid ROAs or certificates.
*/
p.res->stale = 1;
if (p.res->files != NULL)
for (i = 0; i < p.res->filesz; i++)
free(p.res->files[i].file);
free(p.res->files);
p.res->filesz = 0;
p.res->files = NULL;
} else if (c == -1)
goto out;
rc = 1;
out:
if (rc == 0) {
mft_free(p.res);
p.res = NULL;
X509_free(*x509);
*x509 = NULL;
}
free(cms);
return p.res;
}
/*
* Free an MFT pointer.
* Safe to call with NULL.
*/
void
mft_free(struct mft *p)
{
size_t i;
if (p == NULL)
return;
if (p->files != NULL)
for (i = 0; i < p->filesz; i++)
free(p->files[i].file);
free(p->aki);
free(p->ski);
free(p->file);
free(p->files);
free(p);
}
/*
* Serialise MFT parsed content into the given buffer.
* See mft_read() for the other side of the pipe.
*/
void
mft_buffer(char **b, size_t *bsz, size_t *bmax, const struct mft *p)
{
size_t i;
io_simple_buffer(b, bsz, bmax, &p->stale, sizeof(int));
io_str_buffer(b, bsz, bmax, p->file);
io_simple_buffer(b, bsz, bmax, &p->filesz, sizeof(size_t));
for (i = 0; i < p->filesz; i++) {
io_str_buffer(b, bsz, bmax, p->files[i].file);
io_simple_buffer(b, bsz, bmax,
p->files[i].hash, SHA256_DIGEST_LENGTH);
}
io_str_buffer(b, bsz, bmax, p->aki);
io_str_buffer(b, bsz, bmax, p->ski);
}
/*
* Read an MFT structure from the file descriptor.
* Result must be passed to mft_free().
*/
struct mft *
mft_read(int fd)
{
struct mft *p = NULL;
size_t i;
if ((p = calloc(1, sizeof(struct mft))) == NULL)
err(EXIT_FAILURE, NULL);
io_simple_read(fd, &p->stale, sizeof(int));
io_str_read(fd, &p->file);
io_simple_read(fd, &p->filesz, sizeof(size_t));
if ((p->files = calloc(p->filesz, sizeof(struct mftfile))) == NULL)
err(EXIT_FAILURE, NULL);
for (i = 0; i < p->filesz; i++) {
io_str_read(fd, &p->files[i].file);
io_simple_read(fd, p->files[i].hash, SHA256_DIGEST_LENGTH);
}
io_str_read(fd, &p->aki);
io_str_read(fd, &p->ski);
return p;
}
|