1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
|
/* $OpenBSD: priv.c,v 1.7 2017/04/19 15:38:32 reyk Exp $ */
/*
* Copyright (c) 2016 Reyk Floeter <reyk@openbsd.org>
*
* Permission to use, copy, modify, and distribute this software for any
* purpose with or without fee is hereby granted, provided that the above
* copyright notice and this permission notice appear in all copies.
*
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
#include <sys/param.h> /* nitems */
#include <sys/queue.h>
#include <sys/stat.h>
#include <sys/socket.h>
#include <sys/un.h>
#include <sys/ioctl.h>
#include <sys/tree.h>
#include <net/if.h>
#include <netinet/in.h>
#include <netinet/if_ether.h>
#include <net/if_bridge.h>
#include <arpa/inet.h>
#include <errno.h>
#include <event.h>
#include <fcntl.h>
#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#include <unistd.h>
#include <signal.h>
#include <ctype.h>
#include "proc.h"
#include "vmd.h"
int priv_dispatch_parent(int, struct privsep_proc *, struct imsg *);
void priv_run(struct privsep *, struct privsep_proc *, void *);
static struct privsep_proc procs[] = {
{ "parent", PROC_PARENT, priv_dispatch_parent }
};
void
priv(struct privsep *ps, struct privsep_proc *p)
{
proc_run(ps, p, procs, nitems(procs), priv_run, NULL);
}
void
priv_run(struct privsep *ps, struct privsep_proc *p, void *arg)
{
struct vmd *env = ps->ps_env;
/*
* no pledge(2) in the "priv" process:
* write ioctls are not permitted by pledge.
*/
/* Open our own socket for generic interface ioctls */
if ((env->vmd_fd = socket(AF_INET, SOCK_DGRAM, 0)) == -1)
fatal("socket");
}
int
priv_dispatch_parent(int fd, struct privsep_proc *p, struct imsg *imsg)
{
const char *desct[] = { "tap", "switch", "bridge", NULL };
struct privsep *ps = p->p_ps;
struct vmop_ifreq vfr;
struct vmd *env = ps->ps_env;
struct ifreq ifr;
struct ifbreq ifbr;
struct ifgroupreq ifgr;
struct ifaliasreq ifra;
char type[IF_NAMESIZE];
switch (imsg->hdr.type) {
case IMSG_VMDOP_PRIV_IFDESCR:
case IMSG_VMDOP_PRIV_IFCREATE:
case IMSG_VMDOP_PRIV_IFADD:
case IMSG_VMDOP_PRIV_IFUP:
case IMSG_VMDOP_PRIV_IFDOWN:
case IMSG_VMDOP_PRIV_IFGROUP:
case IMSG_VMDOP_PRIV_IFADDR:
IMSG_SIZE_CHECK(imsg, &vfr);
memcpy(&vfr, imsg->data, sizeof(vfr));
/* We should not get malicious requests from the parent */
if (priv_getiftype(vfr.vfr_name, type, NULL) == -1 ||
priv_findname(type, desct) == -1)
fatalx("%s: rejected priv operation on interface: %s",
__func__, vfr.vfr_name);
break;
default:
return (-1);
}
switch (imsg->hdr.type) {
case IMSG_VMDOP_PRIV_IFDESCR:
/* Set the interface description */
strlcpy(ifr.ifr_name, vfr.vfr_name, sizeof(ifr.ifr_name));
ifr.ifr_data = (caddr_t)vfr.vfr_value;
if (ioctl(env->vmd_fd, SIOCSIFDESCR, &ifr) < 0)
log_warn("SIOCSIFDESCR");
break;
case IMSG_VMDOP_PRIV_IFCREATE:
/* Create the bridge if it doesn't exist */
strlcpy(ifr.ifr_name, vfr.vfr_name, sizeof(ifr.ifr_name));
if (ioctl(env->vmd_fd, SIOCIFCREATE, &ifr) < 0 &&
errno != EEXIST)
log_warn("SIOCIFCREATE");
break;
case IMSG_VMDOP_PRIV_IFADD:
if (priv_getiftype(vfr.vfr_value, type, NULL) == -1)
fatalx("%s: rejected to add interface: %s",
__func__, vfr.vfr_value);
/* Attach the device to the bridge */
strlcpy(ifbr.ifbr_name, vfr.vfr_name,
sizeof(ifbr.ifbr_name));
strlcpy(ifbr.ifbr_ifsname, vfr.vfr_value,
sizeof(ifbr.ifbr_ifsname));
if (ioctl(env->vmd_fd, SIOCBRDGADD, &ifbr) < 0 &&
errno != EEXIST)
log_warn("SIOCBRDGADD");
break;
case IMSG_VMDOP_PRIV_IFUP:
case IMSG_VMDOP_PRIV_IFDOWN:
/* Set the interface status */
strlcpy(ifr.ifr_name, vfr.vfr_name, sizeof(ifr.ifr_name));
if (ioctl(env->vmd_fd, SIOCGIFFLAGS, &ifr) < 0) {
log_warn("SIOCGIFFLAGS");
break;
}
if (imsg->hdr.type == IMSG_VMDOP_PRIV_IFUP)
ifr.ifr_flags |= IFF_UP;
else
ifr.ifr_flags &= ~IFF_UP;
if (ioctl(env->vmd_fd, SIOCSIFFLAGS, &ifr) < 0)
log_warn("SIOCSIFFLAGS");
break;
case IMSG_VMDOP_PRIV_IFGROUP:
if (priv_validgroup(vfr.vfr_value) == -1)
fatalx("%s: invalid group name", __func__);
if (strlcpy(ifgr.ifgr_name, vfr.vfr_name,
sizeof(ifgr.ifgr_name)) >= sizeof(ifgr.ifgr_name) ||
strlcpy(ifgr.ifgr_group, vfr.vfr_value,
sizeof(ifgr.ifgr_group)) >= sizeof(ifgr.ifgr_group))
fatalx("%s: group name too long", __func__);
if (ioctl(env->vmd_fd, SIOCAIFGROUP, &ifgr) < 0 &&
errno != EEXIST)
log_warn("SIOCAIFGROUP");
break;
case IMSG_VMDOP_PRIV_IFADDR:
memset(&ifra, 0, sizeof(ifra));
/* Set the interface address */
strlcpy(ifra.ifra_name, vfr.vfr_name, sizeof(ifra.ifra_name));
memcpy(&ifra.ifra_addr, &vfr.vfr_ifra.ifra_addr,
sizeof(ifra.ifra_addr));
ifra.ifra_addr.sa_family = AF_INET;
ifra.ifra_addr.sa_len = sizeof(struct sockaddr_in);
memcpy(&ifra.ifra_mask, &vfr.vfr_ifra.ifra_mask,
sizeof(ifra.ifra_mask));
ifra.ifra_mask.sa_family = AF_INET;
ifra.ifra_mask.sa_len = sizeof(struct sockaddr_in);
if (ioctl(env->vmd_fd, SIOCAIFADDR, &ifra) < 0)
log_warn("SIOCAIFADDR");
break;
default:
return (-1);
}
return (0);
}
int
priv_getiftype(char *ifname, char *type, unsigned int *unitptr)
{
const char *errstr;
size_t span;
unsigned int unit;
/* Extract the name part */
span = strcspn(ifname, "0123456789");
if (span == 0 || span >= strlen(ifname) || span >= (IF_NAMESIZE - 1))
return (-1);
memcpy(type, ifname, span);
type[span] = 0;
/* Now parse the unit (we don't strictly validate the format here) */
unit = strtonum(ifname + span, 0, UINT_MAX, &errstr);
if (errstr != NULL)
return (-1);
if (unitptr != NULL)
*unitptr = unit;
return (0);
}
int
priv_findname(const char *name, const char **names)
{
unsigned int i;
for (i = 0; names[i] != NULL; i++) {
if (strcmp(name, names[i]) == 0)
return (0);
}
return (-1);
}
int
priv_validgroup(const char *name)
{
if (strlen(name) >= IF_NAMESIZE)
return (-1);
/* Group can not end with a digit */
if (name[0] && isdigit(name[strlen(name) - 1]))
return (-1);
return (0);
}
/*
* Called from the process peer
*/
int
vm_priv_ifconfig(struct privsep *ps, struct vmd_vm *vm)
{
struct vm_create_params *vcp = &vm->vm_params.vmc_params;
struct vmd_if *vif;
struct vmd_switch *vsw;
unsigned int i;
struct vmop_ifreq vfr, vfbr;
struct sockaddr_in *sin4;
for (i = 0; i < VMM_MAX_NICS_PER_VM; i++) {
vif = &vm->vm_ifs[i];
if (vif->vif_name == NULL)
break;
if (strlcpy(vfr.vfr_name, vif->vif_name,
sizeof(vfr.vfr_name)) >= sizeof(vfr.vfr_name))
return (-1);
/* Description can be truncated */
(void)snprintf(vfr.vfr_value, sizeof(vfr.vfr_value),
"vm%u-if%u-%s", vm->vm_vmid, i, vcp->vcp_name);
log_debug("%s: interface %s description %s", __func__,
vfr.vfr_name, vfr.vfr_value);
proc_compose(ps, PROC_PRIV, IMSG_VMDOP_PRIV_IFDESCR,
&vfr, sizeof(vfr));
/* Add interface to bridge/switch */
if ((vsw = switch_getbyname(vif->vif_switch)) != NULL) {
if (strlcpy(vfbr.vfr_name, vsw->sw_ifname,
sizeof(vfbr.vfr_name)) >= sizeof(vfbr.vfr_name))
return (-1);
if (strlcpy(vfbr.vfr_value, vif->vif_name,
sizeof(vfbr.vfr_value)) >= sizeof(vfbr.vfr_value))
return (-1);
log_debug("%s: interface %s add %s", __func__,
vfbr.vfr_name, vfbr.vfr_value);
proc_compose(ps, PROC_PRIV, IMSG_VMDOP_PRIV_IFCREATE,
&vfbr, sizeof(vfbr));
proc_compose(ps, PROC_PRIV, IMSG_VMDOP_PRIV_IFADD,
&vfbr, sizeof(vfbr));
} else if (vif->vif_switch != NULL)
log_warnx("switch %s not found", vif->vif_switch);
/* First group is defined per-interface */
if (vif->vif_group) {
if (strlcpy(vfr.vfr_value, vif->vif_group,
sizeof(vfr.vfr_value)) >= sizeof(vfr.vfr_value))
return (-1);
log_debug("%s: interface %s group %s", __func__,
vfr.vfr_name, vfr.vfr_value);
proc_compose(ps, PROC_PRIV, IMSG_VMDOP_PRIV_IFGROUP,
&vfr, sizeof(vfr));
}
/* The second group is defined per-switch */
if (vsw != NULL && vsw->sw_group != NULL) {
if (strlcpy(vfr.vfr_value, vsw->sw_group,
sizeof(vfr.vfr_value)) >= sizeof(vfr.vfr_value))
return (-1);
log_debug("%s: interface %s group %s switch %s",
__func__, vfr.vfr_name, vfr.vfr_value,
vsw->sw_name);
proc_compose(ps, PROC_PRIV, IMSG_VMDOP_PRIV_IFGROUP,
&vfr, sizeof(vfr));
}
/* Set the new interface status to up or down */
proc_compose(ps, PROC_PRIV, (vif->vif_flags & VMIFF_UP) ?
IMSG_VMDOP_PRIV_IFUP : IMSG_VMDOP_PRIV_IFDOWN,
&vfr, sizeof(vfr));
if (vm->vm_params.vmc_ifflags[i] & VMIFF_LOCAL) {
sin4 = (struct sockaddr_in *)&vfr.vfr_ifra.ifra_mask;
sin4->sin_family = AF_INET;
sin4->sin_len = sizeof(*sin4);
sin4->sin_addr.s_addr = htonl(0xfffffffe);
sin4 = (struct sockaddr_in *)&vfr.vfr_ifra.ifra_addr;
sin4->sin_family = AF_INET;
sin4->sin_len = sizeof(*sin4);
if ((sin4->sin_addr.s_addr =
vm_priv_addr(vm->vm_vmid, i, 0)) == 0)
return (-1);
log_debug("%s: interface %s address %s/31",
__func__, vfr.vfr_name,
inet_ntoa(sin4->sin_addr));
proc_compose(ps, PROC_PRIV, IMSG_VMDOP_PRIV_IFADDR,
&vfr, sizeof(vfr));
}
}
return (0);
}
int
vm_priv_brconfig(struct privsep *ps, struct vmd_switch *vsw)
{
struct vmd_if *vif;
struct vmop_ifreq vfr;
if (strlcpy(vfr.vfr_name, vsw->sw_ifname,
sizeof(vfr.vfr_name)) >= sizeof(vfr.vfr_name))
return (-1);
proc_compose(ps, PROC_PRIV, IMSG_VMDOP_PRIV_IFCREATE,
&vfr, sizeof(vfr));
/* Description can be truncated */
(void)snprintf(vfr.vfr_value, sizeof(vfr.vfr_value),
"switch%u-%s", vsw->sw_id, vsw->sw_name);
log_debug("%s: interface %s description %s", __func__,
vfr.vfr_name, vfr.vfr_value);
proc_compose(ps, PROC_PRIV, IMSG_VMDOP_PRIV_IFDESCR,
&vfr, sizeof(vfr));
TAILQ_FOREACH(vif, &vsw->sw_ifs, vif_entry) {
if (strlcpy(vfr.vfr_value, vif->vif_name,
sizeof(vfr.vfr_value)) >= sizeof(vfr.vfr_value))
return (-1);
log_debug("%s: interface %s add %s", __func__,
vfr.vfr_name, vfr.vfr_value);
proc_compose(ps, PROC_PRIV, IMSG_VMDOP_PRIV_IFADD,
&vfr, sizeof(vfr));
}
/* Set the new interface status to up or down */
proc_compose(ps, PROC_PRIV, (vsw->sw_flags & VMIFF_UP) ?
IMSG_VMDOP_PRIV_IFUP : IMSG_VMDOP_PRIV_IFDOWN,
&vfr, sizeof(vfr));
vsw->sw_running = 1;
return (0);
}
uint32_t
vm_priv_addr(uint32_t vmid, int idx, int isvm)
{
in_addr_t prefix, mask, addr;
/*
* 1. Set the address prefix and mask, 100.64.0.0/10 by default.
* XXX make the global prefix configurable.
*/
prefix = inet_addr(VMD_DHCP_PREFIX);
mask = prefixlen2mask(VMD_DHCP_PREFIXLEN);
/* 2. Encode the VM ID as a per-VM subnet range N, 10.64.N.0/24. */
addr = vmid << 8;
/*
* 3. Assign a /31 subnet M per VM interface, 10.64.N.M/31.
* Each subnet contains exactly two IP addresses; skip the
* first subnet to avoid a gateway address ending with .0.
*/
addr |= (idx + 1) * 2;
/* 4. Use the first address for the gateway, the second for the VM. */
if (isvm)
addr++;
/* 5. Convert to network byte order and add the prefix. */
addr = htonl(addr) | prefix;
/*
* Validate the results:
* - the address should not exceed the prefix (eg. VM ID to high).
* - up to 126 interfaces can be encoded per VM.
*/
if (prefix != (addr & mask) || idx >= 0x7f) {
log_warnx("%s: dhcp address range exceeded,"
" vm id %u interface %d", __func__, vmid, idx);
return (0);
}
return (addr);
}
|