summaryrefslogtreecommitdiff
path: root/app
diff options
context:
space:
mode:
Diffstat (limited to 'app')
-rw-r--r--app/cwm/calmwm.h7
-rw-r--r--app/cwm/conf.c7
-rw-r--r--app/cwm/menu.c41
3 files changed, 25 insertions, 30 deletions
diff --git a/app/cwm/calmwm.h b/app/cwm/calmwm.h
index 8681675b8..c33783540 100644
--- a/app/cwm/calmwm.h
+++ b/app/cwm/calmwm.h
@@ -15,7 +15,7 @@
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*
- * $OpenBSD: calmwm.h,v 1.320 2016/10/03 14:42:34 okan Exp $
+ * $OpenBSD: calmwm.h,v 1.321 2016/10/03 18:43:49 okan Exp $
*/
#ifndef _CALMWM_H_
@@ -96,11 +96,10 @@ union press {
};
enum cursor_font {
- CF_DEFAULT,
- CF_MOVE,
CF_NORMAL,
- CF_QUESTION,
+ CF_MOVE,
CF_RESIZE,
+ CF_QUESTION,
CF_NITEMS
};
enum color {
diff --git a/app/cwm/conf.c b/app/cwm/conf.c
index 84430090e..b62e20865 100644
--- a/app/cwm/conf.c
+++ b/app/cwm/conf.c
@@ -15,7 +15,7 @@
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*
- * $OpenBSD: conf.c,v 1.209 2016/10/03 14:42:34 okan Exp $
+ * $OpenBSD: conf.c,v 1.210 2016/10/03 18:43:49 okan Exp $
*/
#include <sys/types.h>
@@ -640,11 +640,10 @@ conf_unbind_mouse(struct conf *c, struct binding *unbind)
}
static int cursor_binds[] = {
- XC_X_cursor, /* CF_DEFAULT */
- XC_fleur, /* CF_MOVE */
XC_left_ptr, /* CF_NORMAL */
- XC_question_arrow, /* CF_QUESTION */
+ XC_fleur, /* CF_MOVE */
XC_bottom_right_corner, /* CF_RESIZE */
+ XC_question_arrow, /* CF_QUESTION */
};
void
diff --git a/app/cwm/menu.c b/app/cwm/menu.c
index 39c51ede0..f1abe1205 100644
--- a/app/cwm/menu.c
+++ b/app/cwm/menu.c
@@ -16,7 +16,7 @@
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*
- * $OpenBSD: menu.c,v 1.96 2016/09/30 18:28:06 okan Exp $
+ * $OpenBSD: menu.c,v 1.97 2016/10/03 18:43:49 okan Exp $
*/
#include <sys/types.h>
@@ -63,10 +63,10 @@ struct menu_ctx {
};
static struct menu *menu_handle_key(XEvent *, struct menu_ctx *,
struct menu_q *, struct menu_q *);
-static void menu_handle_move(XEvent *, struct menu_ctx *,
- struct menu_q *);
-static struct menu *menu_handle_release(XEvent *, struct menu_ctx *,
- struct menu_q *);
+static void menu_handle_move(struct menu_ctx *,
+ struct menu_q *, int, int);
+static struct menu *menu_handle_release(struct menu_ctx *,
+ struct menu_q *, int, int);
static void menu_draw(struct menu_ctx *, struct menu_q *,
struct menu_q *);
static void menu_draw_entry(struct menu_ctx *, struct menu_q *,
@@ -151,11 +151,12 @@ menu_filter(struct screen_ctx *sc, struct menu_q *menuq, const char *prompt,
menu_draw(&mc, menuq, &resultq);
break;
case MotionNotify:
- menu_handle_move(&e, &mc, &resultq);
+ menu_handle_move(&mc, &resultq,
+ e.xbutton.x, e.xbutton.y);
break;
case ButtonRelease:
- if ((mi = menu_handle_release(&e, &mc, &resultq))
- != NULL)
+ if ((mi = menu_handle_release(&mc, &resultq,
+ e.xbutton.x, e.xbutton.y)) != NULL)
goto out;
break;
default:
@@ -408,14 +409,14 @@ menu_draw(struct menu_ctx *mc, struct menu_q *menuq, struct menu_q *resultq)
XMoveResizeWindow(X_Dpy, sc->menu.win, mc->geom.x, mc->geom.y,
mc->geom.w, mc->geom.h);
+ n = 0;
if (mc->hasprompt) {
XftDrawStringUtf8(sc->menu.xftdraw,
&sc->xftcolor[CWM_COLOR_MENU_FONT], sc->xftfont,
0, sc->xftfont->ascent,
(const FcChar8*)mc->dispstr, strlen(mc->dispstr));
- n = 1;
- } else
- n = 0;
+ n++;
+ }
TAILQ_FOREACH(mi, resultq, resultentry) {
int y = n * (sc->xftfont->height + 1) + sc->xftfont->ascent + 1;
@@ -463,10 +464,10 @@ menu_draw_entry(struct menu_ctx *mc, struct menu_q *resultq,
}
static void
-menu_handle_move(XEvent *e, struct menu_ctx *mc, struct menu_q *resultq)
+menu_handle_move(struct menu_ctx *mc, struct menu_q *resultq, int x, int y)
{
mc->prev = mc->entry;
- mc->entry = menu_calc_entry(mc, e->xbutton.x, e->xbutton.y);
+ mc->entry = menu_calc_entry(mc, x, y);
if (mc->prev == mc->entry)
return;
@@ -477,19 +478,16 @@ menu_handle_move(XEvent *e, struct menu_ctx *mc, struct menu_q *resultq)
XChangeActivePointerGrab(X_Dpy, MENUGRABMASK,
Conf.cursor[CF_NORMAL], CurrentTime);
menu_draw_entry(mc, resultq, mc->entry, 1);
- } else {
- XChangeActivePointerGrab(X_Dpy, MENUGRABMASK,
- Conf.cursor[CF_DEFAULT], CurrentTime);
}
}
static struct menu *
-menu_handle_release(XEvent *e, struct menu_ctx *mc, struct menu_q *resultq)
+menu_handle_release(struct menu_ctx *mc, struct menu_q *resultq, int x, int y)
{
struct menu *mi;
int entry, i = 0;
- entry = menu_calc_entry(mc, e->xbutton.x, e->xbutton.y);
+ entry = menu_calc_entry(mc, x, y);
if (mc->hasprompt)
i = 1;
@@ -529,13 +527,12 @@ static int
menu_keycode(XKeyEvent *ev, enum ctltype *ctl, char *chr)
{
KeySym ks;
- unsigned int state = ev->state;
*ctl = CTL_NONE;
chr[0] = '\0';
ks = XkbKeycodeToKeysym(X_Dpy, ev->keycode, 0,
- (state & ShiftMask) ? 1 : 0);
+ (ev->state & ShiftMask) ? 1 : 0);
/* Look for control characters. */
switch (ks) {
@@ -560,7 +557,7 @@ menu_keycode(XKeyEvent *ev, enum ctltype *ctl, char *chr)
break;
}
- if (*ctl == CTL_NONE && (state & ControlMask)) {
+ if (*ctl == CTL_NONE && (ev->state & ControlMask)) {
switch (ks) {
case XK_s:
case XK_S:
@@ -590,7 +587,7 @@ menu_keycode(XKeyEvent *ev, enum ctltype *ctl, char *chr)
}
}
- if (*ctl == CTL_NONE && (state & Mod1Mask)) {
+ if (*ctl == CTL_NONE && (ev->state & Mod1Mask)) {
switch (ks) {
case XK_j:
case XK_J: