summaryrefslogtreecommitdiff
path: root/app/cwm/client.c
AgeCommit message (Collapse)Author
2014-02-06Some clients set the urgency flag even if they are the active client;Okan Demirmen
prevent annoying behavior by only setting the cwm urgency flag if the client is not active; diff from Thomas Adam.
2014-02-03Move redundant bits from screen_init (while dealing with existingOkan Demirmen
clients) directly into client_init, performing the X roundtrip only once. With the previous change in maprequest, this moves decision making into one place for creating new clients.
2014-02-02Move redundant window attr fetch from maprequest directly intoOkan Demirmen
client_init and perform that X roundtrip only once.
2014-01-27move some init up and shed some blank linesOkan Demirmen
2014-01-03state is longOkan Demirmen
2014-01-02rename for clarityOkan Demirmen
2014-01-02When a client doesn't specify size hints, nothing prevents a resize toOkan Demirmen
0x0 - don't allow this situation during mouse resize (check already in place for kbd resize). Reported by brynet@
2013-12-17replace with memsetOkan Demirmen
2013-12-16Implement support for EWMH's _NET_WM_STATE_FULLSCREEN hint.Okan Demirmen
Since we already have a form of 'maximize', we need to differentiate between 'maximize' and the new 'fullscreen' mode. The 'maximize' mode will continue to honor gap but now *retains* the border, matching the 'vert/horz maximize' behaviour. The new 'fullscreen' mode supports and follows the _NET_WM_STATE_FULLSCREEN hint, allowing the client perform additional window modifications; in this mode, cwm(1) will *ignore* gap, remove borders and freeze(move/resize) the client. Additionally, 'fullscreen' mode will remember various combinations of previous states. * default keybinding changes: CM-f 'fullscreen', CM-m 'maximize' (re-map as desired). Positive feedback from a few, testing and ok sthen@
2013-12-13Teach screen_find_xinerama() to apply gap only when told to do so;Okan Demirmen
adjust callers. Needed for an upcoming feature.
2013-12-13we need the save-set when re-exec'ing so as to not lose State on our hidden ↵Okan Demirmen
clients
2013-12-13Add support for XUrgency and matching _NET_WM_STATE_DEMANDS_ATTENTIONOkan Demirmen
ewmh hint; urgencyborder is configurable. The urgency flag will stick, even while on a client in a non-viewable group, until the client receives focus (where the border is reset). Initial diff from Thomas Adam with some changes/enhancements from me.
2013-12-12ICCCM explicitly states that server time (CurrentTime) should *not* beOkan Demirmen
used for focus events, but rather the timestamp of the generated event. Track the last event timestamp and send it down for a WM_TAKE_FOCUS ClientMessage. I suspect we should do this for clients that don't announce this Atom as well, though the raciness gets us into a bind. Solves focus order issue since WM_TAKE_FOCUS; fix verified by sthen@ ok sthen@
2013-12-11we don't need to manage the save-set since we're not reparenting; left-over ↵Okan Demirmen
from pwin
2013-12-11since we are drawing in unhide, no need to during client setupOkan Demirmen
2013-12-11apply mwm hints laterOkan Demirmen
2013-12-11Add client wrapper for XWMHints to support XA_WM_HINTS in PropertyNotifyOkan Demirmen
events; based off a diff from Thomas Adam.
2013-12-11Remove extra work and simplify client state handling.Okan Demirmen
2013-12-11Stash Class and WM Hints in client_ctxOkan Demirmen
2013-12-10Redraw client border when unhiding; during a hide, we just unsetOkan Demirmen
the active flag but never redraw since it'll be in IconicState. Behaviour reported by sthen@
2013-11-27alter -r1.145 getsizehints to deal with clients that don't haveOkan Demirmen
WM_NORMAL_HINTS.
2013-11-27simplify/unfoldOkan Demirmen
2013-11-27Rewrite active/inactive client handling in client_setactive();Okan Demirmen
client_leave() served no real purpose, likewise no reason to handle LeaveNotify events since an EnterNotify will process the next active client (and we don't have anything important to process anyway), so xev_handle_leavenotify() goes as well. Allows a simplification of client_mtf() and client_cycle_leave() for clarity. While here, unify a few client_current() checks. No intended behaviour change.
2013-11-12Alter the r1.35 of event.c race fix. Remove the forward looking eventOkan Demirmen
queue check (removing the need for a server grab/ungrab) - if the client is going away, let it fall all the way through to a DestroyNotify event. There's no longer a need for us to manually destroy a client ourselves (removing yet another server grab/ungrab). Instead, when the UnmapNotify event is synthetic, simply set the state to Withdrawn (as per ICCCM), else Iconic (in our case 'hidden'). Verified with test case from the 2009 race which was the original reason for r1.35 of event.c.
2013-11-11Put back the border draw call in client_resize; since we are adding andOkan Demirmen
removing the border on maximized clients we need to redraw. Also noticed by Tim van der Molen
2013-11-08stash WMProtocols in flagsOkan Demirmen
2013-11-05quick keyboard focus fix for clients that neither populate wmhints nor ↵Okan Demirmen
wmprotocols, like rdesktop; focus needs to be re-visited
2013-11-02The only reason we need to keep XSizeHints in our client_ctx is forOkan Demirmen
flags, so just add one to hints; consolidates sizehints and shrinks. Additionally don't abuse PSize for XGetWMNormalHints() failures.
2013-11-01x/y from XSizeHints are obsolete (and have been for a long time), soOkan Demirmen
instead use x/y from XWindowAttributes when USPosition|PPosition are set.
2013-11-01re-add support for WM_TAKE_FOCUS, and additionally this time only callOkan Demirmen
XSetInputFocus() for clients that have the InputHint; latter fix discovered by Valery Masiutsin with a PoC patch - solves keyboard input focus loss for java apps.
2013-10-25A client_delete should behave differently depending on whether theOkan Demirmen
triggering event was unmap (with pending destroy) log destroy; we only need to grab/ungrab the server lock, set WithdrawnState and XRemoveFromSaveSet clients coming from an unmap event - doing so for clients coming from destroy are already gone, hence we generate errors.
2013-10-20revert 1.138 (WM_TAKE_FOCUS) for nowOkan Demirmen
2013-10-19Using xu_btn_ungrab() buttons during client_leave doesn't work (errorOkan Demirmen
BadValue) when the modifier is already AnyModifier . Instead alter xu_btn_ungrab() to ungrab AnyButton/AnyModifier and call it only when a client is coming into focus in client_setactive(), instead of iterating over ignore mods - matches how we handle key grabs.
2013-10-19I believe we redraw the border in too many cases; likely a leftover fromOkan Demirmen
the cc->pwin days - don't redraw on every unhide, resize, and mouse move/resize Expose event (note, all Expose events trigger a redraw anyway). Tested with some finicky X apps I could think of, though I'm sure others will find more - if so, and they 'lose' the border, please report!
2013-10-19For clients that support WM_TAKE_FOCUS in their WM_PROTOCOLS property, sendOkan Demirmen
a ClientMessage event.
2013-10-03unify type; no changeOkan Demirmen
2013-07-15collapse linesOkan Demirmen
2013-07-15simplify atom handling; allows us to limit to one round-trip to serverOkan Demirmen
for gathering Atoms.
2013-06-10move synthetic responses and have client_msg only work with WM_PROTOCOLS,Okan Demirmen
since that's all ClientMessageEvent is for anyway.
2013-05-23alter conf_grab(_kbd) to first ungrab AnyKey/AnyModifier, then proceedOkan Demirmen
to grab keys in keybindingq. we don't need to ungrab/grab on every addition to the queue, just once with a complete keybindingq; simplify grabbing keys per screen (during init) and during a MappingNotify. while here, change conf_grab_{kbd,mouse} to require only a Window.
2013-05-20add support for _NET_WM_STATE_MAXIMIZED_{HORZ,VERT}; from Alexander Polakov.Okan Demirmen
while I'm unsure of the final look of _NET_WM_STATE, there's no reason to delay this support.
2013-05-19- switch border colors to XftOkan Demirmen
- merge border/menu color structures/functions since they now both use Xft - switch xu_xorcolor to operating on XftColor instead of just XRenderColor (basically adding pixel) - if color name allocation fails, revert back to default (this, along with font validation should occur during config parse, but we don't have screens setup yet - likely to change at some point)
2013-05-19use XGetWMProtocols and simplify WM_PROTOCOL handlingOkan Demirmen
2013-05-11new -> initOkan Demirmen
2013-05-06remove group in client_delete directly.Okan Demirmen
2013-04-17mechanical xu_{get,set}state -> xu_{get,set}_wm_state changeOkan Demirmen
2013-04-17slightly rework WM_STATE set/get to make it less ambigious; will be more clearOkan Demirmen
on what needs to change to make it right in the end.
2013-04-14only a window is required to set WM_STATE. also un-confuse xu_ptr_getposOkan Demirmen
by using 'win' instead of 'rootwin' so as not to imply only the root window is queried, rather any window.
2013-04-12we handle WM_STATE here, so remove misleading comment.Okan Demirmen
2013-04-12we already set window state in client_hide or client_unhide right before, soOkan Demirmen
there's no need to do it again.