Age | Commit message (Collapse) | Author |
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
missing const causes 'conflicting type' error at initialisation
and aborted compilation.
|
|
widgets.c: In function ‘CreateResourceBoxWidgets’:
widgets.c:473:18: warning: declaration of ‘box’ shadows a global declaration [-Wshadow]
Widget pane, box, button, viewport, pane_child;
rename box to rbox
|
|
FIX warnings like:
initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
{"debug", "Debug", XtRBoolean, sizeof(Boolean),
|
|
fix passing argument 1 of ‘RebuildMenusAndLabel’ discards ‘const’ qualifier
from pointer target type
only user is in comm.c
|
|
most warnings occur because XtSetArg() needs (String) aka char *
and the "string" is const char * these days.
|
|
The warning occurs because XtSetArg() needs (String) aka char *
and the "string" is const char * these days.
|
|
The warning occurs because XtSetArg() needs (String) aka char *
and the "string" is const char * these days.
|
|
The warning occurs because XtSetArg() needs (String) aka char *
and the "string" is const char * these days.
|
|
make type const char * to avoid warning
|
|
getting a bunch of warnings make i had to see the import ones.
So reduce the warnings by adding a few "const" no problem
for internals. For externals function add some casts.
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Enabled by default, use ./configure --without-xkb to disable.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Makes sure that any flags set in config.h that affect system headers
are applied equally across all source files.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Found by using:
codespell --builtin clear,rare,usage,informal,code,names
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
widgets.c:817:28: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
comm.c:55:15: warning: redundant redeclaration of ‘CM_entries’ [-Wredundant-decls]
extern Widget CM_entries[NUM_CM_ENTRIES], TM_entries[NUM_TM_ENTRIES];
^~~~~~~~~~
In file included from comm.c:46:0:
editresP.h:339:15: note: previous declaration of ‘CM_entries’ was here
extern Widget CM_entries[NUM_CM_ENTRIES];
^~~~~~~~~~
comm.c:55:43: warning: redundant redeclaration of ‘TM_entries’ [-Wredundant-decls]
extern Widget CM_entries[NUM_CM_ENTRIES], TM_entries[NUM_TM_ENTRIES];
^~~~~~~~~~
In file included from comm.c:46:0:
editresP.h:343:15: note: previous declaration of ‘TM_entries’ was here
extern Widget TM_entries[NUM_TM_ENTRIES];
^~~~~~~~~~
handler.c:502:16: warning: redundant redeclaration of ‘do_get_values’ [-Wredundant-decls]
extern Boolean do_get_values;
^~~~~~~~~~~~~
In file included from handler.c:40:0:
editresP.h:334:16: note: previous declaration of ‘do_get_values’ was here
extern Boolean do_get_values;
^~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Depends on building with a libXt version that defines String as a
const char * if _CONST_X_STRING is defined.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
|
|
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
|
|
Mostly copied from editres man page
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
editres.c:140:1: warning: function 'Syntax' could be declared with
attribute 'noreturn' [-Wmissing-noreturn]
handler.c:65:1: warning: function 'Quit' could be declared with
attribute 'noreturn' [-Wmissing-noreturn]
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
'git diff -w' shows no changes for this commit
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
actions.c:291:21: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for ( i = 0 ; i < num_table; i++ )
~ ^ ~~~~~~~~~
actions.c:299:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < num_table; ) {
~ ^ ~~~~~~~~~
actions.c:302:8: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
if (i == (num_table - 1))
~ ^ ~~~~~~~~~~~~~
actions.c:304:13: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
else if (i < num_table)
~ ^ ~~~~~~~~~
geometry.c:150:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < tree_info->num_nodes; i++)
~ ^ ~~~~~~~~~~~~~~~~~~~~
geometry.c:380:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < tree_info->num_flash_widgets; i++) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
geometry.c:401:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < tree_info->num_flash_widgets; i++)
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
geometry.c:423:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < tree_info->num_flash_widgets; i++)
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
geometry.c:428:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < tree_info->num_flash_widgets; i++)
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
handler.c:475:13: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
if (len > malloc_size) {
~~~ ^ ~~~~~~~~~~~
handler.c:476:58: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
malloc_string = XtRealloc(malloc_string, sizeof(char) * len);
~ ^~~
handler.c:477:16: warning: implicit conversion changes signedness: 'int' to 'Cardinal' (aka 'unsigned int') [-Wsign-conversion]
malloc_size = len;
~ ^~~
utils.c:167:37: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (node = top_node, i = 1 ; i < number; i++) {
~ ^ ~~~~~~
utils.c:170:16: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (j = 0; j < node->num_children; j++) {
~ ^ ~~~~~~~~~~~~~~~~~~
utils.c:215:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < node->num_children; i++) {
~ ^ ~~~~~~~~~~~~~~~~~~
utils.c:787:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < top_node->num_children; i++)
~ ^ ~~~~~~~~~~~~~~~~~~~~~~
wtree.c:129:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < top->num_children; i++)
~ ^ ~~~~~~~~~~~~~~~~~
wtree.c:194:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < info->num_nodes; i++) {
~ ^ ~~~~~~~~~~~~~~~
wtree.c:216:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < info->num_nodes; i++)
~ ^ ~~~~~~~~~~~~~~~
wtree.c:270:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < top->num_children; i++)
~ ^ ~~~~~~~~~~~~~~~~~
wtree.c:339:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < num_active_nodes; i++)
~ ^ ~~~~~~~~~~~~~~~~
wtree.c:386:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < node->num_children; i++)
~ ^ ~~~~~~~~~~~~~~~~~~
wtree.c:446:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < node->num_children; i++)
~ ^ ~~~~~~~~~~~~~~~~~~
wtree.c:478:16: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < node->num_children; i++) {
~ ^ ~~~~~~~~~~~~~~~~~~
wtree.c:607:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < tree_info->num_nodes; i++)
~ ^ ~~~~~~~~~~~~~~~~~~~~
wtree.c:686:19: warning: comparison of integers of different signs: 'int' and 'Cardinal' (aka 'unsigned int') [-Wsign-compare]
for (i = 0; i < node->num_children; i++)
~ ^ ~~~~~~~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Raises required version of libXt to >= 1.0.99.1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
See http://people.gnome.org/~walters/docs/build-api.txt
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
|
|
Regroup AC statements under the Autoconf initialization section.
Regroup AM statements under the Automake initialization section.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Use services provided by XORG_MANPAGE_SECTIONS.
Use standard Makefile for man pages.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Using s/[ \t]*$//
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
This silences an Autoconf warning
|
|
This silences an Automake warning.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
AC_PROG_CC & AC_PROG_INSTALL are provided by XORG_DEFAULT_OPTIONS now
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Use MAN_SUBST now supplied in XORG_MANPAGE_SECTIONS
The value of MAN_SUBST is the same for all X.Org packages.
Use AC_PROG_SED now supplied by XORG_DEFAULT_OPTIONS
The existing statement can now be removed from the configuration file.
Use automake provided $(AM_V_GEN) and XORG_DEFAULT_OPTIONS provided $(SED)
Enables silent rule and use platform appropriate version of sed.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Unrelated to the previous patches, the new value simply reflects
the reality that the minimum level for autoconf to configure
all x.org modules is 2.60 dated June 2006.
ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|