diff options
| author | Matthieu Herrb <matthieu@cvs.openbsd.org> | 2016-10-23 11:31:43 +0000 |
|---|---|---|
| committer | Matthieu Herrb <matthieu@herrb.eu> | 2020-07-14 15:52:34 +0200 |
| commit | 0712edeea562fb3f1b59685f86eb9cbceb0bc7d0 (patch) | |
| tree | 70658e82c71ae8fb881bd50113c939c5630aaa8c | |
| parent | c03402500a87daef49057544b55fc70301f25053 (diff) | |
Use explicit_bzero() to wipe the password
| -rw-r--r-- | greeter/verify.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/greeter/verify.c b/greeter/verify.c index 58e765b..a2951ab 100644 --- a/greeter/verify.c +++ b/greeter/verify.c @@ -98,30 +98,30 @@ Verify (struct display *d, struct greet_info *greet, struct verify_info *verify) if (!p || strlen (greet->name) == 0) { Debug("getpwnam() failed.\n"); - bzero(greet->password, strlen(greet->password)); + explicit_bzero(greet->password, strlen(greet->password)); return 0; } if ((lc = login_getclass(p->pw_class)) == NULL) { Debug("login_getclass() failed.\n"); - bzero(greet->password, strlen(greet->password)); + explicit_bzero(greet->password, strlen(greet->password)); return 0; } if ((style = login_getstyle(lc, style, "xdm")) == NULL) { Debug("login_getstyle() failed.\n"); - bzero(greet->password, strlen(greet->password)); + explicit_bzero(greet->password, strlen(greet->password)); return 0; } if ((as = auth_open()) == NULL) { Debug("auth_open() failed.\n"); login_close(lc); - bzero(greet->password, strlen(greet->password)); + explicit_bzero(greet->password, strlen(greet->password)); return 0; } if (auth_setoption(as, "login", "yes") == -1) { Debug("auth_setoption() failed.\n"); login_close(lc); - bzero(greet->password, strlen(greet->password)); + explicit_bzero(greet->password, strlen(greet->password)); return 0; } passwd_len = strlen(greet->password); @@ -130,7 +130,7 @@ Verify (struct display *d, struct greet_info *greet, struct verify_info *verify) auth_setdata(as, "", 1); auth_setdata(as, greet->password, passwd_len + 1); /* wipe password now, otherwise it'll be copied fork() in auth_call */ - bzero(greet->password, passwd_len); + explicit_bzero(greet->password, passwd_len); /* Build path of the auth script and call it */ snprintf(path, sizeof(path), _PATH_AUTHPROG "%s", style); auth_call(as, path, style, "-s", "response", greet->name, |