Age | Commit message (Collapse) | Author |
|
|
|
It has been required since Unix98/SUSv2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/app/xmodmap/-/merge_requests/6>
|
|
Oracle no longer includes this term in our copyright & license notices.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Resolves issue reported by Oracle Parfait static analyzer:
Error: Memory leak
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer pointer allocated with XGetKeyboardMapping(...)
at line 251 of app/xmodmap/exec.c in function 'PrintModifierMapping'.
pointer allocated at line 222 with XGetKeyboardMapping(...)
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Resolves issues reported by Oracle Parfait static analyzer:
Error: Memory leak
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer kclist allocated with malloc((n * 1))
at line 698 of app/xmodmap/handle.c in function 'do_remove'.
kclist allocated at line 662 with malloc((n * 1))
kclist leaks when num_kcs != 0 at line 676
and (j + 1) >= num_kcs at line 687
and (nc + num_kcs) > tot at line 691
and (num_kcs - 1) < 0 at line 701.
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer kclist allocated with malloc((n * 1))
at line 711 of app/xmodmap/handle.c in function 'do_remove'.
kclist allocated at line 662 with malloc((n * 1))
kclist leaks when (i + 1) >= n at line 672.
Error: Memory leak
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer kclist allocated with realloc(kclist, (tot * 1))
at line 711 of app/xmodmap/handle.c in function 'do_remove'.
kclist allocated at line 693 with realloc(kclist, (tot * 1))
kclist leaks when (num_kcs - 1) < 0 at line 701
and (i + 1) >= n at line 672.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Change a warning to distinguish between too few buttons and too many.
Before this change:
$ xmodmap -e "pointer = 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15"
Warning: Only changing the first 15 of 10 buttons.
$
After this change:
$ xmodmap -e "pointer = 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15"
Warning: Not changing 5 extra buttons beyond 10.
$
Fixes: https://gitlab.freedesktop.org/xorg/app/xmodmap/issues/2
Signed-off-by: Karl Fogel <kfogel@red-bean.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
The XKeysymDB was removed around 2010 - please see:
https://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=eb023c0f8919e809b8b609e1467b14d20a290aa7
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Needs to match one of the regexps shown under
https://gcc.gnu.org/onlinedocs/gcc-7.3.0/gcc/Warning-Options.html#index-Wimplicit-fallthrough
Silences warning from gcc 7.3.0:
xmodmap.c: In function ‘main’:
xmodmap.c:358:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
arg[1] = tolower (arg[1]);
~~~~~~~^~~~~~~~~~~~~~~~~~
xmodmap.c:360:8: note: here
case 's':
^~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
|
|
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
|
|
Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Error: Null pointer dereference (CWE 476)
Read from null pointer str
at line 282 of handle.c in function 'parse_number'.
Function copy_to_scratch may return constant 'NULL' at line 98,
called at line 875 in function 'do_pointer'.
Constant 'NULL' passed into function parse_number, argument str,
from call at line 876.
Null pointer introduced at line 98 in function 'copy_to_scratch'.
[ This bug was found by the Parfait 1.4.0 bug checking tool.
http://labs.oracle.com/pls/apex/f?p=labs:49:::::P49_PROJECT_ID:13 ]
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
See http://people.gnome.org/~walters/docs/build-api.txt
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
If a user just wants to see syntax hints, don't require XOpenDisplay()
to succeed when we're not going to use it.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Reported by Luca Capello at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641588
Signed-off-by: Luca Capello <luca@pca.it>
Signed-off-by: Stéphane Aulery <lkppo@free.fr>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
Reviewed-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
|
|
Ensures definitions like _GNU_SOURCE are visible when needed.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=48696
Reported-by: Dominique Leuenberger
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Julien Cristau <jcristau@debian.org>
|
|
Regroup AC statements under the Autoconf initialization section.
Regroup AM statements under the Automake initialization section.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Includes local private copy of asprintf for OS'es without it in libc.
Removes chk_malloc as no callers remain anymore.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Our minimum requirement for X11 is currently Unix98. Unix98 provides
strcasecmp in <strings.h>. This commit fixes implicit declarations
of this function on systems that closely adhere to the standard.
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
handle.c:95:5: warning: Array access (from variable 'buf') results in a null pointer dereference
buf[len] = '\0';
^~~
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
xmodmap.c:159:5: warning: Value stored to 'status' is never read
status = 0;
^ ~
Found-by: clang static analyzer
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|
|
This silences an Autoconf warning
|
|
Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
AC_PROG_CC & AC_PROG_INSTALL are provided by XORG_DEFAULT_OPTIONS now
PKG_CONFIG_MODULES handles AC_SUBST of the CFLAGS & LIBS variables
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Unrelated to the previous patches, the new value simply reflects
the reality that the minimum level for autoconf to configure
all x.org modules is 2.60 dated June 2006.
ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
|