diff options
author | Peter Hutterer <peter.hutterer@who-t.net> | 2009-07-22 10:41:08 +1000 |
---|---|---|
committer | Peter Hutterer <peter.hutterer@who-t.net> | 2009-07-27 11:27:27 +1000 |
commit | d7a4a63d1d67bf38a7948722881de8d926319c6c (patch) | |
tree | 7a3caccdfa89b5750a5b137c2f4b39eb91460804 /src/properties.c | |
parent | 7179a0eb11a842d9d5a420f5702a411b0dc217a2 (diff) |
Revert "Auto-adjust edges if values fall outside queried min/max ranges. (#21001)"
This reverts commit afb60a0b2497c5d08cbd1739fa8ae6585c428881.
From comment 24 to #21001:
I've been running this code for over a week now and I'm not happy with it.
Once I move over to the right, the scroll-edge becomes so small that it's
hard to trigger.
Source of the problem is the information provided by the kernel. The kernel
hands us a min/max value for the synaptics pads but this value is not
reflective of the actual physical boundaries. The other dimensions are based
on these min/max ranges.
My RightEdge setting by default is 5129, after moving to the right it
becomes 5677. The announced max for x is 5472. We have model-specific edge
settings and in the case of synaptics the width of the scroll area is 7% of
the total width (based on min/max). This works, but obviously only because
the max is wrong. I've tried upping this to 15% and it works fine but unless
the edge is adjusted the scroll bar takes over too much of the pad.
So right now I'm inclined to revert this patch and just ditch any
auto-adjustment of scroll edges whatsoever. This way, the original setting
is maintained even if we reach outside of the min/max area.
Conflicts:
src/synaptics.c
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Diffstat (limited to 'src/properties.c')
-rw-r--r-- | src/properties.c | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/src/properties.c b/src/properties.c index d03ea6e..4366034 100644 --- a/src/properties.c +++ b/src/properties.c @@ -647,22 +647,5 @@ SetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop, return Success; } -void -SetEdgeProperty(LocalDevicePtr local) -{ - SynapticsPrivate *priv = (SynapticsPrivate*)local->private; - SynapticsParameters *para = &priv->synpara; - uint32_t values[4]; - - values[0] = para->left_edge; - values[1] = para->right_edge; - values[2] = para->top_edge; - values[3] = para->bottom_edge; - - XIChangeDeviceProperty(local->dev, prop_edges, XA_INTEGER, 32, - PropModeReplace, 4, values, FALSE); -} - - #endif |