diff options
author | Connor Behan <connor.behan@gmail.com> | 2024-06-23 22:24:44 -0300 |
---|---|---|
committer | Martin-Éric RACINE <martin-eric.racine@iki.fi> | 2024-06-24 19:42:15 +0300 |
commit | 224f565dec708eb0f85964e2b74c31b87c3e1808 (patch) | |
tree | ada80a96d6251b6082a41cb460bfd4a6d533036b /src/geode.h | |
parent | 9fbd276f1de0f695f2b884d0778db7a0e12bdc56 (diff) |
Suppress majority of compiler warnings
This applies some obvious changes to stop gcc from complaining about
dead code, shadow declarations, differing signedness and sections that
mix declarations with code.
The warning about discarding const qualifiers is more annoying because
we pass string literals to some functions which accept non-const
pointers. Currently, this takes the following approach. If the function
*needs* to accept non-const pointers, cast the string literal as char *.
Otherwise, change the function to only accept a const pointer. To
anticipate future use cases though, I could also leave function
definitions as they are and just always cast string literals.
Alternatively, if this is more trouble that it is worth, we could just
put up with the warnings.
Signed-off-by: Connor Behan <connor.behan@gmail.com>
Diffstat (limited to 'src/geode.h')
-rw-r--r-- | src/geode.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/geode.h b/src/geode.h index 65f6f84..5e6d422 100644 --- a/src/geode.h +++ b/src/geode.h @@ -378,7 +378,7 @@ Bool RegionsEqual(RegionPtr A, RegionPtr B); void GeodeProbeDDC(ScrnInfoPtr pScrni, int index); xf86MonPtr GeodeDoDDC(ScrnInfoPtr pScrni, int index); -Bool GeodeI2CInit(ScrnInfoPtr pScrni, I2CBusPtr * ptr, char *name); +Bool GeodeI2CInit(ScrnInfoPtr pScrni, I2CBusPtr * ptr, const char *name); int GeodeGetFPGeometry(const char *str, int *width, int *height); void GeodePointerMoved(ScrnInfoPtr pScrn, int x, int y); @@ -436,7 +436,7 @@ void LXSetupOutput(ScrnInfoPtr); /* lx_panel.c */ DisplayModePtr LXGetLegacyPanelMode(ScrnInfoPtr pScrni); -DisplayModePtr LXGetManualPanelMode(char *modestr); +DisplayModePtr LXGetManualPanelMode(const char *modestr); void LXAdjustFrame(ScrnInfoPtr pScrni, int x, int y); |