diff options
| author | Chris Wilson <chris@chris-wilson.co.uk> | 2017-12-20 08:46:43 +0000 |
|---|---|---|
| committer | Chris Wilson <chris@chris-wilson.co.uk> | 2017-12-20 08:49:11 +0000 |
| commit | 708255cbca83dbafe9154c39bd4553b0b81f09cf (patch) | |
| tree | 4333d4f28b763b151d3e432d7252f9bd178a83bf | |
| parent | 032a581fd7037c9d2e5fdc91d325db6a7e133b7f (diff) | |
sna: Drop redundant sync of an inactive snoop cache
Having requested an inactive snooped buffer, we know that it is
already flushed and do not need to flush it again. With debugging
enabled, we hit an assert while flushing that the buffer has a refcout,
which at this present time of being plucked from the snoop cache it does
not.
Reported-by: Adric Blake <promarbler14@gmail.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=104341#c2
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
| -rw-r--r-- | src/sna/kgem.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/sna/kgem.c b/src/sna/kgem.c index e58db967..038ecc87 100644 --- a/src/sna/kgem.c +++ b/src/sna/kgem.c @@ -3600,7 +3600,6 @@ static void kgem_finish_buffers(struct kgem *kgem) assert(bo->used <= bytes(shrink)); map = kgem_bo_map__cpu(kgem, shrink); if (map) { - kgem_bo_sync__cpu(kgem, shrink); memcpy(map, bo->mem, bo->used); shrink->target_handle = |