diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2014-02-17 13:16:51 +0100 |
|---|---|---|
| committer | Chris Wilson <chris@chris-wilson.co.uk> | 2014-02-17 17:02:01 +0000 |
| commit | 06066b7269b5ccf502c27466ad0434adfd9e3866 (patch) | |
| tree | f77c114bf15148c16f66064d0f7637e7ba691f66 /src/backlight.c | |
| parent | 6b5c2b4515b646db6be0f9307f53651620516521 (diff) | |
backlight: Explain better why we support both pkexec and suid root for the helper
Update the comment about trying suid-root first with some explanations of
why pkexec may be preferable in some cases.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'src/backlight.c')
| -rw-r--r-- | src/backlight.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/backlight.c b/src/backlight.c index b7569294..728cddad 100644 --- a/src/backlight.c +++ b/src/backlight.c @@ -270,8 +270,10 @@ static int __backlight_helper_init(struct backlight *b, char *iface) int use_pkexec = 0; int fds[2]; - /* If system policy is to disallow setuid helpers, - * we fallback to invoking PolicyKit. However, as pkexec + /* + * Some systems may prefer using PolicyKit's pkexec over + * making the helper suid root, since the suid option will allow + * anyone to control the backlight. However, as pkexec * is quite troublesome and not universally available, we * still try the old fashioned and simple method first. * Either way, we have to trust that it is our backlight-helper |