diff options
| author | Alan Coopersmith <alan.coopersmith@oracle.com> | 2024-01-26 09:27:20 -0800 |
|---|---|---|
| committer | Alan Coopersmith <alan.coopersmith@oracle.com> | 2024-01-26 09:30:27 -0800 |
| commit | c8ab8f7868c1891a146e9f679278b990f1e23516 (patch) | |
| tree | 01a5926fdbc9c1aab1e35e83e975ce0528bd1602 | |
| parent | eff27e0d6a18350cfd7ad226cacc538c15f49995 (diff) | |
riva_hw.c: Ensure ABS macro expands correctly
Handles warning from Oracle Parfait static analyser:
Error: Misleading macro
Misleading macro [misleading-macro]:
misleading evaluation of unary '-' operator in expansion of macro ABS due to missing parentheses
at line 104 of src/riva_hw.c.
binary '+' operator has lower precedence than unary '-' operator inside macro body at line 298
if (ABS(ainfo->vburst_size) + (ABS(ainfo->wcvlwm + 32) & ~0xf) - tmp> VFIFO_SIZE)
low precedence binary '+' operator is hidden by expansion of macro argument a at line 104
#define ABS(a) (a>0?a:-a)
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
| -rw-r--r-- | src/riva_hw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/riva_hw.c b/src/riva_hw.c index c178eac..9903625 100644 --- a/src/riva_hw.c +++ b/src/riva_hw.c @@ -101,7 +101,7 @@ static int ShowHideCursor #define GFIFO_SIZE_128 256 #define MFIFO_SIZE 120 #define VFIFO_SIZE 256 -#define ABS(a) (a>0?a:-a) +#define ABS(a) ((a) > 0 ? (a) : -(a)) typedef struct { int gdrain_rate; int vdrain_rate; |