Age | Commit message (Collapse) | Author |
|
|
|
by Tormod Volden pointed at by Ryan Freeman. Thanks.
Has been in snapshots for a while without complaints.
|
|
|
|
Clears -Wcalloc-transposed-args warnings from gcc 14.1, such as:
savage_dri.c: In function ‘SAVAGEDRIScreenInit’:
savage_dri.c:732:46: warning: ‘calloc’ sizes specified with ‘sizeof’ in the
earlier argument and not in the later argument [-Wcalloc-transposed-args]
732 | pSAVAGEDRI = (SAVAGEDRIPtr)calloc( sizeof(SAVAGEDRIRec), 1 );
| ^~~~~~~~~~~~
savage_dri.c:732:46: note: earlier argument should specify number of
elements, later size of each element
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-savage/-/merge_requests/13>
|
|
There's still a lot code thats either commented- of ifdef'ed out.
Most likely not needed anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-savage/-/merge_requests/12>
|
|
Since we're relying on xserver >= 1.18, these macros aren't needed anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-savage/-/merge_requests/12>
|
|
We're relying on at least 1.18 now.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-savage/-/merge_requests/10>
|
|
It's always present at least for >= 1.18 now.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-savage/-/merge_requests/10>
|
|
Already effectively required by use of XNFcallocarray() introduced in
xorg/xserver@b96dc999 - xserver-1.18.0, released in Nov. 2015.
Allows dropping remnants of code for XAA and pre-pciaccess X servers
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-savage/-/merge_requests/11>
|
|
xnfcalloc is just an alias for XNFcallocarray() that doesn't seem to serve
any practical purpose, so it can go away once all drivers stopped using it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-savage/-/merge_requests/9>
|
|
xnfalloc is just an alias for XNFalloc() that doesn't seem to serve
any practical purpose, so it can go away once all drivers stopped using it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-savage/-/merge_requests/9>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
The Xorg headers provide their own versions of strlcat, strlcpy, and
timingsafe_memcmp for platforms that don't have them in libc yet, but
rely on configure to set HAVE_* defines to determine if they should be
defined in the headers.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
savage_driver.c: In function ‘SavagePreInit’:
savage_driver.c:2168:13: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
2168 | XF86ModReqInfo req;
| ^~~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
savage_accel.c:1541:5: warning: no previous prototype for ‘SavageGetCopyROP’ [-Wmissing-prototypes]
1541 | int SavageGetCopyROP(int rop) {
| ^~~~~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
This reverts commit ac460e6836bdd2cd16c9d29743376c16fdc6924e.
Fixes gcc error:
savage_exa.c: In function ‘SavageDownloadFromScreen’:
savage_exa.c:570:26: warning: cast from function call of type ‘CARD32’ {aka ‘unsigned int’} to non-matching type ‘unsigned char *’ [-Wbad-function-cast]
570 | unsigned char *src = (unsigned char *) exaGetPixmapFirstPixel(pSrc);
| ^
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
AC_PROG_LIBTOOL was replaced by LT_INIT in libtool 2 in 2008,
so it's time to rely on it.
Clears autoconf warnings:
configure.ac:44: warning: The macro 'AC_PROG_LIBTOOL' is obsolete.
configure.ac:44: You should run autoupdate.
aclocal.m4:3515: AC_PROG_LIBTOOL is expanded from...
configure.ac:44: the top level
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Clears gcc 13.2 warning:
savage_driver.c: In function ‘SavageModeInit’:
savage_driver.c:3731:13: warning: this condition has identical branches
[-Wduplicated-branches]
3731 | else if (pScrn->bitsPerPixel == 16)
| ^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
The API was removed by Xserver commit dd00e5466a0e4ea313d1860824da4123692827ed
in xorg-server-1.20.0 and later.
Found by gcc -Werror=implicit:
savage_driver.c: In function ‘SavagePreInit’:
savage_driver.c:1237:13: error: implicit declaration of function
‘xf86DisableRandR’; did you mean ‘xf86DisableIO’?
[-Werror=implicit-function-declaration]
1237 | xf86DisableRandR();
| ^~~~~~~~~~~~~~~~
| xf86DisableIO
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Clears 8 of 15 -Wdiscarded-qualifiers warnings from gcc
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Found by using:
codespell --builtin clear,rare,usage,informal,code,names
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
AC_CHECK_FILE can't be used when cross-compiling
[Retrieved from:
https://git.buildroot.net/buildroot/tree/package/x11r7/xdriver_xf86-video-savage/0001-cross-compile.patch]
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
|
For ABI_VIDEODRV_VERSION >= 23, it was changed to int from unsigned
long.
Signed-off-by: Kevin Brace <kevinbrace@gmx.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
|
|
Signed-off-by: Kevin Brace <kevinbrace@gmx.com>
|
|
Signed-off-by: Kevin Brace <kevinbrace@gmx.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
xorg-server 1.20 removed this check, so implement this in the driver
itself.
Signed-off-by: Stefan Dirsch <sndirsch@suse.de>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
|
|
The function was an empty since 2008 at least. Remove it alongside the
unused GLX visuals code.
With this all the GL/GLX dependencies in the driver are gone.
Cc: Stefan Dirsch <sndirsch@suse.de>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
|
|
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
|
|
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
|
|
See http://people.gnome.org/~walters/docs/build-api.txt
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Matt Turner <mattst88@gmail.com>
|
|
Signed-off-by: Adam Jackson <ajax@redhat.com>
|
|
Xserver cannot be started with Tiling enabled on SuperSavage.
https://bugzilla.opensuse.org/show_bug.cgi?id=805380
Signed-off-by: Stefan Dirsch <sndirsch@suse.de>
Acked-by: Hans de Goede <hdegoede@redhat.com>
|
|
Signed-off-by: Julien Cristau <jcristau@debian.org>
|
|
savage_driver.c:1228:12: warning: assignment discards 'const' qualifier from pointer target type
if ((s = xf86GetOptValString(psav->Options, OPTION_ROTATE))) {
^
Signed-off-by: Julien Cristau <jcristau@debian.org>
|
|
Signed-off-by: Adam Jackson <ajax@redhat.com>
|
|
I plan to remove the Weak functions from a future server.
Signed-off-by: Adam Jackson <ajax@redhat.com>
|