summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Hellstrom <thellstrom@vmware.com>2014-05-09 09:35:59 +0200
committerThomas Hellstrom <thellstrom@vmware.com>2014-05-09 11:41:40 +0200
commit88c487cb19aaf2882d582f7f887a52935ef8d92e (patch)
tree7dc0097ac524627c301cba64b7af1dbb983850e7
parentf31eed4a578784329a7038aa01acaa10a2d0c246 (diff)
vmware/saa: Disable the noreadback polyfillrect optimization
It causes rendering artefacts with some motif applications due to damage area confusion. Until that is sorted out, temporarily disable the optimization. Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com> Reviewed-by: Jakob Bornecrantz <jakob@vmware.com>
-rw-r--r--saa/saa_unaccel.c12
1 files changed, 11 insertions, 1 deletions
diff --git a/saa/saa_unaccel.c b/saa/saa_unaccel.c
index e2bf3ac..deaeb8b 100644
--- a/saa/saa_unaccel.c
+++ b/saa/saa_unaccel.c
@@ -396,6 +396,7 @@ saa_check_poly_arc(DrawablePtr pDrawable, GCPtr pGC, int narcs, xArc * pArcs)
* region fragmentation. In any case, this greatly improves on the performance of
* shaped windows on top of accelerated contents, for example unscaled OSD in xine.
*/
+#if 0
static Bool
saa_check_poly_fill_rect_noreadback(DrawablePtr pDrawable, GCPtr pGC,
int nrect, xRectangle *prect)
@@ -476,7 +477,7 @@ saa_check_poly_fill_rect_noreadback(DrawablePtr pDrawable, GCPtr pGC,
return FALSE;
}
-
+#endif
void
saa_check_poly_fill_rect(DrawablePtr pDrawable, GCPtr pGC,
int nrect, xRectangle * prect)
@@ -487,8 +488,17 @@ saa_check_poly_fill_rect(DrawablePtr pDrawable, GCPtr pGC,
SAA_FALLBACK(("to %p (%c)\n", pDrawable, saa_drawable_loc(pDrawable)));
+
+ /*
+ * Disable saa_check_poly_fill_rect_noreadback as it causes rendering
+ * artefacts with some motif applications. There seems to be some
+ * confusion with the damage area.
+ */
+
+#if 0
if (saa_check_poly_fill_rect_noreadback(pDrawable, pGC, nrect, prect))
return;
+#endif
sscreen->fallback_count++;