summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2023-02-25Remove "All rights reserved" from Oracle copyright noticesAlan Coopersmith
Oracle no longer includes this term in our copyright & license notices. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-19XFixesCloseDisplay: Mark codes as unusedAlan Coopersmith
Quiets clang warning: Xfixes.c:206:46: warning: unused parameter 'codes' [-Wunused-parameter] XFixesCloseDisplay (Display *dpy, XExtCodes *codes) ^ Raises minimum required version of xproto to 7.0.22 (released June 2011) for the definition of _X_UNUSED Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-19Handle 6 of 9 -Wsign-conversion warnings from clangAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-19Handle 60 of 60 -Wimplicit-int-conversion warnings from clangAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-19Handle 63 of 63 -Wshorten-64-to-32 warnings from clangAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-19Resolve 36 of 40 -Wextra-semi-stmt warnings from clangAlan Coopersmith
Wrap XFixesCheckExtension() & XFixesSimpleCheckExtension() macro bodies in do { ... } while(0) so that they use the semicolon provided by callers instead of letting it dangle as another statement. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-19Quiet -Wconditional-uninitialized warnings from clangAlan Coopersmith
I believe these were false positives, as the variables were initialized unless the image = NULL -> if (!image) return NULL code path was followed, but this makes clang stop warning. Cursor.c:144:8: warning: variable 'nbytes' may be uninitialized when used here [-Wconditional-uninitialized] if(nbytes > nread) ^~~~~~ Cursor.c:80:21: note: initialize the variable 'nbytes' to silence this warning size_t nbytes , nread ; ^ = 0 Cursor.c:144:17: warning: variable 'nread' may be uninitialized when used here [-Wconditional-uninitialized] if(nbytes > nread) ^~~~~ Cursor.c:80:29: note: initialize the variable 'nread' to silence this warning size_t nbytes , nread ; ^ = 0 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-19Mark two dpy parameters const as suggested by cppcheckAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-19Variable scope reduction as recommended by cppcheckAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-11-19Remove unnecessary casts from malloc & free callsAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-05-10xfixes: Add ClientDisconnectModeOlivier Fourdan
The Xserver itself is capable of terminating itself once all X11 clients are gone, yet in a typical full session, there are a number of X11 clients running continuously (e.g. the Xsettings daemon, IBus, etc.). Those always-running clients will prevent the Xserver from terminating, because the actual number of X11 clients will never drop to 0. To solve this issue directly at the Xserver level, this add new entries to the XFixes extension to let the X11 clients themselves specify the disconnect mode they expect. Typically, those X11 daemon clients would specify the disconnect mode XFixesClientDisconnectFlagTerminate to let the Xserver know that they should not be accounted for when checking the remaining clients prior to terminate. Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
2016-09-25Integer overflow on illegal server responseTobias Stoeckmann
The 32 bit field "rep.length" is not checked for validity, which allows an integer overflow on 32 bit systems. A malicious server could send INT_MAX as length, which gets multiplied by the size of XRectangle. In that case the client won't read the whole data from server, getting out of sync. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org> Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
2013-11-22Remove fallback for _XEatDataWords, require libX11 1.6 for itMichael Joost
_XEatDataWords was orignally introduced with the May 2013 security patches, and in order to ease the process of delivering those, fallback versions of _XEatDataWords were included in the X extension library patches so they could be applied to older versions that didn't have libX11 1.6 yet. Now that we're past that hurdle, we can drop the fallbacks and just require libX11 1.6 for building new versions of the extension libraries. Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-05-03integer overflow in XFixesGetCursorImage() [CVE-2013-1983]Alan Coopersmith
If the reported cursor dimensions or name length are too large, the calculations to allocate memory for them may overflow, leaving us writing beyond the bounds of the allocation. Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-05-03Use _XEatDataWords to avoid overflow of _XEatData calculationsAlan Coopersmith
rep.length is a CARD32, so rep.length << 2 could overflow in 32-bit builds Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-03-09XFixesFetchRegionAndBounds: use nread in call to XReadPadAlan Coopersmith
We already went through the trouble of calculating a variable with the amount to read, might as well use it instead of recalculating it. Also move initialization of the variable to the point it's needed/used Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
2013-03-09Remove duplicate declaration of XFixesExtensionName in Xfixesint.hAlan Coopersmith
Silences gcc warnings: In file included from Region.c:26:0: Xfixesint.h:52:13: warning: redundant redeclaration of 'XFixesExtensionName' [-Wredundant-decls] Xfixesint.h:34:13: note: previous declaration of 'XFixesExtensionName' was here In file included from Cursor.c:49:0: Xfixesint.h:52:13: warning: redundant redeclaration of 'XFixesExtensionName' [-Wredundant-decls] Xfixesint.h:34:13: note: previous declaration of 'XFixesExtensionName' was here Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
2013-01-18Replace deprecated Automake INCLUDES variable with AM_CPPFLAGSAlan Coopersmith
Excerpt https://lists.gnu.org/archive/html/automake/2012-12/msg00038.html - Support for the long-deprecated INCLUDES variable will be removed altogether in Automake 1.14. The AM_CPPFLAGS variable should be used instead. This variable was deprecated in Automake releases prior to 1.10, which is the current minimum level required to build X. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-09-16Strip trailing whitespaceAlan Coopersmith
Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}' git diff -w & git diff -b show no diffs from this change Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-03-08libXfixes v5: Pointer barrierslibXfixes-5.0Adam Jackson
v2: Use int * for device list, consistent with libXi. v3: Update copyright year. Reviewed-by: Julien Cristau <jcristau@debian.org> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Adam Jackson <ajax@redhat.com>
2010-07-07Purge macros NEED_EVENTS and NEED_REPLIESFernando Carrijo
Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br> Acked-by: Tiago Vignatti <tiago.vignatti@nokia.com> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-06-08Sun's copyrights now belong to OracleAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-04-09Always call SyncHandle after issuing an X request.Jamey Sharp
2010-01-14Update Sun license notices to current X.Org standard formAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
2010-01-14Purge CVS/RCS id tagsAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
2009-10-08Migrate to xorg macros 1.3 & XORG_DEFAULT_OPTIONSAlan Coopersmith
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
2009-01-29Janitor: Correct make distcheck and gcc/sparse warnings.Paulo Cesar Pereira de Andrade
2008-05-19Rename parameters to clarify QueryVersion/QueryExtension.Peter Hutterer
These parameters are not treated as input. Rename them to make the inner workings slightly more obvious. X.Org Bug 14511 <http://bugs.freedesktop.org/show_bug.cgi?id=14511>
2008-03-09nuke RCS IdsMatthieu Herrb
2006-10-15Don't unlock the Display when you have not locked it.Lars Knoll
Acked-by: Jamey Sharp <jamey@minilop.net>
2006-09-27Add *~ to .gitignore to skip over emacs droppingsAlan Coopersmith
2006-09-27Sun bug #5099413/Xorg bugzilla #1554: Gnopernicus full-screen mag not workingStuart Kreitman
Sun bug #5099413: Gnopernicus full-screen magnification not working <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=5099413> includes fix for Xorg bug #1554: rect defined in XFixesInvertRegion is not used <https://bugs.freedesktop.org/show_bug.cgi?id=1554>
2006-09-01Bug #4902: _XRead32() expects a signed long pointer on 64 bit systems.Tilman Sauerbeck
2006-07-13renamed: .cvsignore -> .gitignoreAlan Coopersmith
2006-05-12Fix the soversion to 3.1.0.libXfixes-4_0_1XORG-7_1Adam Jackson
2006-04-03Coverity #576: Plug a leak on the error path.XORG-7_0_99_901Adam Jackson
2006-03-13Part 2 of 3 (Other parts are in proto and xserver) Composite Version 0.3:Deron Johnson
CompositeGetOverlayWindow, CompositeReleaseOverlayWindow Xfixes Version 4.0: XFixesHideCursor, XFixesShowCursor
2005-11-01Update pkgcheck dependencies to work with separate build roots.Kevin E Martin
2005-07-16Set soversion to 3.0.0 using -version-number.Daniel Stone
2005-07-09Add .cvsignore files Switch _la_CFLAGS for AM_CFLAGS to clean up directoryKeith Packard
2005-07-02Add appropriate lib*_CFLAGS to Makefile.am's -- fixes build problemsKevin E Martin
2005-05-17Conditionally include config.h in xc/lib/Xdamage and xc/lib/XfixesXORG-6_8_99_9XORG-6_8_99_8XORG-6_8_99_13XORG-6_8_99_12XORG-6_8_99_11XORG-6_8_99_10Søren Sandmann Pedersen
2005-05-17Check in Makefile.am hereSøren Sandmann Pedersen
2004-12-04Encoding of numerous files changed to UTF-8xprint_packagertest_20041217_basesco_port_update-baseXORG-6_8_99_7XORG-6_8_99_6XORG-6_8_99_5XORG-6_8_99_4XORG-6_8_99_3XORG-6_8_99_2XORG-6_8_99_1xprint_packagertest_20041217sco_port_updateMarkus Kuhn
2004-07-31Bring in Xfixes, Xdamage, and Xcomposite userland from xserver CVS:xprint_packagertest_20041125_baserel-0-6-1lg3d-rel-0-7-0lg3d-rel-0-6-2lg3d-baseXORG-6_8_2XORG-6_8_1_904XORG-6_8_1_903XORG-6_8_1_902XORG-6_8_1_901XORG-6_8_1XORG-6_8_0XORG-6_7_99_904XORG-6_7_99_903XORG-6_7_99_902XORG-6_7_99_901XORG-6_7_99_2XORG-6_7_99_1xprint_packagertest_20041125lg3d-masterlg3d-eventlg3d-dev-0-7-1lg3d-dev-0-7-0lg3d-dev-0-6-latestlg3d-dev-0-6-2lg3d-dev-0-6-1-latestlg3d-dev-0-6-1-currentlg3d-dev-0-6-1-1lg3d-dev-0-6-1lg3dXORG-6_8-branchEric Anholt
- Update Xfixes headers to protocol major version 3. - Add composite headers. - Add libXfixes, libXdamage, and libXcomposite. - Add imake glue for new libraries, but leave Composite off by default until issues are resolved.