diff options
author | Peter Hutterer <peter.hutterer@who-t.net> | 2013-05-28 15:52:32 +1000 |
---|---|---|
committer | Peter Hutterer <peter.hutterer@who-t.net> | 2013-06-27 05:37:18 +1000 |
commit | 4c8e9bcab459ea5f870d3e56eff15f931807f9b7 (patch) | |
tree | 8eca648742d6d46ad9e28967020fa04e29b37666 /src/XGetProp.c | |
parent | 661c45ca17c434dbd342a46fd3fb813852ae0ca9 (diff) |
Fix potential corruption in mask_len handling
First: check for allocation failure on the mask.
XI2 requires that the mask is zeroed, so we can't just Data() the mask
provided by the client (it will pad) - we need a tmp buffer. Make sure that
doesn't fail.
Second:
req->mask_len is a uint16_t, so check against malicious mask_lens that would
cause us to corrupt memory on copy, as the code always allocates
req->mask_len * 4, but copies mask->mask_len bytes.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Diffstat (limited to 'src/XGetProp.c')
0 files changed, 0 insertions, 0 deletions