diff options
| author | Demi Marie Obenour <demiobenour@gmail.com> | 2020-12-17 03:28:45 +0000 |
|---|---|---|
| committer | Alan Coopersmith <alan.coopersmith@oracle.com> | 2023-03-19 18:07:21 +0000 |
| commit | e24adec1203cd25423ab2835a5be4f6b828b72a5 (patch) | |
| tree | 94d5952a7477581a7ccdbb4cf402f0e2a7b15a19 /Xtransint.h | |
| parent | 9d77996f9f972da63c06099fd8c0f0529159b98f (diff) | |
Remove client-side abstract socket support
CVE-2020-25697 and the Flatpak documentation show that clients using
abstract sockets without mutual authentication is unsafe.
TRANS_ABSTRACT remains supported, but it is now a no-op on the client
side. Abstract sockets are still supported for servers, as the X server
authenticates the client via other methods.
Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
Diffstat (limited to 'Xtransint.h')
| -rw-r--r-- | Xtransint.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/Xtransint.h b/Xtransint.h index b8f3b76..a43f7f8 100644 --- a/Xtransint.h +++ b/Xtransint.h @@ -297,7 +297,9 @@ typedef struct _Xtransport_table { #define TRANS_DISABLED (1<<2) /* Don't open this one */ #define TRANS_NOLISTEN (1<<3) /* Don't listen on this one */ #define TRANS_NOUNLINK (1<<4) /* Don't unlink transport endpoints */ -#define TRANS_ABSTRACT (1<<5) /* Use abstract sockets if available */ +#define TRANS_ABSTRACT (1<<5) /* This previously meant that abstract sockets should be used available. For security + * reasons, this is now a no-op on the client side, but it is still supported for servers. + */ #define TRANS_NOXAUTH (1<<6) /* Don't verify authentication (because it's secure some other way at the OS layer) */ #define TRANS_RECEIVED (1<<7) /* The fd for this has already been opened by someone else. */ |