xstrdup the return value of basename() before recording it in the bfd,

fixes the "NEEDED crtend.o" problem that appeared in varios ports and
had to be workarounded.  from thorpej@NetBSD, thanks to drahn@ for
pointing it out; ok drahn espie

1 files changed, 3 insertions, 2 deletions

diff --git a/gnu/usr.bin/binutils/ld/emultempl/elf32.em b/gnu/usr.bin/binutils/ld/emultempl/elf32.em
index a575368f716..8d4b0636fd0 100644
--- a/gnu/usr.bin/binutils/ld/emultempl/elf32.em
+++ b/gnu/usr.bin/binutils/ld/emultempl/elf32.em
@@ -392,7 +392,7 @@ gld${EMULATION_NAME}_try_needed (name, force)
      int force;
 {
   bfd *abfd;
-  const char *soname;
+  char *soname;
 
   abfd = bfd_openr (name, bfd_get_target (output_bfd));
   if (abfd == NULL)
@@ -478,7 +478,7 @@ cat >>e${EMULATION_NAME}.c <<EOF
     einfo ("%F%P:%B: bfd_stat failed: %E\n", abfd);
 
   /* First strip off everything before the last '/'.  */
-  soname = basename (abfd->filename);
+  soname = xstrdup (basename (abfd->filename));
 
   if (trace_file_tries)
     info_msg (_("found %s at %s\n"), soname, name);
@@ -489,6 +489,7 @@ cat >>e${EMULATION_NAME}.c <<EOF
     {
       /* Return true to indicate that we found the file, even though
          we aren't going to do anything with it.  */
+      free (soname);
       return true;
     }