diff options
| author | Marc Espie <espie@cvs.openbsd.org> | 2012-04-28 15:24:53 +0000 |
|---|---|---|
| committer | Marc Espie <espie@cvs.openbsd.org> | 2012-04-28 15:24:53 +0000 |
| commit | 6e9c4f7fb041f0a99b7a2bd18be872bcd3887c7b (patch) | |
| tree | 9e7494b3203a9c9470ed185f8fb7123106c11882 | |
| parent | a7bc54da116f679023f7d44d1ee1a2b1fe5e140e (diff) | |
explain why the base pseudo-handle is a dirty hack and why it's less
confusing than the clean approach
| -rw-r--r-- | usr.sbin/pkg_add/OpenBSD/ForwardDependencies.pm | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/usr.sbin/pkg_add/OpenBSD/ForwardDependencies.pm b/usr.sbin/pkg_add/OpenBSD/ForwardDependencies.pm index bb5db9adee1..86a040a536f 100644 --- a/usr.sbin/pkg_add/OpenBSD/ForwardDependencies.pm +++ b/usr.sbin/pkg_add/OpenBSD/ForwardDependencies.pm @@ -1,5 +1,5 @@ # ex:ts=8 sw=4: -# $OpenBSD: ForwardDependencies.pm,v 1.12 2012/04/28 11:55:53 espie Exp $ +# $OpenBSD: ForwardDependencies.pm,v 1.13 2012/04/28 15:24:52 espie Exp $ # # Copyright (c) 2009 Marc Espie <espie@openbsd.org> # @@ -51,6 +51,11 @@ sub adjust $state->errsay("XXX #1", $check); $deps_f->delete($check); } else { + # XXX proper OO wouldn't have ->is_real + # but it would use double dispatch to record + # every dependency. + # ETOOMUCHSCAFFOLDING, quick&dirty hack + # is much shorter and fairly localized. my $r = $h->{update_found}; my $p = $r->pkgname; $state->say("Adjusting #1 to #2 in #3", |