Revert my previous commit to ieee80211_node.c (CVS commit Hne35XgzezGa9zmv).

Sending frames from ieee80211_node_join_bss() won't work as expected.
I missed that IEEE80211_SEND_MGMT() calls if_start() immediately after
queueing the management frame. This means the probe request is being
sent in a state where, while ic_bss represents our new AP, the driver
did not yet have a chance to move the device over to our new AP.

The auth request for the new AP is sent from ieee80211_newstate() which
runs after the driver has reconfigured the device. If want to send a
probe request to the new AP then we would need to send it at that point,
before the auth frame gets sent.

1 files changed, 1 insertions, 10 deletions

diff --git a/sys/net80211/ieee80211_node.c b/sys/net80211/ieee80211_node.c
index e6bc96875d3..2fe4984654e 100644
--- a/sys/net80211/ieee80211_node.c
+++ b/sys/net80211/ieee80211_node.c
@@ -1,4 +1,4 @@
-/*	$OpenBSD: ieee80211_node.c,v 1.186 2021/10/07 12:26:09 stsp Exp $	*/
+/*	$OpenBSD: ieee80211_node.c,v 1.187 2021/10/08 09:22:10 stsp Exp $	*/
 /*	$NetBSD: ieee80211_node.c,v 1.14 2004/05/09 09:18:47 dyoung Exp $	*/
 
 /*-
@@ -1268,15 +1268,6 @@ ieee80211_node_join_bss(struct ieee80211com *ic, struct ieee80211_node *selbs)
 
 		/* 
 		 * After a background scan, we have now switched APs.
-		 * Send a probe request to our new AP to say "Hello!".
-		 * This is not strictly required but could help with
-		 * setting up state in our new AP.
-		 */
-		if (bgscan) {
-			IEEE80211_SEND_MGMT(ic, ni,
-			    IEEE80211_FC0_SUBTYPE_PROBE_REQ, 0);
-		}
-		/*
 		 * Pretend we were just de-authed, which makes
 		 * ieee80211_new_state() try to re-auth and thus send
 		 * an AUTH frame to our newly selected AP.