diff options
| author | Jeremie Courreges-Anglas <jca@cvs.openbsd.org> | 2021-07-05 13:56:25 +0000 |
|---|---|---|
| committer | Jeremie Courreges-Anglas <jca@cvs.openbsd.org> | 2021-07-05 13:56:25 +0000 |
| commit | 59504c6567741c600979138f5574b7c71411370a (patch) | |
| tree | c4cfa0d965e8164f61251f2f237e3f94b553b4f8 /distrib | |
| parent | 032b811331363d2688056112a1149987e6630bdc (diff) | |
Don't use a non-standard empty statement in while loops
Empty statements accepted by ksh(1) pointed out by millert@, use of this
non-standard grammar in the installer pointed out by halex@.
ok halex@ millert@
Diffstat (limited to 'distrib')
| -rw-r--r-- | distrib/miniroot/install.sub | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/distrib/miniroot/install.sub b/distrib/miniroot/install.sub index 1a1fb871ed2..542316c709a 100644 --- a/distrib/miniroot/install.sub +++ b/distrib/miniroot/install.sub @@ -1,5 +1,5 @@ #!/bin/ksh -# $OpenBSD: install.sub,v 1.1165 2021/06/03 15:05:55 krw Exp $ +# $OpenBSD: install.sub,v 1.1166 2021/07/05 13:56:24 jca Exp $ # # Copyright (c) 1997-2015 Todd Miller, Theo de Raadt, Ken Westerback # Copyright (c) 2015, Robert Peichaer <rpe@openbsd.org> @@ -223,7 +223,7 @@ tmpdir() { unique_filename() { local _fn=$1 _ufn - while _ufn=${_fn}.$RANDOM && [[ -e $_ufn ]]; do done + while _ufn=${_fn}.$RANDOM && [[ -e $_ufn ]]; do :; done print -- "$_ufn" } @@ -530,7 +530,7 @@ configure_disk() { # Acquire lock. lock() { - while ! mkdir /tmp/i/lock 2>/dev/null && sleep .1; do done + while ! mkdir /tmp/i/lock 2>/dev/null && sleep .1; do :; done } # Release lock. @@ -765,7 +765,7 @@ _ask() { ask() { # Prompt again in case the dmesg listener detected a change. - while ! _ask "$1" "$2"; do done + while ! _ask "$1" "$2"; do :; done log_answers "$1" "$resp" } |