summaryrefslogtreecommitdiff
path: root/regress
diff options
context:
space:
mode:
authorTheo Buehler <tb@cvs.openbsd.org>2024-10-16 23:58:26 +0000
committerTheo Buehler <tb@cvs.openbsd.org>2024-10-16 23:58:26 +0000
commit65e091c854b723c53a37febfeef22cf809edab2b (patch)
treebbbc4ff78baaefdf6e2077cbd8f84138fa97789e /regress
parentab8e2e496651f0a5dd22c9621566334bff1f48a7 (diff)
EC ASN.1: add reminder that the simple method might also want testing
Diffstat (limited to 'regress')
-rw-r--r--regress/lib/libcrypto/ec/ec_asn1_test.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/regress/lib/libcrypto/ec/ec_asn1_test.c b/regress/lib/libcrypto/ec/ec_asn1_test.c
index cc0f0f46f4e..171014bda7e 100644
--- a/regress/lib/libcrypto/ec/ec_asn1_test.c
+++ b/regress/lib/libcrypto/ec/ec_asn1_test.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ec_asn1_test.c,v 1.5 2024/10/16 23:49:49 tb Exp $ */
+/* $OpenBSD: ec_asn1_test.c,v 1.6 2024/10/16 23:58:25 tb Exp $ */
/*
* Copyright (c) 2017, 2021 Joel Sing <jsing@openbsd.org>
* Copyright (c) 2024 Theo Buehler <tb@openbsd.org>
@@ -458,6 +458,10 @@ ec_weierstrass25519(void)
if (BN_hex2bn(&b, wei25519.b) == 0)
errx(1, "BN_hex2bn(b)");
+ /*
+ * XXX - this uses the Montgomery method. Consider exercising the
+ * simple method as well.
+ */
if ((group = EC_GROUP_new_curve_GFp(p, a, b, ctx)) == NULL) {
fprintf(stderr, "FAIL: %s EC_GROUP_new_curve_GFp", __func__);
goto err;