diff options
author | Kenneth R Westerback <krw@cvs.openbsd.org> | 2008-01-25 16:23:13 +0000 |
---|---|---|
committer | Kenneth R Westerback <krw@cvs.openbsd.org> | 2008-01-25 16:23:13 +0000 |
commit | 67a28655a624d1aba69102859974398122b37327 (patch) | |
tree | f04ee16c7101f4339623f6000df3ceff99f0c02e /sbin | |
parent | 6d40b38168998b6a0a2816cd356b013bfc49c3c9 (diff) |
"read(..., ..., sizeof Y) < sizeof Y" is a dangerous idiom because it
does an unsigned comparison and read() can return -1. Use '!=' instead
of '<' since read() can't return more than 'sizeof Y'. Not perfect
(that would require a separate test for -1) but a very common usage.
We don't actually compile this code so there is no functional change.
Diff fixed & ok millert@
Diffstat (limited to 'sbin')
0 files changed, 0 insertions, 0 deletions