diff options
| author | Alexander Bluhm <bluhm@cvs.openbsd.org> | 2017-02-07 15:10:49 +0000 |
|---|---|---|
| committer | Alexander Bluhm <bluhm@cvs.openbsd.org> | 2017-02-07 15:10:49 +0000 |
| commit | 2de87769d0c537b24d4c1cd363b9854ba7c6f041 (patch) | |
| tree | 5c4bac46e6bf8831f1f9d05e9a80dc7aafa315c6 /sys/crypto | |
| parent | 81ad11f09665ede7d011decf9ee1dc03c164d9ea (diff) | |
The return code of crp_callback is never checked, so it is not
useful to propagate the error. When an error occurs in an asynchronous
network path, incrementing a counter is the right thing. There are
four places where an error is not accounted, just add a comment for
now.
OK mpi@ visa@
Diffstat (limited to 'sys/crypto')
| -rw-r--r-- | sys/crypto/cryptodev.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/crypto/cryptodev.h b/sys/crypto/cryptodev.h index e7ba22ab2ee..bd915817ebd 100644 --- a/sys/crypto/cryptodev.h +++ b/sys/crypto/cryptodev.h @@ -1,4 +1,4 @@ -/* $OpenBSD: cryptodev.h,v 1.68 2016/04/18 21:05:55 kettenis Exp $ */ +/* $OpenBSD: cryptodev.h,v 1.69 2017/02/07 15:10:48 bluhm Exp $ */ /* * The author of this code is Angelos D. Keromytis (angelos@cis.upenn.edu) @@ -181,7 +181,7 @@ struct cryptop { void *crp_opaque; /* Opaque pointer, passed along */ struct cryptodesc *crp_desc; /* Linked list of processing descriptors */ - int (*crp_callback)(struct cryptop *); /* Callback function */ + void (*crp_callback)(struct cryptop *); /* Callback function */ caddr_t crp_mac; }; |