diff options
author | Stefan Sperling <stsp@cvs.openbsd.org> | 2021-11-22 10:31:59 +0000 |
---|---|---|
committer | Stefan Sperling <stsp@cvs.openbsd.org> | 2021-11-22 10:31:59 +0000 |
commit | af8239522c8ad38e0ad57f57ba2ed5dd7c72af74 (patch) | |
tree | 01da67d5b7af5fab224395c394a94d492285834e /sys/dev/pci/if_iwxreg.h | |
parent | 24fe5302b5bbb277e2c587f633036d694ded3984 (diff) |
Fix iwx(4) Tx ring array size which was one entry too short.
Fortunately, this bug was harmless. The last Tx agg queue is never used
because ieee80211_classify() only returns TID values in the range 0 - 3.
And iterations over the txq array use nitems() to find the upper bound.
The possiblity of shrinking the txq array by 4 elements to get rid of
unused Tx agg queues could be investigated later.
For now, just fix the off-by-one error.
ok kettenis@
Diffstat (limited to 'sys/dev/pci/if_iwxreg.h')
-rw-r--r-- | sys/dev/pci/if_iwxreg.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sys/dev/pci/if_iwxreg.h b/sys/dev/pci/if_iwxreg.h index e29148ff81f..92913cf703a 100644 --- a/sys/dev/pci/if_iwxreg.h +++ b/sys/dev/pci/if_iwxreg.h @@ -1,4 +1,4 @@ -/* $OpenBSD: if_iwxreg.h,v 1.31 2021/09/23 15:34:00 stsp Exp $ */ +/* $OpenBSD: if_iwxreg.h,v 1.32 2021/11/22 10:31:58 stsp Exp $ */ /*- * Based on BSD-licensed source modules in the Linux iwlwifi driver, @@ -1420,6 +1420,7 @@ struct iwx_gen3_bc_tbl { #define IWX_MAX_TID_COUNT 8 #define IWX_FIRST_AGG_TX_QUEUE (IWX_DQA_MGMT_QUEUE + 1) #define IWX_LAST_AGG_TX_QUEUE (IWX_FIRST_AGG_TX_QUEUE + IWX_MAX_TID_COUNT - 1) +#define IWX_NUM_TX_QUEUES (IWX_LAST_AGG_TX_QUEUE + 1) /** * Max Tx window size is the max number of contiguous TFDs that the scheduler |